httpd: reduce ifdef forest. comment out redundant PATH setting
[oweals/busybox.git] / networking / httpd.c
index 7388bb67ed4ba04ebc9ee036197348240f8168c0..3cfbdb979624d8c7961aa4eb3f941cbf5088365a 100644 (file)
@@ -97,14 +97,6 @@ static const char default_path_httpd_conf[] = "/etc";
 static const char httpd_conf[] = "httpd.conf";
 static const char home[] = "./";
 
-#if ENABLE_LFS
-# define cont_l_fmt "%lld"
-# define cont_l_type (long long)
-#else
-# define cont_l_fmt "%ld"
-# define cont_l_type (long)
-#endif
-
 #define TIMEOUT 60
 
 // Note: busybox xfuncs are not used because we want the server to keep running
@@ -151,10 +143,8 @@ typedef struct {
 #endif
        unsigned port;           /* server initial port and for
                                                      set env REMOTE_PORT */
-       union HTTPD_FOUND {
-               const char *found_mime_type;
-               const char *found_moved_temporarily;
-       } httpd_found;
+       const char *found_mime_type;
+       const char *found_moved_temporarily;
 
        off_t ContentLength;          /* -1 - unknown */
        time_t last_mod;
@@ -168,14 +158,8 @@ typedef struct {
        Htaccess *mime_a;             /* config mime types */
 #endif
 
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
+       int server_socket;
        int accepted_socket;
-# define a_c_r config->accepted_socket
-# define a_c_w config->accepted_socket
-#else
-# define a_c_r 0
-# define a_c_w 1
-#endif
        volatile int alarm_signaled;
 
 #if ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
@@ -325,20 +309,20 @@ static int scan_ip_mask(const char *ipm, unsigned int *ip, unsigned int *mask)
 
                i = 0;
                while (*p) {
-                               if (*p < '0' || *p > '9') {
-                                               if (*p == '.') {
-                                                   i = scan_ip(&ipm, mask, 0);
-                                                   return i != 32;
-                                               }
-                                               return -1;
+                       if (*p < '0' || *p > '9') {
+                               if (*p == '.') {
+                                       i = scan_ip(&ipm, mask, 0);
+                                       return i != 32;
                                }
-                               i *= 10;
-                               i += *p - '0';
-                               p++;
+                               return -1;
+                       }
+                       i *= 10;
+                       i += *p - '0';
+                       p++;
                }
        }
        if (i > 32 || i < 0)
-                       return -1;
+               return -1;
        msk = 0x80000000;
        *mask = 0;
        while (i > 0) {
@@ -399,7 +383,7 @@ static void parse_conf(const char *path, int flag)
        FILE *f;
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
        Htaccess *prev, *cur;
-#elif CONFIG_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES
+#elif ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES
        Htaccess *cur;
 #endif
 
@@ -553,7 +537,7 @@ static void parse_conf(const char *path, int flag)
                                                } else if ((cf[1] == '.') && (cf[2] == '/' || cf[2] == 0)) {
                                                        ++cf;
                                                        if (p > p0) {
-                                                               while (*--p != '/');    /* omit previous dir */
+                                                               while (*--p != '/') /* omit previous dir */;
                                                        }
                                                        continue;
                                                }
@@ -668,7 +652,7 @@ static char *encodeString(const char *string)
        *p = 0;
        return out;
 }
-#endif          /* CONFIG_FEATURE_HTTPD_ENCODE_URL_STR */
+#endif          /* FEATURE_HTTPD_ENCODE_URL_STR */
 
 /****************************************************************************
  *
@@ -723,51 +707,21 @@ static char *decodeString(char *orig, int flag_plus_to_space)
 
 #if ENABLE_FEATURE_HTTPD_CGI
 /****************************************************************************
- *
- > $Function: addEnv()
- *
- * $Description: Add an environment variable setting to the global list.
- *    A NAME=VALUE string is allocated, filled, and added to the list of
- *    environment settings passed to the cgi execution script.
- *
- * $Parameters:
- *  (char *) name_before_underline - The first part environment variable name.
- *  (char *) name_after_underline  - The second part environment variable name.
- *  (char *) value  . . The value to which the env variable is set.
- *
- * $Return: (void)
- *
- * $Errors: Silently returns if the env runs out of space to hold the new item
- *
+ * setenv helpers
  ****************************************************************************/
-static void addEnv(const char *name_before_underline,
-                       const char *name_after_underline, const char *value)
+static void setenv1(const char *name, const char *value)
 {
-       char *s = NULL;
-       const char *underline;
-
        if (!value)
                value = "";
-       underline = *name_after_underline ? "_" : "";
-       asprintf(&s, "%s%s%s=%s", name_before_underline, underline,
-                                                     name_after_underline, value);
-       if (s) {
-               putenv(s);
-       }
+       setenv(name, value, 1);
 }
-
-#if ENABLE_FEATURE_HTTPD_SET_REMOTE_PORT_TO_ENV || ENABLE_FEATURE_HTTPD_WITHOUT_INETD
-/* set environs SERVER_PORT and REMOTE_PORT */
-static void addEnvPort(const char *port_name)
+static void setenv_long(const char *name, long value)
 {
-       char buf[16];
-
-       sprintf(buf, "%u", config->port);
-       addEnv(port_name, "PORT", buf);
+       char buf[sizeof(value)*3 + 1];
+       sprintf(buf, "%ld", value);
+       setenv(name, buf, 1);
 }
 #endif
-#endif          /* CONFIG_FEATURE_HTTPD_CGI */
-
 
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
 /****************************************************************************
@@ -828,7 +782,6 @@ static void decodeBase64(char *Data)
 #endif
 
 
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
 /****************************************************************************
  *
  > $Function: openServer()
@@ -865,7 +818,6 @@ static int openServer(void)
        signal(SIGCHLD, SIG_IGN);   /* prevent zombie (defunct) processes */
        return fd;
 }
-#endif  /* CONFIG_FEATURE_HTTPD_WITHOUT_INETD */
 
 /****************************************************************************
  *
@@ -903,7 +855,7 @@ static int sendHeaders(HttpResponseNum responseNum)
        }
        /* error message is HTML */
        mime_type = responseNum == HTTP_OK ?
-                               config->httpd_found.found_mime_type : "text/html";
+                               config->found_mime_type : "text/html";
 
        /* emit the current date */
        strftime(timeStr, sizeof(timeStr), RFC1123FMT, gmtime(&timer));
@@ -920,15 +872,15 @@ static int sendHeaders(HttpResponseNum responseNum)
 #endif
        if (responseNum == HTTP_MOVED_TEMPORARILY) {
                len += sprintf(buf+len, "Location: %s/%s%s\r\n",
-                               config->httpd_found.found_moved_temporarily,
+                               config->found_moved_temporarily,
                                (config->query ? "?" : ""),
                                (config->query ? config->query : ""));
        }
 
        if (config->ContentLength != -1) {    /* file */
                strftime(timeStr, sizeof(timeStr), RFC1123FMT, gmtime(&config->last_mod));
-               len += sprintf(buf+len, "Last-Modified: %s\r\n%s " cont_l_fmt "\r\n",
-                                                     timeStr, Content_length, cont_l_type config->ContentLength);
+               len += sprintf(buf+len, "Last-Modified: %s\r\n%s %"OFF_FMT"\r\n",
+                               timeStr, Content_length, (off_t) config->ContentLength);
        }
        strcat(buf, "\r\n");
        len += 2;
@@ -940,9 +892,9 @@ static int sendHeaders(HttpResponseNum responseNum)
                                responseNum, responseString, infoString);
        }
 #if DEBUG
-       fprintf(stderr, "Headers: '%s'", buf);
+       fprintf(stderr, "headers: '%s'\n", buf);
 #endif
-       return full_write(a_c_w, buf, len);
+       return full_write(config->accepted_socket, buf, len);
 }
 
 /****************************************************************************
@@ -958,16 +910,16 @@ static int sendHeaders(HttpResponseNum responseNum)
  ****************************************************************************/
 static int getLine(void)
 {
-       int  count = 0;
+       int count = 0;
        char *buf = config->buf;
 
-       while (read(a_c_r, buf + count, 1) == 1) {
+       while (read(config->accepted_socket, buf + count, 1) == 1) {
                if (buf[count] == '\r') continue;
                if (buf[count] == '\n') {
                        buf[count] = 0;
                        return count;
                }
-               if (count < (MAX_MEMORY_BUFF-1))      /* check owerflow */
+               if (count < (MAX_MEMORY_BUFF-1))      /* check overflow */
                        count++;
        }
        if (count) return count;
@@ -998,8 +950,8 @@ static int getLine(void)
  *
  ****************************************************************************/
 static int sendCgi(const char *url,
-                                        const char *request, int bodyLen, const char *cookie,
-                                        const char *content_type)
+               const char *request, int bodyLen, const char *cookie,
+               const char *content_type)
 {
        int fromCgi[2];  /* pipe for reading data from CGI */
        int toCgi[2];    /* pipe for sending data to CGI */
@@ -1046,6 +998,9 @@ static int sendCgi(const char *url,
                        close(fromCgi[0]);
                        close(fromCgi[1]);
 
+                       close(config->accepted_socket);
+                       close(config->server_socket);
+
                        /*
                         * Find PATH_INFO.
                         */
@@ -1062,52 +1017,49 @@ static int sendCgi(const char *url,
                                }
                                *script = '/';          /* is directory, find next '/' */
                        }
-                       addEnv("PATH", "INFO", script);   /* set /PATH_INFO or NULL */
-                       addEnv("PATH",           "",         getenv("PATH"));
-                       addEnv("REQUEST",        "METHOD",   request);
+                       setenv1("PATH_INFO", script);   /* set /PATH_INFO or "" */
+                       /* setenv1("PATH", getenv("PATH")); redundant */
+                       setenv1("REQUEST_METHOD", request);
                        if (config->query) {
                                char *uri = alloca(strlen(purl) + 2 + strlen(config->query));
                                if (uri)
                                        sprintf(uri, "%s?%s", purl, config->query);
-                               addEnv("REQUEST",        "URI",   uri);
+                               setenv1("REQUEST_URI", uri);
                        } else {
-                               addEnv("REQUEST",        "URI",   purl);
+                               setenv1("REQUEST_URI", purl);
                        }
                        if (script != NULL)
                                *script = '\0';         /* reduce /PATH_INFO */
                         /* SCRIPT_FILENAME required by PHP in CGI mode */
                        if (realpath(purl + 1, realpath_buff))
-                               addEnv("SCRIPT", "FILENAME", realpath_buff);
+                               setenv1("SCRIPT_FILENAME", realpath_buff);
                        else
-                               *realpath_buff = 0;
+                               *realpath_buff = '\0';
                        /* set SCRIPT_NAME as full path: /cgi-bin/dirs/script.cgi */
-                       addEnv("SCRIPT_NAME",    "",         purl);
-                       addEnv("QUERY_STRING",   "",         config->query);
-                       addEnv("SERVER",         "SOFTWARE", httpdVersion);
-                       addEnv("SERVER",         "PROTOCOL", "HTTP/1.0");
-                       addEnv("GATEWAY_INTERFACE", "",      "CGI/1.1");
-                       addEnv("REMOTE",         "ADDR",     config->rmt_ip_str);
+                       setenv1("SCRIPT_NAME", purl);
+                       setenv1("QUERY_STRING", config->query);
+                       setenv1("SERVER_SOFTWARE", httpdVersion);
+                       putenv("SERVER_PROTOCOL=HTTP/1.0");
+                       putenv("GATEWAY_INTERFACE=CGI/1.1");
+                       setenv1("REMOTE_ADDR", config->rmt_ip_str);
 #if ENABLE_FEATURE_HTTPD_SET_REMOTE_PORT_TO_ENV
-                       addEnvPort("REMOTE");
+                       setenv_long("REMOTE_PORT", config->port);
 #endif
                        if (bodyLen) {
-                               char sbl[32];
-
-                               sprintf(sbl, "%d", bodyLen);
-                               addEnv("CONTENT", "LENGTH", sbl);
+                               setenv_long("CONTENT_LENGTH", bodyLen);
                        }
                        if (cookie)
-                               addEnv("HTTP", "COOKIE", cookie);
+                               setenv1("HTTP_COOKIE", cookie);
                        if (content_type)
-                               addEnv("CONTENT", "TYPE", content_type);
+                               setenv1("CONTENT_TYPE", content_type);
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
                        if (config->remoteuser) {
-                               addEnv("REMOTE", "USER", config->remoteuser);
-                               addEnv("AUTH_TYPE", "", "Basic");
+                               setenv1("REMOTE_USER", config->remoteuser);
+                               putenv("AUTH_TYPE=Basic");
                        }
 #endif
                        if (config->referer)
-                               addEnv("HTTP", "REFERER", config->referer);
+                               setenv1("HTTP_REFERER", config->referer);
 
                        /* set execve argp[0] without path */
                        argp[0] = strrchr(purl, '/') + 1;
@@ -1143,9 +1095,8 @@ static int sendCgi(const char *url,
                                        }
                                }
                        }
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
-                       config->accepted_socket = 1;      /* send to stdout */
-#endif
+                       /* send to stdout (even if we are not from inetd) */
+                       config->accepted_socket = 1;
                        sendHeaders(HTTP_NOT_FOUND);
                        _exit(242);
                } /* end child */
@@ -1177,9 +1128,9 @@ static int sendCgi(const char *url,
                                FD_SET(outFd, &writeSet);
                                nfound = outFd > inFd ? outFd : inFd;
                                if (post_readed_size == 0) {
-                                       FD_SET(a_c_r, &readSet);
-                                       if (nfound < a_c_r)
-                                               nfound = a_c_r;
+                                       FD_SET(config->accepted_socket, &readSet);
+                                       if (nfound < config->accepted_socket)
+                                               nfound = config->accepted_socket;
                                }
                                /* Now wait on the set of sockets! */
                                nfound = select(nfound + 1, &readSet, &writeSet, 0, NULL);
@@ -1194,12 +1145,10 @@ static int sendCgi(const char *url,
                        if (nfound <= 0) {
                                if (waitpid(pid, &status, WNOHANG) > 0) {
                                        close(inFd);
-#if DEBUG
-                                       if (WIFEXITED(status))
+                                       if (DEBUG && WIFEXITED(status))
                                                bb_error_msg("piped has exited with status=%d", WEXITSTATUS(status));
-                                       if (WIFSIGNALED(status))
+                                       if (DEBUG && WIFSIGNALED(status))
                                                bb_error_msg("piped has exited with signal=%d", WTERMSIG(status));
-#endif
                                        break;
                                }
                        } else if (post_readed_size > 0 && FD_ISSET(outFd, &writeSet)) {
@@ -1212,9 +1161,9 @@ static int sendCgi(const char *url,
                                } else {
                                        post_readed_size = post_readed_idx = bodyLen = 0; /* broken pipe to CGI */
                                }
-                       } else if (bodyLen > 0 && post_readed_size == 0 && FD_ISSET(a_c_r, &readSet)) {
+                       } else if (bodyLen > 0 && post_readed_size == 0 && FD_ISSET(config->accepted_socket, &readSet)) {
                                count = bodyLen > (int)sizeof(wbuf) ? (int)sizeof(wbuf) : bodyLen;
-                               count = safe_read(a_c_r, wbuf, count);
+                               count = safe_read(config->accepted_socket, wbuf, count);
                                if (count > 0) {
                                        post_readed_size += count;
                                        bodyLen -= count;
@@ -1223,7 +1172,7 @@ static int sendCgi(const char *url,
                                }
                        }
                        if (FD_ISSET(inFd, &readSet)) {
-                               int s = a_c_w;
+                               int s = config->accepted_socket;
                                char *rbuf = config->buf;
 
 #ifndef PIPE_BUF
@@ -1254,22 +1203,21 @@ static int sendCgi(const char *url,
                                        if (full_write(s, rbuf, count) != count)
                                                break;
 
-#if DEBUG
-                                       fprintf(stderr, "cgi read %d bytes\n", count);
-#endif
+                                       if (DEBUG)
+                                               fprintf(stderr, "cgi read %d bytes\n", count);
                                }
                        }
                }
        }
        return 0;
 }
-#endif          /* CONFIG_FEATURE_HTTPD_CGI */
+#endif          /* FEATURE_HTTPD_CGI */
 
 /****************************************************************************
  *
  > $Function: sendFile()
  *
- * $Description: Send a file response to an HTTP request
+ * $Description: Send a file response to a HTTP request
  *
  * $Parameter:
  *      (const char *) url . . The URL requested.
@@ -1293,24 +1241,23 @@ static int sendFile(const char *url)
                                break;
                }
        /* also, if not found, set default as "application/octet-stream";  */
-       config->httpd_found.found_mime_type = *(table+1);
+       config->found_mime_type = table[1];
 #if ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES
        if (suffix) {
                Htaccess * cur;
 
                for (cur = config->mime_a; cur; cur = cur->next) {
                        if (strcmp(cur->before_colon, suffix) == 0) {
-                               config->httpd_found.found_mime_type = cur->after_colon;
+                               config->found_mime_type = cur->after_colon;
                                break;
                        }
                }
        }
-#endif  /* CONFIG_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES */
+#endif  /* FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES */
 
-#if DEBUG
-       fprintf(stderr, "Sending file '%s' Content-type: %s\n",
-                                               url, config->httpd_found.found_mime_type);
-#endif
+       if (DEBUG)
+               fprintf(stderr, "sending file '%s' content-type: %s\n",
+                       url, config->found_mime_type);
 
        f = open(url, O_RDONLY);
        if (f >= 0) {
@@ -1318,15 +1265,15 @@ static int sendFile(const char *url)
                char *buf = config->buf;
 
                sendHeaders(HTTP_OK);
+               /* TODO: sendfile() */
                while ((count = full_read(f, buf, MAX_MEMORY_BUFF)) > 0) {
-                       if (full_write(a_c_w, buf, count) != count)
+                       if (full_write(config->accepted_socket, buf, count) != count)
                                break;
                }
                close(f);
        } else {
-#if DEBUG
-               bb_perror_msg("Unable to open '%s'", url);
-#endif
+               if (DEBUG)
+                       bb_perror_msg("cannot open '%s'", url);
                sendHeaders(HTTP_NOT_FOUND);
        }
 
@@ -1339,18 +1286,18 @@ static int checkPermIP(void)
 
        /* This could stand some work */
        for (cur = config->ip_a_d; cur; cur = cur->next) {
-#if DEBUG
-               fprintf(stderr, "checkPermIP: '%s' ? ", config->rmt_ip_str);
-               fprintf(stderr, "'%u.%u.%u.%u/%u.%u.%u.%u'\n",
+               if (DEBUG)
+                       fprintf(stderr, "checkPermIP: '%s' ? ", config->rmt_ip_str);
+               if (DEBUG)
+                       fprintf(stderr, "'%u.%u.%u.%u/%u.%u.%u.%u'\n",
                                (unsigned char)(cur->ip >> 24),
                                (unsigned char)(cur->ip >> 16),
                                (unsigned char)(cur->ip >> 8),
-                                                   cur->ip & 0xff,
+                                               cur->ip & 0xff,
                                (unsigned char)(cur->mask >> 24),
                                (unsigned char)(cur->mask >> 16),
                                (unsigned char)(cur->mask >> 8),
-                                                   cur->mask & 0xff);
-#endif
+                                               cur->mask & 0xff);
                if ((config->rmt_ip & cur->mask) == cur->ip)
                        return cur->allow_deny == 'A';   /* Allow/Deny */
        }
@@ -1387,67 +1334,64 @@ static int checkPerm(const char *path, const char *request)
 
        /* This could stand some work */
        for (cur = config->auth; cur; cur = cur->next) {
+               size_t l;
+
                p0 = cur->before_colon;
                if (prev != NULL && strcmp(prev, p0) != 0)
                        continue;       /* find next identical */
                p = cur->after_colon;
-#if DEBUG
-               fprintf(stderr, "checkPerm: '%s' ? '%s'\n", p0, request);
-#endif
-               {
-                       size_t l = strlen(p0);
-
-                       if (strncmp(p0, path, l) == 0 &&
-                                           (l == 1 || path[l] == '/' || path[l] == 0)) {
-                               char *u;
-                               /* path match found.  Check request */
-                               /* for check next /path:user:password */
-                               prev = p0;
-                               u = strchr(request, ':');
-                               if (u == NULL) {
-                                       /* bad request, ':' required */
-                                       break;
-                               }
+               if (DEBUG)
+                       fprintf(stderr, "checkPerm: '%s' ? '%s'\n", p0, request);
+
+               l = strlen(p0);
+               if (strncmp(p0, path, l) == 0
+                && (l == 1 || path[l] == '/' || path[l] == '\0')
+               ) {
+                       char *u;
+                       /* path match found.  Check request */
+                       /* for check next /path:user:password */
+                       prev = p0;
+                       u = strchr(request, ':');
+                       if (u == NULL) {
+                               /* bad request, ':' required */
+                               break;
+                       }
 
-#if ENABLE_FEATURE_HTTPD_AUTH_MD5
-                               {
-                                       char *cipher;
-                                       char *pp;
+                       if (ENABLE_FEATURE_HTTPD_AUTH_MD5) {
+                               char *cipher;
+                               char *pp;
 
                                if (strncmp(p, request, u-request) != 0) {
-                                               /* user uncompared */
-                                               continue;
-                                       }
-                                       pp = strchr(p, ':');
-                                       if (pp && pp[1] == '$' && pp[2] == '1' &&
-                                                       pp[3] == '$' && pp[4]) {
-                                               pp++;
-                                               cipher = pw_encrypt(u+1, pp);
-                                               if (strcmp(cipher, pp) == 0)
-                                                       goto set_remoteuser_var;   /* Ok */
-                                               /* unauthorized */
-                                               continue;
-                                       }
+                                       /* user uncompared */
+                                       continue;
                                }
-#endif
-                               if (strcmp(p, request) == 0) {
-#if ENABLE_FEATURE_HTTPD_AUTH_MD5
-set_remoteuser_var:
-#endif
-                                       config->remoteuser = strdup(request);
-                                       if (config->remoteuser)
-                                               config->remoteuser[(u - request)] = 0;
-                                       return 1;   /* Ok */
+                               pp = strchr(p, ':');
+                               if (pp && pp[1] == '$' && pp[2] == '1' &&
+                                               pp[3] == '$' && pp[4]) {
+                                       pp++;
+                                       cipher = pw_encrypt(u+1, pp);
+                                       if (strcmp(cipher, pp) == 0)
+                                               goto set_remoteuser_var;   /* Ok */
+                                       /* unauthorized */
+                                       continue;
                                }
-                               /* unauthorized */
                        }
+
+                       if (strcmp(p, request) == 0) {
+set_remoteuser_var:
+                               config->remoteuser = strdup(request);
+                               if (config->remoteuser)
+                                       config->remoteuser[(u - request)] = 0;
+                               return 1;   /* Ok */
+                       }
+                       /* unauthorized */
                }
        }   /* for */
 
        return prev == NULL;
 }
 
-#endif  /* CONFIG_FEATURE_HTTPD_BASIC_AUTH */
+#endif  /* FEATURE_HTTPD_BASIC_AUTH */
 
 /****************************************************************************
  *
@@ -1459,8 +1403,8 @@ set_remoteuser_var:
 
 static void handle_sigalrm(int sig)
 {
-               sendHeaders(HTTP_REQUEST_TIMEOUT);
-               config->alarm_signaled = sig;
+       sendHeaders(HTTP_REQUEST_TIMEOUT);
+       config->alarm_signaled = sig;
 }
 
 /****************************************************************************
@@ -1481,7 +1425,7 @@ static void handleIncoming(void)
        int ip_allowed;
 #if ENABLE_FEATURE_HTTPD_CGI
        const char *prequest = request_GET;
-       long length=0;
+       long length = 0;
        char *cookie = 0;
        char *content_type = 0;
 #endif
@@ -1491,7 +1435,7 @@ static void handleIncoming(void)
        struct sigaction sa;
 
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
-       int credentials = -1;  /* if not requred this is Ok */
+       int credentials = -1;  /* if not required this is Ok */
 #endif
 
        sa.sa_handler = handle_sigalrm;
@@ -1534,7 +1478,7 @@ BAD_REQUEST:
                        /* Garbled request/URL */
                        goto BAD_REQUEST;
                }
-               url = alloca(strlen(buf) + 12);      /* + sizeof("/index.html\0") */
+               url = alloca(strlen(buf) + sizeof("/index.html"));
                if (url == NULL) {
                        sendHeaders(HTTP_INTERNAL_SERVER_ERROR);
                        break;
@@ -1571,8 +1515,8 @@ BAD_REQUEST:
                                                        /* protect out root */
                                                        goto BAD_REQUEST;
                                                }
-                                               while (*--purl != '/');    /* omit previous dir */
-                                                       continue;
+                                               while (*--purl != '/') /* omit previous dir */;
+                                               continue;
                                        }
                                }
                        }
@@ -1585,12 +1529,11 @@ BAD_REQUEST:
                /* If URL is directory, adding '/' */
                if (test[-1] != '/') {
                        if (is_directory(url + 1, 1, &sb)) {
-                               config->httpd_found.found_moved_temporarily = url;
+                               config->found_moved_temporarily = url;
                        }
                }
-#if DEBUG
-               fprintf(stderr, "url='%s', args=%s\n", url, config->query);
-#endif
+               if (DEBUG)
+                       fprintf(stderr, "url='%s', args=%s\n", url, config->query);
 
                test = url;
                ip_allowed = checkPermIP();
@@ -1612,9 +1555,8 @@ BAD_REQUEST:
                                if (count <= 0)
                                        break;
 
-#if DEBUG
-                               fprintf(stderr, "Header: '%s'\n", buf);
-#endif
+                               if (DEBUG)
+                                       fprintf(stderr, "header: '%s'\n", buf);
 
 #if ENABLE_FEATURE_HTTPD_CGI
                                /* try and do our best to parse more lines */
@@ -1651,7 +1593,7 @@ BAD_REQUEST:
                                        decodeBase64(test);
                                        credentials = checkPerm(url, test);
                                }
-#endif          /* CONFIG_FEATURE_HTTPD_BASIC_AUTH */
+#endif          /* FEATURE_HTTPD_BASIC_AUTH */
 
                        } /* while extra header reading */
                }
@@ -1660,9 +1602,9 @@ BAD_REQUEST:
                        break;
 
                if (strcmp(strrchr(url, '/') + 1, httpd_conf) == 0 || ip_allowed == 0) {
-                               /* protect listing [/path]/httpd_conf or IP deny */
+                       /* protect listing [/path]/httpd_conf or IP deny */
 #if ENABLE_FEATURE_HTTPD_CGI
-FORBIDDEN:      /* protect listing /cgi-bin */
+FORBIDDEN:             /* protect listing /cgi-bin */
 #endif
                        sendHeaders(HTTP_FORBIDDEN);
                        break;
@@ -1675,12 +1617,10 @@ FORBIDDEN:      /* protect listing /cgi-bin */
                }
 #endif
 
-               if (config->httpd_found.found_moved_temporarily) {
+               if (config->found_moved_temporarily) {
                        sendHeaders(HTTP_MOVED_TEMPORARILY);
-#if DEBUG
                        /* clear unforked memory flag */
-                       config->httpd_found.found_moved_temporarily = NULL;
-#endif
+                       config->found_moved_temporarily = NULL;
                        break;
                }
 
@@ -1699,7 +1639,7 @@ FORBIDDEN:      /* protect listing /cgi-bin */
                        if (prequest != request_GET)
                                sendHeaders(HTTP_NOT_IMPLEMENTED);
                        else {
-#endif  /* CONFIG_FEATURE_HTTPD_CGI */
+#endif  /* FEATURE_HTTPD_CGI */
                                if (purl[-1] == '/')
                                        strcpy(purl, "index.html");
                                if (stat(test, &sb) == 0) {
@@ -1707,49 +1647,38 @@ FORBIDDEN:      /* protect listing /cgi-bin */
                                        config->last_mod = sb.st_mtime;
                                }
                                sendFile(test);
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
-                               /* unset if non inetd looped */
                                config->ContentLength = -1;
-#endif
-
 #if ENABLE_FEATURE_HTTPD_CGI
                        }
                }
 #endif
-
        } while (0);
 
-
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
-/* from inetd don't looping: freeing, closing automatic from exit always */
-# if DEBUG
-       fprintf(stderr, "closing socket\n");
-# endif
-# ifdef CONFIG_FEATURE_HTTPD_CGI
+       if (DEBUG)
+               fprintf(stderr, "closing socket\n\n");
+#if ENABLE_FEATURE_HTTPD_CGI
        free(cookie);
        free(content_type);
-       free(config->referer);
-#if ENABLE_FEATURE_HTTPD_BASIC_AUTH
-       free(config->remoteuser);
-#endif
+       free(config->referer); config->referer = NULL;
+# if ENABLE_FEATURE_HTTPD_BASIC_AUTH
+       free(config->remoteuser); config->remoteuser = NULL;
 # endif
-#endif  /* CONFIG_FEATURE_HTTPD_WITHOUT_INETD */
-       shutdown(a_c_w, SHUT_WR);
+#endif
+       shutdown(config->accepted_socket, SHUT_WR);
 
        /* Properly wait for remote to closed */
        FD_ZERO(&s_fd);
-       FD_SET(a_c_r, &s_fd);
+       FD_SET(config->accepted_socket, &s_fd);
 
        do {
                tv.tv_sec = 2;
                tv.tv_usec = 0;
-               retval = select(a_c_r + 1, &s_fd, NULL, NULL, &tv);
-       } while (retval > 0 && read(a_c_r, buf, sizeof(config->buf) > 0));
+               retval = select(config->accepted_socket + 1, &s_fd, NULL, NULL, &tv);
+       } while (retval > 0 && read(config->accepted_socket, buf, sizeof(config->buf) > 0));
 
-       shutdown(a_c_r, SHUT_RD);
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
+       shutdown(config->accepted_socket, SHUT_RD);
+       /* In inetd case, we close fd 1 (stdout) here. We will exit soon anyway */
        close(config->accepted_socket);
-#endif  /* CONFIG_FEATURE_HTTPD_WITHOUT_INETD */
 }
 
 /****************************************************************************
@@ -1767,7 +1696,6 @@ FORBIDDEN:      /* protect listing /cgi-bin */
  * $Return: (int) . . . . Always 0.
  *
  ****************************************************************************/
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
 static int miniHttpd(int server)
 {
        fd_set readfd, portfd;
@@ -1777,65 +1705,59 @@ static int miniHttpd(int server)
 
        /* copy the ports we are watching to the readfd set */
        while (1) {
-               readfd = portfd;
+               int on, s;
+               socklen_t fromAddrLen;
+               struct sockaddr_in fromAddr;
 
                /* Now wait INDEFINITELY on the set of sockets! */
-               if (select(server + 1, &readfd, 0, 0, 0) > 0) {
-                       if (FD_ISSET(server, &readfd)) {
-                               int on;
-                               struct sockaddr_in fromAddr;
-
-                               socklen_t fromAddrLen = sizeof(fromAddr);
-                               int s = accept(server,
-                                          (struct sockaddr *)&fromAddr, &fromAddrLen);
-
-                               if (s < 0) {
-                                       continue;
-                               }
-                               config->accepted_socket = s;
-                               config->rmt_ip = ntohl(fromAddr.sin_addr.s_addr);
+               readfd = portfd;
+               if (select(server + 1, &readfd, 0, 0, 0) <= 0)
+                       continue;
+               if (!FD_ISSET(server, &readfd))
+                       continue;
+               fromAddrLen = sizeof(fromAddr);
+               s = accept(server, (struct sockaddr *)&fromAddr, &fromAddrLen);
+               if (s < 0)
+                       continue;
+               config->accepted_socket = s;
+               config->rmt_ip = ntohl(fromAddr.sin_addr.s_addr);
 #if ENABLE_FEATURE_HTTPD_CGI || DEBUG
-                               sprintf(config->rmt_ip_str, "%u.%u.%u.%u",
-                                               (unsigned char)(config->rmt_ip >> 24),
-                                               (unsigned char)(config->rmt_ip >> 16),
-                                               (unsigned char)(config->rmt_ip >> 8),
-                                                   config->rmt_ip & 0xff);
-                               config->port = ntohs(fromAddr.sin_port);
+               sprintf(config->rmt_ip_str, "%u.%u.%u.%u",
+                               (unsigned char)(config->rmt_ip >> 24),
+                               (unsigned char)(config->rmt_ip >> 16),
+                               (unsigned char)(config->rmt_ip >> 8),
+                               config->rmt_ip & 0xff);
+               config->port = ntohs(fromAddr.sin_port);
 #if DEBUG
-                               bb_error_msg("connection from IP=%s, port %u",
-                                               config->rmt_ip_str, config->port);
+               bb_error_msg("connection from IP=%s, port %u",
+                               config->rmt_ip_str, config->port);
 #endif
-#endif /* CONFIG_FEATURE_HTTPD_CGI */
-
-                               /*  set the KEEPALIVE option to cull dead connections */
-                               on = 1;
-                               setsockopt(s, SOL_SOCKET, SO_KEEPALIVE, (void *)&on, sizeof(on));
+#endif /* FEATURE_HTTPD_CGI */
 
+               /* set the KEEPALIVE option to cull dead connections */
+               on = 1;
+               setsockopt(s, SOL_SOCKET, SO_KEEPALIVE, (void *)&on, sizeof(on));
 #if !DEBUG
-                               if (fork() == 0)
+               if (fork() == 0)
 #endif
-                               {
-                                       /* This is the spawned thread */
+               {
+                       /* This is the spawned thread */
 #if ENABLE_FEATURE_HTTPD_RELOAD_CONFIG_SIGHUP
-                                       /* protect reload config, may be confuse checking */
-                                       signal(SIGHUP, SIG_IGN);
+                       /* protect reload config, may be confuse checking */
+                       signal(SIGHUP, SIG_IGN);
 #endif
-                                       handleIncoming();
+                       handleIncoming();
 #if !DEBUG
-                                       exit(0);
+                       exit(0);
 #endif
-                               }
-                               close(s);
-                       }
                }
+               close(s);
        } // while (1)
        return 0;
 }
 
-#else
-       /* from inetd */
-
-static int miniHttpd(void)
+/* from inetd */
+static int miniHttpd_inetd(void)
 {
        struct sockaddr_in fromAddrLen;
        socklen_t sinlen = sizeof(struct sockaddr_in);
@@ -1847,13 +1769,12 @@ static int miniHttpd(void)
                                (unsigned char)(config->rmt_ip >> 24),
                                (unsigned char)(config->rmt_ip >> 16),
                                (unsigned char)(config->rmt_ip >> 8),
-                                                   config->rmt_ip & 0xff);
+                                               config->rmt_ip & 0xff);
 #endif
        config->port = ntohs(fromAddrLen.sin_port);
        handleIncoming();
        return 0;
 }
-#endif  /* CONFIG_FEATURE_HTTPD_WITHOUT_INETD */
 
 #if ENABLE_FEATURE_HTTPD_RELOAD_CONFIG_SIGHUP
 static void sighup_handler(int sig)
@@ -1869,15 +1790,27 @@ static void sighup_handler(int sig)
 }
 #endif
 
-enum httpd_opts_nums {
+enum {
        c_opt_config_file = 0,
        d_opt_decode_url,
        h_opt_home_httpd,
        USE_FEATURE_HTTPD_ENCODE_URL_STR(e_opt_encode_url,)
-       USE_FEATURE_HTTPD_BASIC_AUTH(r_opt_realm,)
-       USE_FEATURE_HTTPD_AUTH_MD5(m_opt_md5,)
-       USE_FEATURE_HTTPD_SETUID(u_opt_setuid,)
-       USE_FEATURE_HTTPD_WITHOUT_INETD(p_opt_port,)
+       USE_FEATURE_HTTPD_BASIC_AUTH(    r_opt_realm     ,)
+       USE_FEATURE_HTTPD_AUTH_MD5(      m_opt_md5       ,)
+       USE_FEATURE_HTTPD_SETUID(        u_opt_setuid    ,)
+       p_opt_port      ,
+       p_opt_inetd     ,
+       p_opt_foreground,
+       OPT_CONFIG_FILE = 1 << c_opt_config_file,
+       OPT_DECODE_URL  = 1 << d_opt_decode_url,
+       OPT_HOME_HTTPD  = 1 << h_opt_home_httpd,
+       OPT_ENCODE_URL  = USE_FEATURE_HTTPD_ENCODE_URL_STR((1 << e_opt_encode_url)) + 0,
+       OPT_REALM       = USE_FEATURE_HTTPD_BASIC_AUTH(    (1 << r_opt_realm     )) + 0,
+       OPT_MD5         = USE_FEATURE_HTTPD_AUTH_MD5(      (1 << m_opt_md5       )) + 0,
+       OPT_SETUID      = USE_FEATURE_HTTPD_SETUID(        (1 << u_opt_setuid    )) + 0,
+       OPT_PORT        = 1 << p_opt_port,
+       OPT_INETD       = 1 << p_opt_inetd,
+       OPT_FOREGROUND  = 1 << p_opt_foreground,
 };
 
 static const char httpd_opts[] = "c:d:h:"
@@ -1885,62 +1818,35 @@ static const char httpd_opts[] = "c:d:h:"
        USE_FEATURE_HTTPD_BASIC_AUTH("r:")
        USE_FEATURE_HTTPD_AUTH_MD5("m:")
        USE_FEATURE_HTTPD_SETUID("u:")
-       USE_FEATURE_HTTPD_WITHOUT_INETD("p:");
-
-#define OPT_CONFIG_FILE (1<<c_opt_config_file)
-#define OPT_DECODE_URL  (1<<d_opt_decode_url)
-#define OPT_HOME_HTTPD  (1<<h_opt_home_httpd)
-
-#define OPT_ENCODE_URL  USE_FEATURE_HTTPD_ENCODE_URL_STR((1<<e_opt_encode_url)) \
-                                               SKIP_FEATURE_HTTPD_ENCODE_URL_STR(0)
-
-#define OPT_REALM       USE_FEATURE_HTTPD_BASIC_AUTH((1<<r_opt_realm)) \
-                                               SKIP_FEATURE_HTTPD_BASIC_AUTH(0)
-
-#define OPT_MD5         USE_FEATURE_HTTPD_AUTH_MD5((1<<m_opt_md5)) \
-                                               SKIP_FEATURE_HTTPD_AUTH_MD5(0)
-
-#define OPT_SETUID      USE_FEATURE_HTTPD_SETUID((1<<u_opt_setuid)) \
-                                               SKIP_FEATURE_HTTPD_SETUID(0)
-
-#define OPT_PORT        USE_FEATURE_HTTPD_WITHOUT_INETD((1<<p_opt_port)) \
-                                               SKIP_FEATURE_HTTPD_WITHOUT_INETD(0)
+       "p:if";
 
 
 int httpd_main(int argc, char *argv[])
 {
-       unsigned long opt;
+       unsigned opt;
        const char *home_httpd = home;
        char *url_for_decode;
        USE_FEATURE_HTTPD_ENCODE_URL_STR(const char *url_for_encode;)
-       USE_FEATURE_HTTPD_WITHOUT_INETD(const char *s_port;)
-       USE_FEATURE_HTTPD_WITHOUT_INETD(int server;)
-
-       USE_FEATURE_HTTPD_SETUID(const char *s_uid;)
-       USE_FEATURE_HTTPD_SETUID(long uid = -1;)
-
+       const char *s_port;
+       USE_FEATURE_HTTPD_SETUID(const char *s_ugid = NULL;)
+       USE_FEATURE_HTTPD_SETUID(struct bb_uidgid_t ugid;)
        USE_FEATURE_HTTPD_AUTH_MD5(const char *pass;)
 
        config = xzalloc(sizeof(*config));
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
        config->realm = "Web Server Authentication";
 #endif
-
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
        config->port = 80;
-#endif
-
        config->ContentLength = -1;
 
-       opt = bb_getopt_ulflags(argc, argv, httpd_opts,
+       opt = getopt32(argc, argv, httpd_opts,
                        &(config->configFile), &url_for_decode, &home_httpd
                        USE_FEATURE_HTTPD_ENCODE_URL_STR(, &url_for_encode)
                        USE_FEATURE_HTTPD_BASIC_AUTH(, &(config->realm))
                        USE_FEATURE_HTTPD_AUTH_MD5(, &pass)
-                       USE_FEATURE_HTTPD_SETUID(, &s_uid)
-                       USE_FEATURE_HTTPD_WITHOUT_INETD(, &s_port)
+                       USE_FEATURE_HTTPD_SETUID(, &s_ugid)
+                       , &s_port
                );
-
        if (opt & OPT_DECODE_URL) {
                printf("%s", decodeString(url_for_decode, 1));
                return 0;
@@ -1957,31 +1863,43 @@ int httpd_main(int argc, char *argv[])
                return 0;
        }
 #endif
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
        if (opt & OPT_PORT)
-               config->port = bb_xgetlarg(s_port, 10, 1, 0xffff);
+               config->port = xatou16(s_port);
+
 #if ENABLE_FEATURE_HTTPD_SETUID
        if (opt & OPT_SETUID) {
                char *e;
-
-               uid = strtol(s_uid, &e, 0);
+               // FIXME: what the default group should be?
+               ugid.gid = -1;
+               ugid.uid = strtoul(s_ugid, &e, 0);
+               if (*e == ':') {
+                       e++;
+                       ugid.gid = strtoul(e, &e, 0);
+               }
                if (*e != '\0') {
                        /* not integer */
-                       uid = bb_xgetpwnam(s_uid);
+                       if (!uidgid_get(&ugid, s_ugid))
+                               bb_error_msg_and_die("unrecognized user[:group] "
+                                               "name '%s'", s_ugid);
                }
        }
-#endif
 #endif
 
        xchdir(home_httpd);
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
-       server = openServer();
-# ifdef CONFIG_FEATURE_HTTPD_SETUID
-       /* drop privileges */
-       if (uid > 0)
-               xsetuid(uid);
-# endif
+       if (!(opt & OPT_INETD)) {
+               config->server_socket = openServer();
+#if ENABLE_FEATURE_HTTPD_SETUID
+               /* drop privileges */
+               if (opt & OPT_SETUID) {
+                       if (ugid.gid != (gid_t)-1) {
+                               if (setgroups(1, &ugid.gid) == -1)
+                                       bb_perror_msg_and_die("setgroups");
+                               xsetgid(ugid.gid);
+                       }
+                       xsetuid(ugid.uid);
+               }
 #endif
+       }
 
 #if ENABLE_FEATURE_HTTPD_CGI
        {
@@ -1991,10 +1909,9 @@ int httpd_main(int argc, char *argv[])
                }
                clearenv();
                if (p)
-                       setenv("PATH", p, 1);
-# ifdef CONFIG_FEATURE_HTTPD_WITHOUT_INETD
-               addEnvPort("SERVER");
-# endif
+                       setenv1("PATH", p);
+               if (!(opt & OPT_INETD))
+                       setenv_long("SERVER_PORT", config->port);
        }
 #endif
 
@@ -2004,12 +1921,10 @@ int httpd_main(int argc, char *argv[])
        parse_conf(default_path_httpd_conf, FIRST_PARSE);
 #endif
 
-#if ENABLE_FEATURE_HTTPD_WITHOUT_INETD
-# if !DEBUG
-       xdaemon(1, 0);     /* don't change curent directory */
-# endif
-       return miniHttpd(server);
-#else
-       return miniHttpd();
-#endif
+       if (opt & OPT_INETD)
+               return miniHttpd_inetd();
+
+       if (!(opt & OPT_FOREGROUND))
+               xdaemon(1, 0);     /* don't change current directory */
+       return miniHttpd(config->server_socket);
 }