wget: add TODO
[oweals/busybox.git] / networking / arping.c
index 90a03a58e4a0e5976b9083eefcbf4c335c4f5d46..e4c9b86a9df90aff76fa59acfa491f3aa4df70a5 100644 (file)
@@ -1,4 +1,4 @@
-/* vi:set ts=4:*/
+/* vi: set sw=4 ts=4: */
 /*
  * arping.c - Ping hosts by ARP requests/replies
  *
@@ -10,7 +10,6 @@
 
 #include <sys/ioctl.h>
 #include <signal.h>
-#include <sys/time.h>
 
 #include <errno.h>
 #include <stdlib.h>
@@ -29,20 +28,21 @@ static struct in_addr dst;
 static struct sockaddr_ll me;
 static struct sockaddr_ll he;
 static struct timeval last;
-struct cfg_s {
-       int dad:1;
-       int unsolicited:1;
-       int advert:1;
-       int quiet:1;
-       int quit_on_reply:1;
-       int unicasting:1;
-       int broadcast_only:1;
+
+enum cfg_e {
+       dad = 1,
+       unsolicited = 2,
+       advert = 4,
+       quiet = 8,
+       quit_on_reply = 16,
+       broadcast_only = 32,
+       unicasting = 64
 };
-static struct cfg_s cfg;
+static int cfg;
 
 static int s;
-static int count = -1;
-static int timeout;
+static unsigned count = UINT_MAX;
+static unsigned timeout;
 static int sent;
 static int brd_sent;
 static int received;
@@ -52,18 +52,6 @@ static int req_recv;
 
 #define MS_TDIFF(tv1,tv2) ( ((tv1).tv_sec-(tv2).tv_sec)*1000 + \
                           ((tv1).tv_usec-(tv2).tv_usec)/1000 )
-#if 0
-static void set_signal(int signo, void (*handler) (void))
-{
-       struct sigaction sa;
-
-       memset(&sa, 0, sizeof(sa));
-       sa.sa_handler = (void (*)(int)) handler;
-       sa.sa_flags = SA_RESTART;
-       sigaction(signo, &sa, NULL);
-}
-#endif
-
 static int send_pack(int sock, struct in_addr *src_addr,
                                         struct in_addr *dst_addr, struct sockaddr_ll *ME,
                                         struct sockaddr_ll *HE)
@@ -79,7 +67,7 @@ static int send_pack(int sock, struct in_addr *src_addr,
        ah->ar_pro = htons(ETH_P_IP);
        ah->ar_hln = ME->sll_halen;
        ah->ar_pln = 4;
-       ah->ar_op = cfg.advert ? htons(ARPOP_REPLY) : htons(ARPOP_REQUEST);
+       ah->ar_op = cfg&advert ? htons(ARPOP_REPLY) : htons(ARPOP_REQUEST);
 
        memcpy(p, &ME->sll_addr, ah->ar_hln);
        p += ME->sll_halen;
@@ -87,7 +75,7 @@ static int send_pack(int sock, struct in_addr *src_addr,
        memcpy(p, src_addr, 4);
        p += 4;
 
-       if (cfg.advert)
+       if (cfg&advert)
                memcpy(p, &ME->sll_addr, ah->ar_hln);
        else
                memcpy(p, &HE->sll_addr, ah->ar_hln);
@@ -101,7 +89,7 @@ static int send_pack(int sock, struct in_addr *src_addr,
        if (err == p - buf) {
                last = now;
                sent++;
-               if (!cfg.unicasting)
+               if (!(cfg&unicasting))
                        brd_sent++;
        }
        RELEASE_CONFIG_BUFFER(buf);
@@ -110,9 +98,11 @@ static int send_pack(int sock, struct in_addr *src_addr,
 
 static void finish(void)
 {
-       if (!cfg.quiet) {
-               printf("Sent %d probes (%d broadcast(s))\n", sent, brd_sent);
-               printf("Received %d repl%s", received, (received > 1) ? "ies" : "y");
+       if (!(cfg&quiet)) {
+               printf("Sent %d probes (%d broadcast(s))\n"
+                       "Received %d repl%s",
+                       sent, brd_sent,
+                       received, (received > 1) ? "ies" : "y");
                if (brd_recv || req_recv) {
                        printf(" (");
                        if (req_recv)
@@ -124,9 +114,9 @@ static void finish(void)
                putchar('\n');
                fflush(stdout);
        }
-       if (cfg.dad)
+       if (cfg&dad)
                exit(!!received);
-       if (cfg.unsolicited)
+       if (cfg&unsolicited)
                exit(0);
        exit(!received);
 }
@@ -147,7 +137,7 @@ static void catcher(void)
 
        if (last.tv_sec == 0 || MS_TDIFF(tv, last) > 500) {
                send_pack(s, &src, &dst, &me, &he);
-               if (count == 0 && cfg.unsolicited)
+               if (count == 0 && cfg&unsolicited)
                        finish();
        }
        alarm(1);
@@ -186,7 +176,7 @@ static int recv_pack(unsigned char *buf, int len, struct sockaddr_ll *FROM)
                return 0;
        memcpy(&src_ip, p + ah->ar_hln, 4);
        memcpy(&dst_ip, p + ah->ar_hln + 4 + ah->ar_hln, 4);
-       if (!cfg.dad) {
+       if (!(cfg&dad)) {
                if (src_ip.s_addr != dst.s_addr)
                        return 0;
                if (src.s_addr != dst_ip.s_addr)
@@ -214,18 +204,17 @@ static int recv_pack(unsigned char *buf, int len, struct sockaddr_ll *FROM)
                if (src.s_addr && src.s_addr != dst_ip.s_addr)
                        return 0;
        }
-       if (!cfg.quiet) {
+       if (!(cfg&quiet)) {
                int s_printed = 0;
                struct timeval tv;
 
                gettimeofday(&tv, NULL);
 
-               printf("%s ",
-                          FROM->sll_pkttype == PACKET_HOST ? "Unicast" : "Broadcast");
-               printf("%s from ",
-                          ah->ar_op == htons(ARPOP_REPLY) ? "reply" : "request");
-               printf("%s ", inet_ntoa(src_ip));
-               printf("[%s]", ether_ntoa((struct ether_addr *) p));
+               printf("%s %s from %s [%s]",
+                       FROM->sll_pkttype == PACKET_HOST ? "Unicast" : "Broadcast",
+                       ah->ar_op == htons(ARPOP_REPLY) ? "reply" : "request",
+                       inet_ntoa(src_ip),
+                       ether_ntoa((struct ether_addr *) p));
                if (dst_ip.s_addr != src.s_addr) {
                        printf("for %s ", inet_ntoa(dst_ip));
                        s_printed = 1;
@@ -254,73 +243,49 @@ static int recv_pack(unsigned char *buf, int len, struct sockaddr_ll *FROM)
                brd_recv++;
        if (ah->ar_op == htons(ARPOP_REQUEST))
                req_recv++;
-       if (cfg.quit_on_reply)
+       if (cfg&quit_on_reply)
                finish();
-       if (!cfg.broadcast_only) {
+       if (!(cfg&broadcast_only)) {
                memcpy(he.sll_addr, p, me.sll_halen);
-               cfg.unicasting = 1;
+               cfg |= unicasting;
        }
        return 1;
 }
 
 int arping_main(int argc, char **argv)
 {
-       int ch;
        char *device = "eth0";
        int ifindex;
        char *source = NULL;
        char *target;
 
-       s = socket(PF_PACKET, SOCK_DGRAM, 0);
-       ifindex = errno;
-
-       setuid(getuid());
-
-       while ((ch = getopt(argc, argv, "h?bfDUAqc:w:s:I:")) != EOF) {
-               switch (ch) {
-               case 'b':
-                       cfg.broadcast_only = 1;
-                       break;
-               case 'D':
-                       cfg.dad = 1;
-                       cfg.quit_on_reply = 1;
-                       break;
-               case 'U':
-                       cfg.unsolicited = 1;
-                       break;
-               case 'A':
-                       cfg.advert = 1;
-                       cfg.unsolicited = 1;
-                       break;
-               case 'q':
-                       cfg.quiet = 1;
-                       break;
-               case 'c':
-                       count = atoi(optarg);
-                       break;
-               case 'w':
-                       timeout = atoi(optarg);
-                       break;
-               case 'I':
-                       if (optarg == NULL)
-                               bb_show_usage();
-                       if (bb_strlen(optarg) > IF_NAMESIZE) {
-                               bb_error_msg_and_die("Interface name `%s' must be less than %d",
-                                                               optarg, IF_NAMESIZE);
+       s = xsocket(PF_PACKET, SOCK_DGRAM, 0);
+
+       // Drop suid root privileges
+       xsetuid(getuid());
+
+       {
+               unsigned opt;
+               char *_count, *_timeout;
+
+               /* Dad also sets quit_on_reply.
+                * Advert also sets unsolicited.
+                */
+               opt_complementary = "Df:AU";
+               opt = getopt32(argc, argv, "DUAqfbc:w:i:s:",
+                                       &_count, &_timeout, &device, &source);
+               cfg |= opt & 0x3f; /* set respective flags */
+               if (opt & 0x40) /* -c: count */
+                       count = xatou(_count);
+               if (opt & 0x80) /* -w: timeout */
+                       timeout = xatoul_range(_timeout, 0, INT_MAX/2000);
+               if (opt & 0x100) { /* -i: interface */
+                       if (strlen(device) > IF_NAMESIZE) {
+                               bb_error_msg_and_die("interface name '%s' is too long",
+                                                               device);
                        }
-                       device = optarg;
-                       break;
-               case 'f':
-                       cfg.quit_on_reply = 1;
-                       break;
-               case 's':
-                       source = optarg;
-                       break;
-               case 'h':
-               case '?':
-               default:
-                       bb_show_usage();
                }
+               //if (opt & 0x200) /* -s: source */
        }
        argc -= optind;
        argv += optind;
@@ -329,12 +294,8 @@ int arping_main(int argc, char **argv)
                bb_show_usage();
 
        target = *argv;
-       bb_default_error_retval = 2;
 
-       if (s < 0) {
-               bb_perror_msg("socket");
-               exit(ifindex);
-       }
+       xfunc_error_retval = 2;
 
        {
                struct ifreq ifr;
@@ -342,7 +303,7 @@ int arping_main(int argc, char **argv)
                memset(&ifr, 0, sizeof(ifr));
                strncpy(ifr.ifr_name, device, IFNAMSIZ - 1);
                if (ioctl(s, SIOCGIFINDEX, &ifr) < 0) {
-                       bb_error_msg_and_die("Interface %s not found", device);
+                       bb_error_msg_and_die("interface %s not found", device);
                }
                ifindex = ifr.ifr_ifindex;
 
@@ -350,11 +311,11 @@ int arping_main(int argc, char **argv)
                        bb_error_msg_and_die("SIOCGIFFLAGS");
                }
                if (!(ifr.ifr_flags & IFF_UP)) {
-                       bb_error_msg_and_die("Interface %s is down", device);
+                       bb_error_msg_and_die("interface %s is down", device);
                }
                if (ifr.ifr_flags & (IFF_NOARP | IFF_LOOPBACK)) {
-                       bb_error_msg("Interface %s is not ARPable", device);
-                       exit(cfg.dad ? 0 : 2);
+                       bb_error_msg("interface %s is not ARPable", device);
+                       exit(cfg&dad ? 0 : 2);
                }
        }
 
@@ -372,21 +333,18 @@ int arping_main(int argc, char **argv)
                bb_error_msg_and_die("invalid source address %s", source);
        }
 
-       if (!cfg.dad && cfg.unsolicited && src.s_addr == 0)
+       if (!(cfg&dad) && cfg&unsolicited && src.s_addr == 0)
                src = dst;
 
-       if (!cfg.dad || src.s_addr) {
+       if (!(cfg&dad) || src.s_addr) {
                struct sockaddr_in saddr;
-               int probe_fd = socket(AF_INET, SOCK_DGRAM, 0);
+               int probe_fd = xsocket(AF_INET, SOCK_DGRAM, 0);
 
-               if (probe_fd < 0) {
-                       bb_error_msg_and_die("socket");
-               }
                if (device) {
                        if (setsockopt
                                (probe_fd, SOL_SOCKET, SO_BINDTODEVICE, device,
                                 strlen(device) + 1) == -1)
-                               bb_error_msg("WARNING: interface %s is ignored", device);
+                               bb_error_msg("warning: interface %s is ignored", device);
                }
                memset(&saddr, 0, sizeof(saddr));
                saddr.sin_family = AF_INET;
@@ -395,7 +353,7 @@ int arping_main(int argc, char **argv)
                        if (bind(probe_fd, (struct sockaddr *) &saddr, sizeof(saddr)) == -1) {
                                bb_error_msg_and_die("bind");
                        }
-               } else if (!cfg.dad) {
+               } else if (!(cfg&dad)) {
                        int on = 1;
                        socklen_t alen = sizeof(saddr);
 
@@ -405,7 +363,7 @@ int arping_main(int argc, char **argv)
                        if (setsockopt
                                (probe_fd, SOL_SOCKET, SO_DONTROUTE, (char *) &on,
                                 sizeof(on)) == -1)
-                               bb_perror_msg("WARNING: setsockopt(SO_DONTROUTE)");
+                               bb_perror_msg("warning: setsockopt(SO_DONTROUTE)");
                        if (connect(probe_fd, (struct sockaddr *) &saddr, sizeof(saddr))
                                == -1) {
                                bb_error_msg_and_die("connect");
@@ -434,19 +392,19 @@ int arping_main(int argc, char **argv)
                }
        }
        if (me.sll_halen == 0) {
-               bb_error_msg("Interface \"%s\" is not ARPable (no ll address)", device);
-               exit(cfg.dad ? 0 : 2);
+               bb_error_msg("interface \"%s\" is not ARPable (no ll address)", device);
+               exit(cfg&dad ? 0 : 2);
        }
        he = me;
        memset(he.sll_addr, -1, he.sll_halen);
 
-       if (!cfg.quiet) {
-               printf("ARPING to %s", inet_ntoa(dst));
-               printf(" from %s via %s\n", inet_ntoa(src),
-                          device ? device : "unknown");
+       if (!(cfg&quiet)) {
+               printf("ARPING to %s from %s via %s\n",
+                       inet_ntoa(dst), inet_ntoa(src),
+                       device ? device : "unknown");
        }
 
-       if (!src.s_addr && !cfg.dad) {
+       if (!src.s_addr && !(cfg&dad)) {
                bb_error_msg_and_die("no src address in the non-DAD mode");
        }
 
@@ -467,14 +425,14 @@ int arping_main(int argc, char **argv)
 
        while (1) {
                sigset_t sset, osset;
-               unsigned char packet[4096];
+               RESERVE_CONFIG_UBUFFER(packet, 4096);
                struct sockaddr_ll from;
                socklen_t alen = sizeof(from);
                int cc;
 
-               if ((cc = recvfrom(s, packet, sizeof(packet), 0,
+               if ((cc = recvfrom(s, packet, 4096, 0,
                                                   (struct sockaddr *) &from, &alen)) < 0) {
-                       perror("recvfrom");
+                       bb_perror_msg("recvfrom");
                        continue;
                }
                sigemptyset(&sset);
@@ -483,5 +441,6 @@ int arping_main(int argc, char **argv)
                sigprocmask(SIG_BLOCK, &sset, &osset);
                recv_pack(packet, cc, &from);
                sigprocmask(SIG_SETMASK, &osset, NULL);
+               RELEASE_CONFIG_BUFFER(packet);
        }
 }