Merge pull request #1735 from sumpfralle/olsr-jsoninfo-parser-handle-empty-result
[oweals/luci.git] / modules / luci-mod-system / luasrc / controller / admin / system.lua
index 8d9305f4fd7781923834705dea7c8c97ad1a5b49..d6e1dc781590a823862da9926a8b4a52c3ed329d 100644 (file)
@@ -7,28 +7,26 @@ module("luci.controller.admin.system", package.seeall)
 function index()
        local fs = require "nixio.fs"
 
-       entry({"admin", "system", "system"}, cbi("admin_system/system"), _("System"), 1)
-       entry({"admin", "system", "clock_status"}, post_on({ set = true }, "action_clock_status"))
+       entry({"admin", "system", "system"}, view("system/system"), _("System"), 1)
 
-       entry({"admin", "system", "admin"}, cbi("admin_system/admin"), _("Administration"), 2)
+       entry({"admin", "system", "admin"}, firstchild(), _("Administration"), 2)
+       entry({"admin", "system", "admin", "password"}, view("system/password"), _("Router Password"), 1)
 
-       if fs.access("/bin/opkg") then
-               entry({"admin", "system", "packages"}, post_on({ exec = "1" }, "action_packages"), _("Software"), 10)
-               entry({"admin", "system", "packages", "ipkg"}, form("admin_system/ipkg"))
+       if fs.access("/etc/config/dropbear") then
+               entry({"admin", "system", "admin", "dropbear"}, view("system/dropbear"), _("SSH Access"), 2)
+               entry({"admin", "system", "admin", "sshkeys"}, view("system/sshkeys"), _("SSH-Keys"), 3)
        end
 
-       entry({"admin", "system", "startup"}, form("admin_system/startup"), _("Startup"), 45)
-       entry({"admin", "system", "crontab"}, form("admin_system/crontab"), _("Scheduled Tasks"), 46)
+       entry({"admin", "system", "startup"}, view("system/startup"), _("Startup"), 45)
+       entry({"admin", "system", "crontab"}, view("system/crontab"), _("Scheduled Tasks"), 46)
 
        if fs.access("/sbin/block") and fs.access("/etc/config/fstab") then
-               entry({"admin", "system", "fstab"}, cbi("admin_system/fstab"), _("Mount Points"), 50)
-               entry({"admin", "system", "fstab", "mount"}, cbi("admin_system/fstab/mount"), nil).leaf = true
-               entry({"admin", "system", "fstab", "swap"},  cbi("admin_system/fstab/swap"),  nil).leaf = true
+               entry({"admin", "system", "mounts"}, view("system/mounts"), _("Mount Points"), 50)
        end
 
        local nodes, number = fs.glob("/sys/class/leds/*")
        if number > 0 then
-               entry({"admin", "system", "leds"}, cbi("admin_system/leds"), _("<abbr title=\"Light Emitting Diode\">LED</abbr> Configuration"), 60)
+               entry({"admin", "system", "leds"}, view("system/leds"), _("<abbr title=\"Light Emitting Diode\">LED</abbr> Configuration"), 60)
        end
 
        entry({"admin", "system", "flashops"}, call("action_flashops"), _("Backup / Flash Firmware"), 70)
@@ -45,140 +43,6 @@ function index()
        entry({"admin", "system", "reboot", "call"}, post("action_reboot"))
 end
 
-function action_clock_status()
-       local set = tonumber(luci.http.formvalue("set"))
-       if set ~= nil and set > 0 then
-               local date = os.date("*t", set)
-               if date then
-                       luci.sys.call("date -s '%04d-%02d-%02d %02d:%02d:%02d'" %{
-                               date.year, date.month, date.day, date.hour, date.min, date.sec
-                       })
-                       luci.sys.call("/etc/init.d/sysfixtime restart")
-               end
-       end
-
-       luci.http.prepare_content("application/json")
-       luci.http.write_json({ timestring = os.date("%c") })
-end
-
-function action_packages()
-       local fs = require "nixio.fs"
-       local ipkg = require "luci.model.ipkg"
-       local submit = (luci.http.formvalue("exec") == "1")
-       local update, upgrade
-       local changes = false
-       local install = { }
-       local remove  = { }
-       local stdout  = { "" }
-       local stderr  = { "" }
-       local out, err
-
-       -- Display
-       local display = luci.http.formvalue("display") or "available"
-
-       -- Letter
-       local letter = string.byte(luci.http.formvalue("letter") or "A", 1)
-       letter = (letter == 35 or (letter >= 65 and letter <= 90)) and letter or 65
-
-       -- Search query
-       local query = luci.http.formvalue("query")
-       query = (query ~= '') and query or nil
-
-
-       -- Modifying actions
-       if submit then
-               -- Packets to be installed
-               local ninst = luci.http.formvalue("install")
-               local uinst = nil
-
-               -- Install from URL
-               local url = luci.http.formvalue("url")
-               if url and url ~= '' then
-                       uinst = url
-               end
-
-               -- Do install
-               if ninst then
-                       install[ninst], out, err = ipkg.install(ninst)
-                       stdout[#stdout+1] = out
-                       stderr[#stderr+1] = err
-                       changes = true
-               end
-
-               if uinst then
-                       local pkg
-                       for pkg in luci.util.imatch(uinst) do
-                               install[uinst], out, err = ipkg.install(pkg)
-                               stdout[#stdout+1] = out
-                               stderr[#stderr+1] = err
-                               changes = true
-                       end
-               end
-
-               -- Remove packets
-               local rem = luci.http.formvalue("remove")
-               if rem then
-                       remove[rem], out, err = ipkg.remove(rem)
-                       stdout[#stdout+1] = out
-                       stderr[#stderr+1] = err
-                       changes = true
-               end
-
-
-               -- Update all packets
-               update = luci.http.formvalue("update")
-               if update then
-                       update, out, err = ipkg.update()
-                       stdout[#stdout+1] = out
-                       stderr[#stderr+1] = err
-               end
-
-
-               -- Upgrade all packets
-               upgrade = luci.http.formvalue("upgrade")
-               if upgrade then
-                       upgrade, out, err = ipkg.upgrade()
-                       stdout[#stdout+1] = out
-                       stderr[#stderr+1] = err
-               end
-       end
-
-
-       -- List state
-       local no_lists = true
-       local old_lists = false
-       if fs.access("/var/opkg-lists/") then
-               local list
-               for list in fs.dir("/var/opkg-lists/") do
-                       no_lists = false
-                       if (fs.stat("/var/opkg-lists/"..list, "mtime") or 0) < (os.time() - (24 * 60 * 60)) then
-                               old_lists = true
-                               break
-                       end
-               end
-       end
-
-
-       luci.template.render("admin_system/packages", {
-               display   = display,
-               letter    = letter,
-               query     = query,
-               install   = install,
-               remove    = remove,
-               update    = update,
-               upgrade   = upgrade,
-               no_lists  = no_lists,
-               old_lists = old_lists,
-               stdout    = table.concat(stdout, ""),
-               stderr    = table.concat(stderr, "")
-       })
-
-       -- Remove index cache
-       if changes then
-               fs.unlink("/tmp/luci-indexcache")
-       end
-end
-
 local function image_supported(image)
        return (os.execute("sysupgrade -T %q >/dev/null" % image) == 0)
 end
@@ -301,21 +165,16 @@ function action_sysupgrade()
                        msg   = luci.i18n.translate("The system is flashing now.<br /> DO NOT POWER OFF THE DEVICE!<br /> Wait a few minutes before you try to reconnect. It might be necessary to renew the address of your computer to reach the device again, depending on your settings."),
                        addr  = (#keep > 0) and (#force > 0) and "192.168.1.1" or nil
                })
-               fork_exec("sleep 1; killall dropbear uhttpd; sleep 1; /sbin/sysupgrade %s %s %q" %{ keep, force, image_tmp })
+               luci.sys.process.exec({ "/bin/sh", "-c","sleep 1; killall dropbear uhttpd; sleep 1; /sbin/sysupgrade %s %s %q" %{ keep, force, image_tmp } }, nil, nil, true)
        end
 end
 
 function action_backup()
-       local reader = ltn12_popen("sysupgrade --create-backup - 2>/dev/null")
-
-       luci.http.header(
-               'Content-Disposition', 'attachment; filename="backup-%s-%s.tar.gz"' %{
-                       luci.sys.hostname(),
-                       os.date("%Y-%m-%d")
-               })
+       luci.http.header('Content-Disposition', 'attachment; filename="backup-%s-%s.tar.gz"'
+               %{ luci.sys.hostname(), os.date("%Y-%m-%d") })
 
        luci.http.prepare_content("application/x-targz")
-       luci.ltn12.pump.all(reader, luci.http.write)
+       luci.sys.process.exec({ "/sbin/sysupgrade", "--create-backup", "-" }, luci.http.write)
 end
 
 function action_backupmtdblock()
@@ -327,16 +186,11 @@ function action_backupmtdblock()
                return
        end
 
-       local reader = ltn12_popen("dd if=/dev/mtd%s conv=fsync,notrunc 2>/dev/null" % n)
-
-       luci.http.header(
-               'Content-Disposition', 'attachment; filename="backup-%s-%s-%s.bin"' %{
-                       luci.sys.hostname(), m,
-                       os.date("%Y-%m-%d")
-               })
+       luci.http.header('Content-Disposition', 'attachment; filename="backup-%s-%s-%s.bin"'
+               %{ luci.sys.hostname(), m, os.date("%Y-%m-%d") })
 
        luci.http.prepare_content("application/octet-stream")
-       luci.ltn12.pump.all(reader, luci.http.write)
+       luci.sys.process.exec({ "/bin/dd", "if=/dev/mtd%s" % n, "conv=fsync,notrunc" }, luci.http.write)
 end
 
 function action_restore()
@@ -391,83 +245,13 @@ function action_reset()
                        addr  = "192.168.1.1"
                })
 
-               fork_exec("sleep 1; killall dropbear uhttpd; sleep 1; jffs2reset -y && reboot")
+               luci.sys.process.exec({ "/bin/sh", "-c", "sleep 1; killall dropbear uhttpd; sleep 1; jffs2reset -y && reboot" }, nil, nil, true)
                return
        end
 
        http.redirect(luci.dispatcher.build_url('admin/system/flashops'))
 end
 
-function action_passwd()
-       local p1 = luci.http.formvalue("pwd1")
-       local p2 = luci.http.formvalue("pwd2")
-       local stat = nil
-
-       if p1 or p2 then
-               if p1 == p2 then
-                       stat = luci.sys.user.setpasswd("root", p1)
-               else
-                       stat = 10
-               end
-       end
-
-       luci.template.render("admin_system/passwd", {stat=stat})
-end
-
 function action_reboot()
        luci.sys.reboot()
 end
-
-function fork_exec(command)
-       local pid = nixio.fork()
-       if pid > 0 then
-               return
-       elseif pid == 0 then
-               -- change to root dir
-               nixio.chdir("/")
-
-               -- patch stdin, out, err to /dev/null
-               local null = nixio.open("/dev/null", "w+")
-               if null then
-                       nixio.dup(null, nixio.stderr)
-                       nixio.dup(null, nixio.stdout)
-                       nixio.dup(null, nixio.stdin)
-                       if null:fileno() > 2 then
-                               null:close()
-                       end
-               end
-
-               -- replace with target command
-               nixio.exec("/bin/sh", "-c", command)
-       end
-end
-
-function ltn12_popen(command)
-
-       local fdi, fdo = nixio.pipe()
-       local pid = nixio.fork()
-
-       if pid > 0 then
-               fdo:close()
-               local close
-               return function()
-                       local buffer = fdi:read(2048)
-                       local wpid, stat = nixio.waitpid(pid, "nohang")
-                       if not close and wpid and stat == "exited" then
-                               close = true
-                       end
-
-                       if buffer and #buffer > 0 then
-                               return buffer
-                       elseif close then
-                               fdi:close()
-                               return nil
-                       end
-               end
-       elseif pid == 0 then
-               nixio.dup(fdo, nixio.stdout)
-               fdi:close()
-               fdo:close()
-               nixio.exec("/bin/sh", "-c", command)
-       end
-end