Closing bug 730. libbb run_parts is using scandir (a GNUism),
[oweals/busybox.git] / miscutils / makedevs.c
index 57b2d6c7066038a342cdba8c5f574821d3acd8dc..3bc1559c78b511ff6704281a0fc4fcbbabe7cad8 100644 (file)
@@ -1,19 +1,4 @@
 /* vi: set sw=4 ts=4: */
-
-#include <sys/types.h>
-
-#include <fcntl.h>
-#include <getopt.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <time.h>
-#include <unistd.h>
-
-#include "busybox.h"
-
-#ifdef CONFIG_FEATURE_MAKEDEVS_LEAF
-
 /*
  * public domain -- Dave 'Kill a Cop' Cinege <dcinege@psychosis.com>
  *
  * Make ranges of device files quickly.
  * known bugs: can't deal with alpha ranges
  */
+
+#include "busybox.h"
+
+#ifdef CONFIG_FEATURE_MAKEDEVS_LEAF
 int makedevs_main(int argc, char **argv)
 {
        mode_t mode;
        char *basedev, *type, *nodname, buf[255];
-       int major, Sminor, S, E;
+       int Smajor, Sminor, S, E;
 
        if (argc < 7 || *argv[1]=='-')
                bb_show_usage();
 
        basedev = argv[1];
        type = argv[2];
-       major = atoi(argv[3]) << 8;  /* correcting param to mknod() */
-       Sminor = atoi(argv[4]);
-       S = atoi(argv[5]);
-       E = atoi(argv[6]);
+       Smajor = xatoi_u(argv[3]);
+       Sminor = xatoi_u(argv[4]);
+       S = xatoi_u(argv[5]);
+       E = xatoi_u(argv[6]);
        nodname = argc == 8 ? basedev : buf;
 
        mode = 0660;
@@ -64,8 +52,8 @@ int makedevs_main(int argc, char **argv)
 
        /* if mode != S_IFCHR and != S_IFBLK third param in mknod() ignored */
 
-               if (mknod(nodname, mode, major | Sminor))
-                       bb_error_msg("Failed to create: %s", nodname);
+               if (mknod(nodname, mode, makedev(Smajor, Sminor)))
+                       bb_error_msg("failed to create: %s", nodname);
 
                if (nodname == basedev) /* ex. /dev/hda - to /dev/hda1 ... */
                        nodname = buf;
@@ -78,52 +66,36 @@ int makedevs_main(int argc, char **argv)
 
 #elif defined CONFIG_FEATURE_MAKEDEVS_TABLE
 
-/*
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License version 2 as
- *  published by the Free Software Foundation.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU Library General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
- *
- */
-
-static const struct option makedevs_long_options[] = {
-       {"root", 1, NULL, 'r'},
-       {0, 0, 0, 0}
-};
+/* Licensed under the GPL v2 or later, see the file LICENSE in this tarball. */
 
-extern int makedevs_main(int argc, char **argv)
+int makedevs_main(int argc, char **argv)
 {
-       FILE *table;
-       int opt;
-       char *rootdir = "./";
-       char *line;
+       FILE *table = stdin;
+       char *rootdir = NULL;
+       char *line = NULL;
+       int linenum = 0;
        int ret = EXIT_SUCCESS;
 
-       bb_opt_complementaly = "d~r";
-       bb_applet_long_options = makedevs_long_options;
-       opt = bb_getopt_ulflags(argc, argv, "d:r:", &rootdir, &rootdir);
+       getopt32(argc, argv, "d:", &line);
+       if (line)
+               table = xfopen(line, "r");
 
-       if (optind + 1 == argc) {
-               table = bb_xfopen(argv[optind], "r");
-       } else {
-               table = stdin;
+       if (optind >= argc || (rootdir=argv[optind])==NULL) {
+               bb_error_msg_and_die("root directory not specified");
        }
 
-       if (chdir(rootdir) == -1) {
-               bb_perror_msg_and_die("Couldnt chdor to %s", rootdir);
-       }
+       xchdir(rootdir);
 
        umask(0);
 
-       while ((line = bb_get_chomped_line_from_file(table))) {
+       printf("rootdir=%s\n", rootdir);
+       if (line) {
+               printf("table='%s'\n", line);
+       } else {
+               printf("table=<stdin>\n");
+       }
+
+       while ((line = xmalloc_getline(table))) {
                char type;
                unsigned int mode = 0755;
                unsigned int major = 0;
@@ -138,37 +110,58 @@ extern int makedevs_main(int argc, char **argv)
                uid_t uid;
                gid_t gid;
 
+               linenum++;
+
                if ((2 > sscanf(line, "%40s %c %o %40s %40s %u %u %u %u %u", name,
-                       &type, &mode, user, group, &major,
-                       &minor, &start, &increment, &count)) ||
-                       ((major | minor | start | count | increment) > 255)) {
-                       bb_error_msg("Ignoring invalid line\n%s\n", line);
+                                               &type, &mode, user, group, &major,
+                                               &minor, &start, &increment, &count)) ||
+                               ((major | minor | start | count | increment) > 255))
+               {
+                       if (*line=='\0' || *line=='#' || isspace(*line))
+                               continue;
+                       bb_error_msg("line %d invalid: '%s'", linenum, line);
                        ret = EXIT_FAILURE;
                        continue;
                }
                if (name[0] == '#') {
                        continue;
                }
-               if (group) {
-                       gid = get_ug_id(group, my_getgrnam);
-               } else {
-                       gid = getgid();
-               }
-               if (user) {
-                       uid = get_ug_id(user, my_getpwnam);
-               } else {
-                       uid = getuid();
-               }
+
+               gid = (*group) ? get_ug_id(group, bb_xgetgrnam) : getgid();
+               uid = (*user) ? get_ug_id(user, bb_xgetpwnam) : getuid();
                full_name = concat_path_file(rootdir, name);
 
                if (type == 'd') {
-                       bb_make_directory(full_name, mode | S_IFDIR, 0);
+                       bb_make_directory(full_name, mode | S_IFDIR, FILEUTILS_RECUR);
                        if (chown(full_name, uid, gid) == -1) {
-                               bb_perror_msg("chown failed for %s", full_name);
+                               bb_perror_msg("line %d: chown failed for %s", linenum, full_name);
+                               ret = EXIT_FAILURE;
+                               goto loop;
+                       }
+                       if ((mode != -1) && (chmod(full_name, mode) < 0)){
+                               bb_perror_msg("line %d: chmod failed for %s", linenum, full_name);
+                               ret = EXIT_FAILURE;
+                               goto loop;
+                       }
+               } else if (type == 'f') {
+                       struct stat st;
+                       if ((stat(full_name, &st) < 0 || !S_ISREG(st.st_mode))) {
+                               bb_perror_msg("line %d: regular file '%s' does not exist", linenum, full_name);
                                ret = EXIT_FAILURE;
                                goto loop;
                        }
-               } else {
+                       if (chown(full_name, uid, gid) == -1) {
+                               bb_perror_msg("line %d: chown failed for %s", linenum, full_name);
+                               ret = EXIT_FAILURE;
+                               goto loop;
+                       }
+                       if ((mode != -1) && (chmod(full_name, mode) < 0)){
+                               bb_perror_msg("line %d: chmod failed for %s", linenum, full_name);
+                               ret = EXIT_FAILURE;
+                               goto loop;
+                       }
+               } else
+               {
                        dev_t rdev;
 
                        if (type == 'p') {
@@ -180,7 +173,7 @@ extern int makedevs_main(int argc, char **argv)
                        else if (type == 'b') {
                                mode |= S_IFBLK;
                        } else {
-                               bb_error_msg("Unsupported file type %c", type);
+                               bb_error_msg("line %d: unsupported file type %c", linenum, type);
                                ret = EXIT_FAILURE;
                                goto loop;
                        }
@@ -194,11 +187,15 @@ extern int makedevs_main(int argc, char **argv)
                                        sprintf(full_name_inc, "%s%d", full_name, i);
                                        rdev = (major << 8) + minor + (i * increment - start);
                                        if (mknod(full_name_inc, mode, rdev) == -1) {
-                                               bb_perror_msg("Couldnt create node %s", full_name_inc);
+                                               bb_perror_msg("line %d: cannot create node %s", linenum, full_name_inc);
                                                ret = EXIT_FAILURE;
                                        }
                                        else if (chown(full_name_inc, uid, gid) == -1) {
-                                               bb_perror_msg("chown failed for %s", full_name_inc);
+                                               bb_perror_msg("line %d: chown failed for %s", linenum, full_name_inc);
+                                               ret = EXIT_FAILURE;
+                                       }
+                                       if ((mode != -1) && (chmod(full_name_inc, mode) < 0)){
+                                               bb_perror_msg("line %d: chmod failed for %s", linenum, full_name_inc);
                                                ret = EXIT_FAILURE;
                                        }
                                }
@@ -206,11 +203,15 @@ extern int makedevs_main(int argc, char **argv)
                        } else {
                                rdev = (major << 8) + minor;
                                if (mknod(full_name, mode, rdev) == -1) {
-                                       bb_perror_msg("Couldnt create node %s", full_name);
+                                       bb_perror_msg("line %d: cannot create node %s", linenum, full_name);
                                        ret = EXIT_FAILURE;
                                }
                                else if (chown(full_name, uid, gid) == -1) {
-                                       bb_perror_msg("chown failed for %s", full_name);
+                                       bb_perror_msg("line %d: chown failed for %s", linenum, full_name);
+                                       ret = EXIT_FAILURE;
+                               }
+                               if ((mode != -1) && (chmod(full_name, mode) < 0)){
+                                       bb_perror_msg("line %d: chmod failed for %s", linenum, full_name);
                                        ret = EXIT_FAILURE;
                                }
                        }
@@ -221,8 +222,9 @@ loop:
        }
        fclose(table);
 
-       return 0;
+       return ret;
 }
+
 #else
-# error makdedevs configuration error, either leaf or table must be selected
+# error makedevs configuration error, either leaf or table must be selected
 #endif