delay reconfig of input tty until target device has been both opened
[oweals/busybox.git] / miscutils / hdparm.c
index 5c7d1f60cf591d4607f203f77e6b6bdb14589eaa..ec5ede691c4f7d3b89c80c790f8694220ddc5517 100644 (file)
 
 #define CDROM 0x0005
 
-#if ENABLE_FEATURE_HDPARM_GET_IDENTITY
-static const char * const pkt_str[] = {
-       "Direct-access device",                 /* word 0, bits 12-8 = 00 */
-       "Sequential-access device",             /* word 0, bits 12-8 = 01 */
-       "Printer",                              /* word 0, bits 12-8 = 02 */
-       "Processor",                            /* word 0, bits 12-8 = 03 */
-       "Write-once device",                    /* word 0, bits 12-8 = 04 */
-       "CD-ROM",                               /* word 0, bits 12-8 = 05 */
-       "Scanner",                              /* word 0, bits 12-8 = 06 */
-       "Optical memory",                       /* word 0, bits 12-8 = 07 */
-       "Medium changer",                       /* word 0, bits 12-8 = 08 */
-       "Communications device",                /* word 0, bits 12-8 = 09 */
-       "ACS-IT8 device",                       /* word 0, bits 12-8 = 0a */
-       "ACS-IT8 device",                       /* word 0, bits 12-8 = 0b */
-       "Array controller",                     /* word 0, bits 12-8 = 0c */
-       "Enclosure services",                   /* word 0, bits 12-8 = 0d */
-       "Reduced block command device",         /* word 0, bits 12-8 = 0e */
-       "Optical card reader/writer",           /* word 0, bits 12-8 = 0f */
-       "",                                     /* word 0, bits 12-8 = 10 */
-       "",                                     /* word 0, bits 12-8 = 11 */
-       "",                                     /* word 0, bits 12-8 = 12 */
-       "",                                     /* word 0, bits 12-8 = 13 */
-       "",                                     /* word 0, bits 12-8 = 14 */
-       "",                                     /* word 0, bits 12-8 = 15 */
-       "",                                     /* word 0, bits 12-8 = 16 */
-       "",                                     /* word 0, bits 12-8 = 17 */
-       "",                                     /* word 0, bits 12-8 = 18 */
-       "",                                     /* word 0, bits 12-8 = 19 */
-       "",                                     /* word 0, bits 12-8 = 1a */
-       "",                                     /* word 0, bits 12-8 = 1b */
-       "",                                     /* word 0, bits 12-8 = 1c */
-       "",                                     /* word 0, bits 12-8 = 1d */
-       "",                                     /* word 0, bits 12-8 = 1e */
-       "Unknown",                      /* word 0, bits 12-8 = 1f */
-};
-
-static const char * const ata1_cfg_str[] = {                   /* word 0 in ATA-1 mode */
-       "Reserved",                             /* bit 0 */
-       "hard sectored",                        /* bit 1 */
-       "soft sectored",                        /* bit 2 */
-       "not MFM encoded ",                     /* bit 3 */
-       "head switch time > 15us",              /* bit 4 */
-       "spindle motor control option",         /* bit 5 */
-       "fixed drive",                          /* bit 6 */
-       "removable drive",                      /* bit 7 */
-       "disk xfer rate <= 5Mbs",               /* bit 8 */
-       "disk xfer rate > 5Mbs, <= 10Mbs",      /* bit 9 */
-       "disk xfer rate > 5Mbs",                /* bit 10 */
-       "rotational speed tol.",                /* bit 11 */
-       "data strobe offset option",            /* bit 12 */
-       "track offset option",                  /* bit 13 */
-       "format speed tolerance gap reqd",      /* bit 14 */
-       "ATAPI"                                 /* bit 14 */
-};
-#endif
-
 /* word 1: number of logical cylinders */
 #define LCYLS_MAX              0x3fff /* maximum allowable value */
 
@@ -238,86 +182,6 @@ static const char * const ata1_cfg_str[] = {                       /* word 0 in ATA-1 mode */
 
 /* word 81: minor version number */
 #define MINOR_MAX              0x22
-#if ENABLE_FEATURE_HDPARM_GET_IDENTITY
-static const char *minor_str[MINOR_MAX+2] = {                  /* word 81 value: */
-       "Unspecified",                                  /* 0x0000       */
-       "ATA-1 X3T9.2 781D prior to rev.4",     /* 0x0001       */
-       "ATA-1 published, ANSI X3.221-1994",            /* 0x0002       */
-       "ATA-1 X3T9.2 781D rev.4",                      /* 0x0003       */
-       "ATA-2 published, ANSI X3.279-1996",            /* 0x0004       */
-       "ATA-2 X3T10 948D prior to rev.2k",     /* 0x0005       */
-       "ATA-3 X3T10 2008D rev.1",                      /* 0x0006       */
-       "ATA-2 X3T10 948D rev.2k",                      /* 0x0007       */
-       "ATA-3 X3T10 2008D rev.0",                      /* 0x0008       */
-       "ATA-2 X3T10 948D rev.3",                       /* 0x0009       */
-       "ATA-3 published, ANSI X3.298-199x",            /* 0x000a       */
-       "ATA-3 X3T10 2008D rev.6",                      /* 0x000b       */
-       "ATA-3 X3T13 2008D rev.7 and 7a",               /* 0x000c       */
-       "ATA/ATAPI-4 X3T13 1153D rev.6",                /* 0x000d       */
-       "ATA/ATAPI-4 T13 1153D rev.13",         /* 0x000e       */
-       "ATA/ATAPI-4 X3T13 1153D rev.7",                /* 0x000f       */
-       "ATA/ATAPI-4 T13 1153D rev.18",         /* 0x0010       */
-       "ATA/ATAPI-4 T13 1153D rev.15",         /* 0x0011       */
-       "ATA/ATAPI-4 published, ANSI INCITS 317-1998",  /* 0x0012       */
-       "ATA/ATAPI-5 T13 1321D rev.3",
-       "ATA/ATAPI-4 T13 1153D rev.14",         /* 0x0014       */
-       "ATA/ATAPI-5 T13 1321D rev.1",          /* 0x0015       */
-       "ATA/ATAPI-5 published, ANSI INCITS 340-2000",  /* 0x0016       */
-       "ATA/ATAPI-4 T13 1153D rev.17",         /* 0x0017       */
-       "ATA/ATAPI-6 T13 1410D rev.0",          /* 0x0018       */
-       "ATA/ATAPI-6 T13 1410D rev.3a",         /* 0x0019       */
-       "ATA/ATAPI-7 T13 1532D rev.1",          /* 0x001a       */
-       "ATA/ATAPI-6 T13 1410D rev.2",          /* 0x001b       */
-       "ATA/ATAPI-6 T13 1410D rev.1",          /* 0x001c       */
-       "ATA/ATAPI-7 published, ANSI INCITS 397-2005",  /* 0x001d       */
-       "ATA/ATAPI-7 T13 1532D rev.0",          /* 0x001e       */
-       "Reserved"                                      /* 0x001f       */
-       "Reserved"                                      /* 0x0020       */
-       "ATA/ATAPI-7 T13 1532D rev.4a",         /* 0x0021       */
-       "ATA/ATAPI-6 published, ANSI INCITS 361-2002",  /* 0x0022       */
-       "Reserved"                                      /* 0x0023-0xfffe*/
-};
-#endif
-static const char actual_ver[MINOR_MAX+2] = {
-                       /* word 81 value: */
-       0,              /* 0x0000       WARNING:        */
-       1,              /* 0x0001       WARNING:        */
-       1,              /* 0x0002       WARNING:        */
-       1,              /* 0x0003       WARNING:        */
-       2,              /* 0x0004       WARNING:   This array           */
-       2,              /* 0x0005       WARNING:   corresponds          */
-       3,              /* 0x0006       WARNING:   *exactly*            */
-       2,              /* 0x0007       WARNING:   to the ATA/          */
-       3,              /* 0x0008       WARNING:   ATAPI version        */
-       2,              /* 0x0009       WARNING:   listed in            */
-       3,              /* 0x000a       WARNING:   the                  */
-       3,              /* 0x000b       WARNING:   minor_str            */
-       3,              /* 0x000c       WARNING:   array                */
-       4,              /* 0x000d       WARNING:   above.               */
-       4,              /* 0x000e       WARNING:                        */
-       4,              /* 0x000f       WARNING:   if you change        */
-       4,              /* 0x0010       WARNING:   that one,            */
-       4,              /* 0x0011       WARNING:   change this one      */
-       4,              /* 0x0012       WARNING:   too!!!               */
-       5,              /* 0x0013       WARNING:        */
-       4,              /* 0x0014       WARNING:        */
-       5,              /* 0x0015       WARNING:        */
-       5,              /* 0x0016       WARNING:        */
-       4,              /* 0x0017       WARNING:        */
-       6,              /* 0x0018       WARNING:        */
-       6,              /* 0x0019       WARNING:        */
-       7,              /* 0x001a       WARNING:        */
-       6,              /* 0x001b       WARNING:        */
-       6,              /* 0x001c       WARNING:        */
-       7,              /* 0x001d       WARNING:        */
-       7,              /* 0x001e       WARNING:        */
-       0,              /* 0x001f       WARNING:        */
-       0,              /* 0x0020       WARNING:        */
-       7,              /* 0x0021       WARNING:        */
-       6,              /* 0x0022       WARNING:        */
-       0               /* 0x0023-0xfffe        */
-};
-
 /* words 82-84: cmds/feats supported */
 #define CMDS_W82               0x77ff  /* word 82: defined command locations*/
 #define CMDS_W83               0x3fff  /* word 83: defined command locations*/
@@ -325,67 +189,6 @@ static const char actual_ver[MINOR_MAX+2] = {
 #define SUPPORT_48_BIT         0x0400
 #define NUM_CMD_FEAT_STR       48
 
-#if ENABLE_FEATURE_HDPARM_GET_IDENTITY
-static const char * const cmd_feat_str[] = {
-       "",                                     /* word 82 bit 15: obsolete  */
-       "NOP cmd",                              /* word 82 bit 14 */
-       "READ BUFFER cmd",                      /* word 82 bit 13 */
-       "WRITE BUFFER cmd",                     /* word 82 bit 12 */
-       "",                                     /* word 82 bit 11: obsolete  */
-       "Host Protected Area feature set",      /* word 82 bit 10 */
-       "DEVICE RESET cmd",                     /* word 82 bit  9 */
-       "SERVICE interrupt",                    /* word 82 bit  8 */
-       "Release interrupt",                    /* word 82 bit  7 */
-       "Look-ahead",                           /* word 82 bit  6 */
-       "Write cache",                          /* word 82 bit  5 */
-       "PACKET command feature set",           /* word 82 bit  4 */
-       "Power Management feature set",         /* word 82 bit  3 */
-       "Removable Media feature set",          /* word 82 bit  2 */
-       "Security Mode feature set",            /* word 82 bit  1 */
-       "SMART feature set",                    /* word 82 bit  0 */
-                                               /* --------------*/
-       "",                                     /* word 83 bit 15: !valid bit */
-       "",                                     /* word 83 bit 14:  valid bit */
-       "FLUSH CACHE EXT cmd",          /* word 83 bit 13 */
-       "Mandatory FLUSH CACHE cmd ",   /* word 83 bit 12 */
-       "Device Configuration Overlay feature set ",
-       "48-bit Address feature set ",          /* word 83 bit 10 */
-       "",
-       "SET MAX security extension",           /* word 83 bit  8 */
-       "Address Offset Reserved Area Boot",    /* word 83 bit  7 */
-       "SET FEATURES subcommand required to spinup after power up",
-       "Power-Up In Standby feature set",      /* word 83 bit  5 */
-       "Removable Media Status Notification feature set",
-       "Adv. Power Management feature set",/* word 83 bit  3 */
-       "CFA feature set",                      /* word 83 bit  2 */
-       "READ/WRITE DMA QUEUED",                /* word 83 bit  1 */
-       "DOWNLOAD MICROCODE cmd",               /* word 83 bit  0 */
-                                               /* --------------*/
-       "",                                     /* word 84 bit 15: !valid bit */
-       "",                                     /* word 84 bit 14:  valid bit */
-       "",                                     /* word 84 bit 13:  reserved */
-       "",                                     /* word 84 bit 12:  reserved */
-       "",                                     /* word 84 bit 11:  reserved */
-       "",                                     /* word 84 bit 10:  reserved */
-       "",                                     /* word 84 bit  9:  reserved */
-       "",                                     /* word 84 bit  8:  reserved */
-       "",                                     /* word 84 bit  7:  reserved */
-       "",                                     /* word 84 bit  6:  reserved */
-       "General Purpose Logging feature set",  /* word 84 bit  5 */
-       "",                                     /* word 84 bit  4:  reserved */
-       "Media Card Pass Through Command feature set ",
-       "Media serial number ",                 /* word 84 bit  2 */
-       "SMART self-test ",                     /* word 84 bit  1 */
-       "SMART error logging "                  /* word 84 bit  0 */
-};
-
-static void identify(uint16_t *id_supplied) ATTRIBUTE_NORETURN;
-static void identify_from_stdin(void) ATTRIBUTE_NORETURN;
-#else
-void identify_from_stdin(void);
-#endif
-
-
 /* words 85-87: cmds/feats enabled */
 /* use cmd_feat_str[] to display what commands and features have
  * been enabled with words 85-87
@@ -412,16 +215,6 @@ void identify_from_stdin(void);
 #define SECU_ENABLED    0x0002
 #define SECU_LEVEL      0x0010
 #define NUM_SECU_STR    6
-#if ENABLE_FEATURE_HDPARM_GET_IDENTITY
-static const char * const secu_str[] = {
-       "supported",                    /* word 128, bit 0 */
-       "enabled",                      /* word 128, bit 1 */
-       "locked",                       /* word 128, bit 2 */
-       "frozen",                       /* word 128, bit 3 */
-       "expired: security count",      /* word 128, bit 4 */
-       "supported: enhanced erase"     /* word 128, bit 5 */
-};
-#endif
 
 /* word 160: CFA power mode */
 #define VALID_W160              0x8000  /* 1=word valid */
@@ -433,32 +226,199 @@ static const char * const secu_str[] = {
 #define SIG                     0x00ff  /* signature location */
 #define SIG_VAL                 0x00a5  /* signature value */
 
-#define TIMING_MB               64
 #define TIMING_BUF_MB           1
 #define TIMING_BUF_BYTES        (TIMING_BUF_MB * 1024 * 1024)
-#define BUFCACHE_FACTOR         2
 
 #undef DO_FLUSHCACHE            /* under construction: force cache flush on -W0 */
 
+
+enum { fd = 3 };
+
+
+struct globals {
+       smallint get_identity, get_geom;
+       smallint do_flush;
+       smallint do_ctimings, do_timings;
+       smallint reread_partn;
+       smallint set_piomode, noisy_piomode;
+       smallint set_readahead, get_readahead;
+       smallint set_readonly, get_readonly;
+       smallint set_unmask, get_unmask;
+       smallint set_mult, get_mult;
+#ifdef HDIO_GET_QDMA
+       smallint get_dma_q;
+#ifdef HDIO_SET_QDMA
+       smallint set_dma_q;
+#endif
+#endif
+       smallint set_nowerr, get_nowerr;
+       smallint set_keep, get_keep;
+       smallint set_io32bit, get_io32bit;
+       int piomode;
+       unsigned long Xreadahead;
+       unsigned long readonly;
+       unsigned long unmask;
+       unsigned long mult;
+#ifdef HDIO_SET_QDMA
+       unsigned long dma_q;
+#endif
+       unsigned long nowerr;
+       unsigned long keep;
+       unsigned long io32bit;
+#if ENABLE_FEATURE_HDPARM_HDIO_GETSET_DMA
+       unsigned long dma;
+       smallint set_dma, get_dma;
+#endif
+#ifdef HDIO_DRIVE_CMD
+       smallint set_xfermode, get_xfermode;
+       smallint set_dkeep, get_dkeep;
+       smallint set_standby, get_standby;
+       smallint set_lookahead, get_lookahead;
+       smallint set_prefetch, get_prefetch;
+       smallint set_defects, get_defects;
+       smallint set_wcache, get_wcache;
+       smallint set_doorlock, get_doorlock;
+       smallint set_seagate, get_seagate;
+       smallint set_standbynow, get_standbynow;
+       smallint set_sleepnow, get_sleepnow;
+       smallint get_powermode;
+       smallint set_apmmode, get_apmmode;
+       int xfermode_requested;
+       unsigned long dkeep;
+       unsigned long standby_requested; /* 0..255 */
+       unsigned long lookahead;
+       unsigned long prefetch;
+       unsigned long defects;
+       unsigned long wcache;
+       unsigned long doorlock;
+       unsigned long apmmode;
+#endif
+       USE_FEATURE_HDPARM_GET_IDENTITY(        smallint get_IDentity;)
+       USE_FEATURE_HDPARM_HDIO_TRISTATE_HWIF(  smallint set_busstate, get_busstate;)
+       USE_FEATURE_HDPARM_HDIO_DRIVE_RESET(    smallint perform_reset;)
+       USE_FEATURE_HDPARM_HDIO_TRISTATE_HWIF(  smallint perform_tristate;)
+       USE_FEATURE_HDPARM_HDIO_UNREGISTER_HWIF(smallint unregister_hwif;)
+       USE_FEATURE_HDPARM_HDIO_SCAN_HWIF(      smallint scan_hwif;)
+       USE_FEATURE_HDPARM_HDIO_TRISTATE_HWIF(  unsigned long busstate;)
+       USE_FEATURE_HDPARM_HDIO_TRISTATE_HWIF(  unsigned long tristate;)
+       USE_FEATURE_HDPARM_HDIO_UNREGISTER_HWIF(unsigned long hwif;)
+#if ENABLE_FEATURE_HDPARM_HDIO_SCAN_HWIF
+       unsigned long hwif_data;
+       unsigned long hwif_ctrl;
+       unsigned long hwif_irq;
+#endif
+#ifdef DO_FLUSHCACHE
+       unsigned char flushcache[4] = { WIN_FLUSHCACHE, 0, 0, 0 };
+#endif
+};
+#define G (*(struct globals*)&bb_common_bufsiz1)
+struct BUG_G_too_big {
+       char BUG_G_too_big[sizeof(G) <= COMMON_BUFSIZE ? 1 : -1];
+};
+#define get_identity       (G.get_identity           )
+#define get_geom           (G.get_geom               )
+#define do_flush           (G.do_flush               )
+#define do_ctimings        (G.do_ctimings            )
+#define do_timings         (G.do_timings             )
+#define reread_partn       (G.reread_partn           )
+#define set_piomode        (G.set_piomode            )
+#define noisy_piomode      (G.noisy_piomode          )
+#define set_readahead      (G.set_readahead          )
+#define get_readahead      (G.get_readahead          )
+#define set_readonly       (G.set_readonly           )
+#define get_readonly       (G.get_readonly           )
+#define set_unmask         (G.set_unmask             )
+#define get_unmask         (G.get_unmask             )
+#define set_mult           (G.set_mult               )
+#define get_mult           (G.get_mult               )
+#define set_dma_q          (G.set_dma_q              )
+#define get_dma_q          (G.get_dma_q              )
+#define set_nowerr         (G.set_nowerr             )
+#define get_nowerr         (G.get_nowerr             )
+#define set_keep           (G.set_keep               )
+#define get_keep           (G.get_keep               )
+#define set_io32bit        (G.set_io32bit            )
+#define get_io32bit        (G.get_io32bit            )
+#define piomode            (G.piomode                )
+#define Xreadahead         (G.Xreadahead             )
+#define readonly           (G.readonly               )
+#define unmask             (G.unmask                 )
+#define mult               (G.mult                   )
+#define dma_q              (G.dma_q                  )
+#define nowerr             (G.nowerr                 )
+#define keep               (G.keep                   )
+#define io32bit            (G.io32bit                )
+#define dma                (G.dma                    )
+#define set_dma            (G.set_dma                )
+#define get_dma            (G.get_dma                )
+#define set_xfermode       (G.set_xfermode           )
+#define get_xfermode       (G.get_xfermode           )
+#define set_dkeep          (G.set_dkeep              )
+#define get_dkeep          (G.get_dkeep              )
+#define set_standby        (G.set_standby            )
+#define get_standby        (G.get_standby            )
+#define set_lookahead      (G.set_lookahead          )
+#define get_lookahead      (G.get_lookahead          )
+#define set_prefetch       (G.set_prefetch           )
+#define get_prefetch       (G.get_prefetch           )
+#define set_defects        (G.set_defects            )
+#define get_defects        (G.get_defects            )
+#define set_wcache         (G.set_wcache             )
+#define get_wcache         (G.get_wcache             )
+#define set_doorlock       (G.set_doorlock           )
+#define get_doorlock       (G.get_doorlock           )
+#define set_seagate        (G.set_seagate            )
+#define get_seagate        (G.get_seagate            )
+#define set_standbynow     (G.set_standbynow         )
+#define get_standbynow     (G.get_standbynow         )
+#define set_sleepnow       (G.set_sleepnow           )
+#define get_sleepnow       (G.get_sleepnow           )
+#define get_powermode      (G.get_powermode          )
+#define set_apmmode        (G.set_apmmode            )
+#define get_apmmode        (G.get_apmmode            )
+#define xfermode_requested (G.xfermode_requested     )
+#define dkeep              (G.dkeep                  )
+#define standby_requested  (G.standby_requested      )
+#define lookahead          (G.lookahead              )
+#define prefetch           (G.prefetch               )
+#define defects            (G.defects                )
+#define wcache             (G.wcache                 )
+#define doorlock           (G.doorlock               )
+#define apmmode            (G.apmmode                )
+#define get_IDentity       (G.get_IDentity           )
+#define set_busstate       (G.set_busstate           )
+#define get_busstate       (G.get_busstate           )
+#define perform_reset      (G.perform_reset          )
+#define perform_tristate   (G.perform_tristate       )
+#define unregister_hwif    (G.unregister_hwif        )
+#define scan_hwif          (G.scan_hwif              )
+#define busstate           (G.busstate               )
+#define tristate           (G.tristate               )
+#define hwif               (G.hwif                   )
+#define hwif_data          (G.hwif_data              )
+#define hwif_ctrl          (G.hwif_ctrl              )
+#define hwif_irq           (G.hwif_irq               )
+
+
 /* Busybox messages and functions */
 #if ENABLE_IOCTL_HEX2STR_ERROR
-static int ioctl_alt_func(int fd, int cmd, unsigned char *args, int alt, const char *string)
+static int ioctl_alt_func(/*int fd,*/ int cmd, unsigned char *args, int alt, const char *string)
 {
        if (!ioctl(fd, cmd, args))
                return 0;
        args[0] = alt;
        return bb_ioctl_or_warn(fd, cmd, args, string);
 }
-#define ioctl_alt_or_warn(fd,cmd,args,alt) ioctl_alt_func(fd,cmd,args,alt,#cmd)
+#define ioctl_alt_or_warn(cmd,args,alt) ioctl_alt_func(cmd,args,alt,#cmd)
 #else
-static int ioctl_alt_func(int fd, int cmd, unsigned char *args, int alt)
+static int ioctl_alt_func(/*int fd,*/ int cmd, unsigned char *args, int alt)
 {
        if (!ioctl(fd, cmd, args))
                return 0;
        args[0] = alt;
        return bb_ioctl_or_warn(fd, cmd, args);
 }
-#define ioctl_alt_or_warn(fd,cmd,args,alt) ioctl_alt_func(fd,cmd,args,alt)
+#define ioctl_alt_or_warn(cmd,args,alt) ioctl_alt_func(cmd,args,alt)
 #endif
 
 static void on_off(int value)
@@ -481,19 +441,43 @@ static void print_value_on_off(const char *str, unsigned long argp)
 }
 
 #if ENABLE_FEATURE_HDPARM_GET_IDENTITY
-static void print_ascii(uint16_t *p, uint8_t length);
+static void print_ascii(const char *p, int length)
+{
+#if BB_BIG_ENDIAN
+#define LE_ONLY(x)
+       enum { ofs = 0 };
+#else
+#define LE_ONLY(x) x
+       /* every 16bit word is big-endian (i.e. inverted) */
+       /* accessing bytes in 1,0, 3,2, 5,4... sequence */
+       int ofs = 1;
+#endif
+
+       length *= 2;
+       /* find first non-space & print it */
+       while (length && p[ofs] != ' ') {
+               p++;
+               LE_ONLY(ofs = -ofs;)
+               length--;
+       }
+       while (length && p[ofs]) {
+               bb_putchar(p[ofs]);
+               p++;
+               LE_ONLY(ofs = -ofs;)
+               length--;
+       }
+       bb_putchar('\n');
+#undef LE_ONLY
+}
 
 static void xprint_ascii(uint16_t *val, int i, const char *string, int n)
 {
        if (val[i]) {
                printf("\t%-20s", string);
-               print_ascii(&val[i], n);
+               print_ascii((void*)&val[i], n);
        }
 }
-#endif
-/* end of busybox specific stuff */
 
-#if ENABLE_FEATURE_HDPARM_GET_IDENTITY
 static uint8_t mode_loop(uint16_t mode_sup, uint16_t mode_sel, int cc, uint8_t *have_mode)
 {
        uint16_t ii;
@@ -514,41 +498,190 @@ static uint8_t mode_loop(uint16_t mode_sup, uint16_t mode_sel, int cc, uint8_t *
        return err_dma;
 }
 
-static void print_ascii(uint16_t *p, uint8_t length)
-{
-       uint8_t ii;
-       char cl;
+static const char pkt_str[] ALIGN1 =
+       "Direct-access device" "\0"             /* word 0, bits 12-8 = 00 */
+       "Sequential-access device" "\0"         /* word 0, bits 12-8 = 01 */
+       "Printer" "\0"                          /* word 0, bits 12-8 = 02 */
+       "Processor" "\0"                        /* word 0, bits 12-8 = 03 */
+       "Write-once device" "\0"                /* word 0, bits 12-8 = 04 */
+       "CD-ROM" "\0"                           /* word 0, bits 12-8 = 05 */
+       "Scanner" "\0"                          /* word 0, bits 12-8 = 06 */
+       "Optical memory" "\0"                   /* word 0, bits 12-8 = 07 */
+       "Medium changer" "\0"                   /* word 0, bits 12-8 = 08 */
+       "Communications device" "\0"            /* word 0, bits 12-8 = 09 */
+       "ACS-IT8 device" "\0"                   /* word 0, bits 12-8 = 0a */
+       "ACS-IT8 device" "\0"                   /* word 0, bits 12-8 = 0b */
+       "Array controller" "\0"                 /* word 0, bits 12-8 = 0c */
+       "Enclosure services" "\0"               /* word 0, bits 12-8 = 0d */
+       "Reduced block command device" "\0"     /* word 0, bits 12-8 = 0e */
+       "Optical card reader/writer" "\0"       /* word 0, bits 12-8 = 0f */
+;
+
+static const char ata1_cfg_str[] ALIGN1 =       /* word 0 in ATA-1 mode */
+       "reserved" "\0"                         /* bit 0 */
+       "hard sectored" "\0"                    /* bit 1 */
+       "soft sectored" "\0"                    /* bit 2 */
+       "not MFM encoded " "\0"                 /* bit 3 */
+       "head switch time > 15us" "\0"          /* bit 4 */
+       "spindle motor control option" "\0"     /* bit 5 */
+       "fixed drive" "\0"                      /* bit 6 */
+       "removable drive" "\0"                  /* bit 7 */
+       "disk xfer rate <= 5Mbs" "\0"           /* bit 8 */
+       "disk xfer rate > 5Mbs, <= 10Mbs" "\0"  /* bit 9 */
+       "disk xfer rate > 5Mbs" "\0"            /* bit 10 */
+       "rotational speed tol." "\0"            /* bit 11 */
+       "data strobe offset option" "\0"        /* bit 12 */
+       "track offset option" "\0"              /* bit 13 */
+       "format speed tolerance gap reqd" "\0"  /* bit 14 */
+       "ATAPI"                                 /* bit 14 */
+;
+
+static const char minor_str[] ALIGN1 =
+       /* word 81 value: */
+       "Unspecified" "\0"                                  /* 0x0000 */
+       "ATA-1 X3T9.2 781D prior to rev.4" "\0"             /* 0x0001 */
+       "ATA-1 published, ANSI X3.221-1994" "\0"            /* 0x0002 */
+       "ATA-1 X3T9.2 781D rev.4" "\0"                      /* 0x0003 */
+       "ATA-2 published, ANSI X3.279-1996" "\0"            /* 0x0004 */
+       "ATA-2 X3T10 948D prior to rev.2k" "\0"             /* 0x0005 */
+       "ATA-3 X3T10 2008D rev.1" "\0"                      /* 0x0006 */
+       "ATA-2 X3T10 948D rev.2k" "\0"                      /* 0x0007 */
+       "ATA-3 X3T10 2008D rev.0" "\0"                      /* 0x0008 */
+       "ATA-2 X3T10 948D rev.3" "\0"                       /* 0x0009 */
+       "ATA-3 published, ANSI X3.298-199x" "\0"            /* 0x000a */
+       "ATA-3 X3T10 2008D rev.6" "\0"                      /* 0x000b */
+       "ATA-3 X3T13 2008D rev.7 and 7a" "\0"               /* 0x000c */
+       "ATA/ATAPI-4 X3T13 1153D rev.6" "\0"                /* 0x000d */
+       "ATA/ATAPI-4 T13 1153D rev.13" "\0"                 /* 0x000e */
+       "ATA/ATAPI-4 X3T13 1153D rev.7" "\0"                /* 0x000f */
+       "ATA/ATAPI-4 T13 1153D rev.18" "\0"                 /* 0x0010 */
+       "ATA/ATAPI-4 T13 1153D rev.15" "\0"                 /* 0x0011 */
+       "ATA/ATAPI-4 published, ANSI INCITS 317-1998" "\0"  /* 0x0012 */
+       "ATA/ATAPI-5 T13 1321D rev.3" "\0"                  /* 0x0013 */
+       "ATA/ATAPI-4 T13 1153D rev.14" "\0"                 /* 0x0014 */
+       "ATA/ATAPI-5 T13 1321D rev.1" "\0"                  /* 0x0015 */
+       "ATA/ATAPI-5 published, ANSI INCITS 340-2000" "\0"  /* 0x0016 */
+       "ATA/ATAPI-4 T13 1153D rev.17" "\0"                 /* 0x0017 */
+       "ATA/ATAPI-6 T13 1410D rev.0" "\0"                  /* 0x0018 */
+       "ATA/ATAPI-6 T13 1410D rev.3a" "\0"                 /* 0x0019 */
+       "ATA/ATAPI-7 T13 1532D rev.1" "\0"                  /* 0x001a */
+       "ATA/ATAPI-6 T13 1410D rev.2" "\0"                  /* 0x001b */
+       "ATA/ATAPI-6 T13 1410D rev.1" "\0"                  /* 0x001c */
+       "ATA/ATAPI-7 published, ANSI INCITS 397-2005" "\0"  /* 0x001d */
+       "ATA/ATAPI-7 T13 1532D rev.0" "\0"                  /* 0x001e */
+       "reserved" "\0"                                     /* 0x001f */
+       "reserved" "\0"                                     /* 0x0020 */
+       "ATA/ATAPI-7 T13 1532D rev.4a" "\0"                 /* 0x0021 */
+       "ATA/ATAPI-6 published, ANSI INCITS 361-2002" "\0"  /* 0x0022 */
+       "reserved"                                          /* 0x0023-0xfffe */
+;
+static const char actual_ver[MINOR_MAX + 2] ALIGN1 = {
+          /* word 81 value: */
+       0, /* 0x0000 WARNING: actual_ver[] array */
+       1, /* 0x0001 WARNING: corresponds        */
+       1, /* 0x0002 WARNING: *exactly*          */
+       1, /* 0x0003 WARNING: to the ATA/        */
+       2, /* 0x0004 WARNING: ATAPI version      */
+       2, /* 0x0005 WARNING: listed in          */
+       3, /* 0x0006 WARNING: the                */
+       2, /* 0x0007 WARNING: minor_str          */
+       3, /* 0x0008 WARNING: array              */
+       2, /* 0x0009 WARNING: above.             */
+       3, /* 0x000a WARNING:                    */
+       3, /* 0x000b WARNING: If you change      */
+       3, /* 0x000c WARNING: that one,          */
+       4, /* 0x000d WARNING: change this one    */
+       4, /* 0x000e WARNING: too!!!             */
+       4, /* 0x000f */
+       4, /* 0x0010 */
+       4, /* 0x0011 */
+       4, /* 0x0012 */
+       5, /* 0x0013 */
+       4, /* 0x0014 */
+       5, /* 0x0015 */
+       5, /* 0x0016 */
+       4, /* 0x0017 */
+       6, /* 0x0018 */
+       6, /* 0x0019 */
+       7, /* 0x001a */
+       6, /* 0x001b */
+       6, /* 0x001c */
+       7, /* 0x001d */
+       7, /* 0x001e */
+       0, /* 0x001f */
+       0, /* 0x0020 */
+       7, /* 0x0021 */
+       6, /* 0x0022 */
+       0  /* 0x0023-0xfffe */
+};
 
-       /* find first non-space & print it */
-       for (ii = 0; ii < length; ii++) {
-               if ((char)((*p)>>8) != ' ')
-                       break;
-               cl = (char)(*p);
-               if (cl != ' ') {
-                       if (cl != '\0')
-                               printf("%c", cl);
-                       p++;
-                       ii++;
-                       break;
-               }
-               p++;
-       }
-       /* print the rest */
-       for (; ii< length; ii++) {
-               if (!(*p))
-                       break; /* some older devices have NULLs */
-               printf("%c%c", (char)((*p)>>8), (char)(*p));
-               p++;
-       }
-       puts("");
-}
+static const char cmd_feat_str[] ALIGN1 =
+       "" "\0"                                     /* word 82 bit 15: obsolete  */
+       "NOP cmd" "\0"                              /* word 82 bit 14 */
+       "READ BUFFER cmd" "\0"                      /* word 82 bit 13 */
+       "WRITE BUFFER cmd" "\0"                     /* word 82 bit 12 */
+       "" "\0"                                     /* word 82 bit 11: obsolete  */
+       "Host Protected Area feature set" "\0"      /* word 82 bit 10 */
+       "DEVICE RESET cmd" "\0"                     /* word 82 bit  9 */
+       "SERVICE interrupt" "\0"                    /* word 82 bit  8 */
+       "Release interrupt" "\0"                    /* word 82 bit  7 */
+       "Look-ahead" "\0"                           /* word 82 bit  6 */
+       "Write cache" "\0"                          /* word 82 bit  5 */
+       "PACKET command feature set" "\0"           /* word 82 bit  4 */
+       "Power Management feature set" "\0"         /* word 82 bit  3 */
+       "Removable Media feature set" "\0"          /* word 82 bit  2 */
+       "Security Mode feature set" "\0"            /* word 82 bit  1 */
+       "SMART feature set" "\0"                    /* word 82 bit  0 */
+                                                   /* -------------- */
+       "" "\0"                                     /* word 83 bit 15: !valid bit */
+       "" "\0"                                     /* word 83 bit 14:  valid bit */
+       "FLUSH CACHE EXT cmd" "\0"                  /* word 83 bit 13 */
+       "Mandatory FLUSH CACHE cmd " "\0"           /* word 83 bit 12 */
+       "Device Configuration Overlay feature set " "\0"
+       "48-bit Address feature set " "\0"          /* word 83 bit 10 */
+       "" "\0"
+       "SET MAX security extension" "\0"           /* word 83 bit  8 */
+       "Address Offset Reserved Area Boot" "\0"    /* word 83 bit  7 */
+       "SET FEATURES subcommand required to spinup after power up" "\0"
+       "Power-Up In Standby feature set" "\0"      /* word 83 bit  5 */
+       "Removable Media Status Notification feature set" "\0"
+       "Adv. Power Management feature set" "\0"    /* word 83 bit  3 */
+       "CFA feature set" "\0"                      /* word 83 bit  2 */
+       "READ/WRITE DMA QUEUED" "\0"                /* word 83 bit  1 */
+       "DOWNLOAD MICROCODE cmd" "\0"               /* word 83 bit  0 */
+                                                   /* -------------- */
+       "" "\0"                                     /* word 84 bit 15: !valid bit */
+       "" "\0"                                     /* word 84 bit 14:  valid bit */
+       "" "\0"                                     /* word 84 bit 13:  reserved */
+       "" "\0"                                     /* word 84 bit 12:  reserved */
+       "" "\0"                                     /* word 84 bit 11:  reserved */
+       "" "\0"                                     /* word 84 bit 10:  reserved */
+       "" "\0"                                     /* word 84 bit  9:  reserved */
+       "" "\0"                                     /* word 84 bit  8:  reserved */
+       "" "\0"                                     /* word 84 bit  7:  reserved */
+       "" "\0"                                     /* word 84 bit  6:  reserved */
+       "General Purpose Logging feature set" "\0"  /* word 84 bit  5 */
+       "" "\0"                                     /* word 84 bit  4:  reserved */
+       "Media Card Pass Through Command feature set " "\0"
+       "Media serial number " "\0"                 /* word 84 bit  2 */
+       "SMART self-test " "\0"                     /* word 84 bit  1 */
+       "SMART error logging "                      /* word 84 bit  0 */
+;
+
+static const char secu_str[] ALIGN1 =
+       "supported" "\0"                /* word 128, bit 0 */
+       "enabled" "\0"                  /* word 128, bit 1 */
+       "locked" "\0"                   /* word 128, bit 2 */
+       "frozen" "\0"                   /* word 128, bit 3 */
+       "expired: security count" "\0"  /* word 128, bit 4 */
+       "supported: enhanced erase"     /* word 128, bit 5 */
+;
 
 // Parse 512 byte disk identification block and print much crap.
-
-static void identify(uint16_t *id_supplied)
+static void identify(uint16_t *val) ATTRIBUTE_NORETURN;
+static void identify(uint16_t *val)
 {
-       uint16_t buf[256];
-       uint16_t *val, ii, jj, kk;
+       uint16_t ii, jj, kk;
        uint16_t like_std = 1, std = 0, min_std = 0xffff;
        uint16_t dev = NO_DEV, eqpt = NO_DEV;
        uint8_t  have_mode = 0, err_dma = 0;
@@ -556,19 +689,15 @@ static void identify(uint16_t *id_supplied)
        uint32_t ll, mm, nn, oo;
        uint64_t bbbig; /* (:) */
        const char *strng;
+#if BB_BIG_ENDIAN
+       uint16_t buf[256];
 
-       // Adjust for endianness if necessary.
-
-       if (BB_BIG_ENDIAN) {
-               swab(id_supplied, buf, sizeof(buf));
-               val = buf;
-       } else
-               val = id_supplied;
-
-       chksum &= 0xff;
-
+       // Adjust for endianness
+       swab(val, buf, sizeof(buf));
+       val = buf;
+#endif
        /* check if we recognise the device type */
-       puts("");
+       bb_putchar('\n');
        if (!(val[GEN_CONFIG] & NOT_ATA)) {
                dev = ATA_DEV;
                printf("ATA device, with ");
@@ -579,10 +708,10 @@ static void identify(uint16_t *id_supplied)
        } else if (!(val[GEN_CONFIG] & NOT_ATAPI)) {
                dev = ATAPI_DEV;
                eqpt = (val[GEN_CONFIG] & EQPT_TYPE) >> SHIFT_EQPT;
-               printf("ATAPI %s, with ", pkt_str[eqpt]);
+               printf("ATAPI %s, with ", eqpt <= 0xf ? nth_string(pkt_str, eqpt) : "unknown");
                like_std = 3;
        } else
-               /*"Unknown device type:\n\tbits 15&14 of general configuration word 0 both set to 1.\n"*/
+               /* "Unknown device type:\n\tbits 15&14 of general configuration word 0 both set to 1.\n" */
                bb_error_msg_and_die("unknown device type");
 
        printf("%sremovable media\n", !(val[GEN_CONFIG] & MEDIA_REMOVABLE) ? "non-" : "");
@@ -617,7 +746,7 @@ static void identify(uint16_t *id_supplied)
                if (val[MINOR] && (val[MINOR] <= MINOR_MAX)) {
                        if (like_std < 3) like_std = 3;
                        std = actual_ver[val[MINOR]];
-                       if (std) printf("\n\tUsed: %s ", minor_str[val[MINOR]]);
+                       if (std) printf("\n\tUsed: %s ", nth_string(minor_str, val[MINOR]));
 
                }
                /* looks like when they up-issue the std, they obsolete one;
@@ -685,7 +814,7 @@ static void identify(uint16_t *id_supplied)
                else if (like_std > std)
                        printf("& some of %u\n", like_std);
                else
-                       puts("");
+                       bb_putchar('\n');
        } else {
                /* TBD: do CDROM stuff more thoroughly.  For now... */
                kk = 0;
@@ -702,7 +831,7 @@ static void identify(uint16_t *id_supplied)
                                jj >>= 1;
                        }
                }
-               printf("%s\n", kk ? "" : "\n\tLikely used CD-ROM ATAPI-1");
+               puts(kk ? "" : "\n\tLikely used CD-ROM ATAPI-1");
                /* the cdrom stuff is more like ATA-2 than anything else, so: */
                like_std = 2;
        }
@@ -716,7 +845,7 @@ static void identify(uint16_t *id_supplied)
                jj = val[GEN_CONFIG] >> 1;
                for (ii = 1; ii < 15; ii++) {
                        if (jj & 0x0001)
-                               printf("\t%s\n", ata1_cfg_str[ii]);
+                               printf("\t%s\n", nth_string(ata1_cfg_str, ii));
                        jj >>=1;
                }
        }
@@ -728,7 +857,7 @@ static void identify(uint16_t *id_supplied)
                else if ((val[GEN_CONFIG] & DRQ_RESPONSE_TIME) ==  DRQ_50US_VAL)
                        strng ="50us";
                else
-                       strng = "Unknown";
+                       strng = "unknown";
                printf("\tDRQ response: %s\n\tPacket size: ", strng); /* Data Request (DRQ) */
 
                if ((val[GEN_CONFIG] & PKT_SIZE_SUPPORTED) == PKT_SIZE_12_VAL)
@@ -736,7 +865,7 @@ static void identify(uint16_t *id_supplied)
                else if ((val[GEN_CONFIG] & PKT_SIZE_SUPPORTED) == PKT_SIZE_16_VAL)
                        strng = "16 bytes";
                else
-                       strng = "Unknown";
+                       strng = "unknown";
                puts(strng);
        } else {
                /* addressing...CHS? See section 6.2 of ATA specs 4 or 5 */
@@ -785,7 +914,7 @@ static void identify(uint16_t *id_supplied)
                if (bbbig > 1000)
                        printf("(%"PRIu64" GB)\n", bbbig/1000);
                else
-                       puts("");
+                       bb_putchar('\n');
        }
 
        /* hw support of commands (capabilities) */
@@ -828,7 +957,7 @@ static void identify(uint16_t *id_supplied)
                        if ((like_std > 3) && ((val[CAPAB_1] & VALID) == VALID_VAL))
                                printf(", %s device specific minimum\n", (val[CAPAB_1] & MIN_STANDBY_TIMER) ? "with" : "no");
                        else
-                               puts("");
+                               bb_putchar('\n');
                }
                printf("\tR/W multiple sector transfer: ");
                if ((like_std < 3) && !(val[SECTOR_XFER_MAX] & SECTOR_XFER))
@@ -865,7 +994,7 @@ static void identify(uint16_t *id_supplied)
                        printf("\tOverlap support:");
                        if (val[PKT_REL]) printf(" %uus to release bus.", val[PKT_REL]);
                        if (val[SVC_NBSY]) printf(" %uus to clear BSY after SERVICE cmd.", val[SVC_NBSY]);
-                       puts("");
+                       bb_putchar('\n');
                }
        }
 
@@ -892,7 +1021,7 @@ static void identify(uint16_t *id_supplied)
                        err_dma += mode_loop(jj, kk, 'u', &have_mode);
                }
                if (err_dma || !have_mode) printf("(?)");
-               puts("");
+               bb_putchar('\n');
 
                if ((dev == ATAPI_DEV) && (eqpt != CDROM) && (val[CAPAB_0] & DMA_IL_SUP))
                        printf("\t\tInterleaved DMA support\n");
@@ -903,7 +1032,7 @@ static void identify(uint16_t *id_supplied)
                        printf("\t\tCycle time:");
                        if (val[DMA_TIME_MIN]) printf(" min=%uns", val[DMA_TIME_MIN]);
                        if (val[DMA_TIME_NORM]) printf(" recommended=%uns", val[DMA_TIME_NORM]);
-                       puts("");
+                       bb_putchar('\n');
                }
        }
 
@@ -917,20 +1046,20 @@ static void identify(uint16_t *id_supplied)
                        if (jj & 0x0001) printf("pio%d ", ii);
                        jj >>=1;
                }
-               puts("");
+               bb_putchar('\n');
        } else if (((min_std < 5) || (eqpt == CDROM)) && (val[PIO_MODE] & MODE)) {
                for (ii = 0; ii <= val[PIO_MODE]>>8; ii++)
                        printf("pio%d ", ii);
-               puts("");
+               bb_putchar('\n');
        } else
-               printf("unknown\n");
+               puts("unknown");
 
        if (val[WHATS_VALID] & OK_W64_70) {
                if (val[PIO_NO_FLOW] || val[PIO_FLOW]) {
                        printf("\t\tCycle time:");
                        if (val[PIO_NO_FLOW]) printf(" no flow control=%uns", val[PIO_NO_FLOW]);
                        if (val[PIO_FLOW]) printf("  IORDY flow control=%uns", val[PIO_FLOW]);
-                       puts("");
+                       bb_putchar('\n');
                }
        }
 
@@ -939,8 +1068,9 @@ static void identify(uint16_t *id_supplied)
                jj = val[CMDS_SUPP_0];
                kk = val[CMDS_EN_0];
                for (ii = 0; ii < NUM_CMD_FEAT_STR; ii++) {
-                       if ((jj & 0x8000) && (*cmd_feat_str[ii] != '\0')) {
-                               printf("\t%s\t%s\n", (kk & 0x8000) ? "   *" : "", cmd_feat_str[ii]);
+                       const char *feat_str = nth_string(cmd_feat_str, ii);
+                       if ((jj & 0x8000) && (*feat_str != '\0')) {
+                               printf("\t%s\t%s\n", (kk & 0x8000) ? "   *" : "", feat_str);
                        }
                        jj <<= 1;
                        kk <<= 1;
@@ -956,7 +1086,7 @@ static void identify(uint16_t *id_supplied)
        }
        /* Removable Media Status Notification feature set */
        if ((val[RM_STAT] & RM_STAT_BITS) == RM_STAT_SUP)
-               printf("\t%s supported\n", cmd_feat_str[27]);
+               printf("\t%s supported\n", nth_string(cmd_feat_str, 27));
 
        /* security */
        if ((eqpt != CDROM) && (like_std > 3)
@@ -968,7 +1098,7 @@ static void identify(uint16_t *id_supplied)
                jj = val[SECU_STATUS];
                if (jj) {
                        for (ii = 0; ii < NUM_SECU_STR; ii++) {
-                               printf("\t%s\t%s\n", (!(jj & 0x0001)) ? "not" : "",  secu_str[ii]);
+                               printf("\t%s\t%s\n", (!(jj & 0x0001)) ? "not" : "", nth_string(secu_str, ii));
                                jj >>=1;
                        }
                        if (val[SECU_STATUS] & SECU_ENABLED) {
@@ -981,14 +1111,15 @@ static void identify(uint16_t *id_supplied)
                        printf("\t");
                        if (jj) printf("%umin for %sSECURITY ERASE UNIT. ", jj==ERASE_BITS ? 508 : jj<<1, "");
                        if (kk) printf("%umin for %sSECURITY ERASE UNIT. ", kk==ERASE_BITS ? 508 : kk<<1, "ENHANCED ");
-                       puts("");
+                       bb_putchar('\n');
                }
        }
 
        /* reset result */
        jj = val[HWRST_RSLT];
        if ((jj & VALID) == VALID_VAL) {
-               if (!(oo = (jj & RST0)))
+               oo = (jj & RST0);
+               if (!oo)
                        jj >>= 8;
                if ((jj & DEV_DET) == JUMPER_VAL)
                        strng = " determined by the jumper";
@@ -1018,72 +1149,6 @@ static void identify(uint16_t *id_supplied)
 }
 #endif
 
-static smallint get_identity, get_geom;
-static smallint do_flush;
-static smallint do_ctimings, do_timings;
-static smallint reread_partn;
-
-static smallint set_piomode, noisy_piomode;
-static smallint set_readahead, get_readahead;
-static smallint set_readonly, get_readonly;
-static smallint set_unmask, get_unmask;
-static smallint set_mult, get_mult;
-static smallint set_dma_q, get_dma_q;
-static smallint set_nowerr, get_nowerr;
-static smallint set_keep, get_keep;
-static smallint set_io32bit, get_io32bit;
-static int piomode;
-static unsigned long Xreadahead;
-static unsigned long readonly;
-static unsigned long unmask;
-static unsigned long mult;
-static unsigned long dma_q;
-static unsigned long nowerr;
-static unsigned long keep;
-static unsigned long io32bit;
-#if ENABLE_FEATURE_HDPARM_HDIO_GETSET_DMA
-static unsigned long dma;
-static smallint set_dma, get_dma;
-#endif
-#ifdef HDIO_DRIVE_CMD
-static smallint set_xfermode, get_xfermode;
-static smallint set_dkeep, get_dkeep;
-static smallint set_standby, get_standby;
-static smallint set_lookahead, get_lookahead;
-static smallint set_prefetch, get_prefetch;
-static smallint set_defects, get_defects;
-static smallint set_wcache, get_wcache;
-static smallint set_doorlock, get_doorlock;
-static smallint set_seagate, get_seagate;
-static smallint set_standbynow, get_standbynow;
-static smallint set_sleepnow, get_sleepnow;
-static smallint get_powermode;
-static smallint set_apmmode, get_apmmode;
-static int xfermode_requested;
-static unsigned long dkeep;
-static unsigned long standby_requested;
-static unsigned long lookahead;
-static unsigned long prefetch;
-static unsigned long defects;
-static unsigned long wcache;
-static unsigned long doorlock;
-static unsigned long apmmode;
-#endif
-USE_FEATURE_HDPARM_GET_IDENTITY(        static smallint get_IDentity;)
-USE_FEATURE_HDPARM_HDIO_TRISTATE_HWIF(  static smallint set_busstate, get_busstate;)
-USE_FEATURE_HDPARM_HDIO_DRIVE_RESET(    static smallint perform_reset;)
-USE_FEATURE_HDPARM_HDIO_TRISTATE_HWIF(  static smallint perform_tristate;)
-USE_FEATURE_HDPARM_HDIO_UNREGISTER_HWIF(static smallint unregister_hwif;)
-USE_FEATURE_HDPARM_HDIO_SCAN_HWIF(      static smallint scan_hwif;)
-USE_FEATURE_HDPARM_HDIO_TRISTATE_HWIF(  static unsigned long busstate;)
-USE_FEATURE_HDPARM_HDIO_TRISTATE_HWIF(  static unsigned long tristate;)
-USE_FEATURE_HDPARM_HDIO_UNREGISTER_HWIF(static unsigned long hwif;)
-#if ENABLE_FEATURE_HDPARM_HDIO_SCAN_HWIF
-static unsigned long hwif_data;
-static unsigned long hwif_ctrl;
-static unsigned long hwif_irq;
-#endif
-
 // Historically, if there was no HDIO_OBSOLETE_IDENTITY, then
 // then the HDIO_GET_IDENTITY only returned 142 bytes.
 // Otherwise, HDIO_OBSOLETE_IDENTITY returns 142 bytes,
@@ -1096,31 +1161,33 @@ static unsigned long hwif_irq;
 // Too bad, really.
 
 #if ENABLE_FEATURE_HDPARM_GET_IDENTITY
-static const char * const cfg_str[] =
-{      "",          "HardSect",   "SoftSect",   "NotMFM",
-       "HdSw>15uSec", "SpinMotCtl", "Fixed",     "Removeable",
-       "DTR<=5Mbs",   "DTR>5Mbs",   "DTR>10Mbs", "RotSpdTol>.5%",
-       "dStbOff",     "TrkOff",     "FmtGapReq", "nonMagnetic"
-};
+static const char cfg_str[] ALIGN1 =
+       """\0"            "HardSect""\0"   "SoftSect""\0"  "NotMFM""\0"
+       "HdSw>15uSec""\0" "SpinMotCtl""\0" "Fixed""\0"     "Removeable""\0"
+       "DTR<=5Mbs""\0"   "DTR>5Mbs""\0"   "DTR>10Mbs""\0" "RotSpdTol>.5%""\0"
+       "dStbOff""\0"     "TrkOff""\0"     "FmtGapReq""\0" "nonMagnetic"
+;
 
-static const char * const BuffType[] = {"Unknown", "1Sect", "DualPort", "DualPortCache"};
+static const char BuffType[] ALIGN1 =
+       "unknown""\0"     "1Sect""\0"      "DualPort""\0"  "DualPortCache"
+;
 
 static void dump_identity(const struct hd_driveid *id)
 {
        int i;
-       const unsigned short int *id_regs = (const void*) id;
+       const unsigned short *id_regs = (const void*) id;
 
        printf("\n Model=%.40s, FwRev=%.8s, SerialNo=%.20s\n Config={",
                                id->model, id->fw_rev, id->serial_no);
        for (i = 0; i <= 15; i++) {
                if (id->config & (1<<i))
-                       printf(" %s", cfg_str[i]);
+                       printf(" %s", nth_string(cfg_str, i));
        }
        printf(" }\n RawCHS=%u/%u/%u, TrkSize=%u, SectSize=%u, ECCbytes=%u\n"
                        " BuffType=(%u) %s, BuffSize=%ukB, MaxMultSect=%u",
                                id->cyls, id->heads, id->sectors, id->track_bytes,
                                id->sector_bytes, id->ecc_bytes,
-                               id->buf_type, BuffType[(id->buf_type > 3) ? 0 :  id->buf_type],
+                               id->buf_type, nth_string(BuffType, (id->buf_type > 3) ? 0 : id->buf_type),
                                id->buf_size/2, id->max_multsect);
        if (id->max_multsect) {
                printf(", MultSect=");
@@ -1131,7 +1198,7 @@ static void dump_identity(const struct hd_driveid *id)
                else
                        printf("off");
        }
-       puts("");
+       bb_putchar('\n');
 
        if (!(id->field_valid & 1))
                printf(" (maybe):");
@@ -1226,7 +1293,7 @@ static void dump_identity(const struct hd_driveid *id)
        if ((id->minor_rev_num && id->minor_rev_num <= 31)
         || (id->major_rev_num && id->minor_rev_num <= 31)
        ) {
-               printf("\n Drive conforms to: %s: ", (id->minor_rev_num <= 31) ? minor_str[id->minor_rev_num] : "Unknown");
+               printf("\n Drive conforms to: %s: ", (id->minor_rev_num <= 31) ? nth_string(minor_str, id->minor_rev_num) : "unknown");
                if (id->major_rev_num != 0x0000 &&  /* NOVAL_0 */
                    id->major_rev_num != 0xFFFF) {  /* NOVAL_1 */
                        for (i = 0; i <= 15; i++) {
@@ -1240,7 +1307,7 @@ static void dump_identity(const struct hd_driveid *id)
 }
 #endif
 
-static void flush_buffer_cache(int fd)
+static void flush_buffer_cache(/*int fd*/ void)
 {
        fsync(fd);                              /* flush buffers */
        ioctl_or_warn(fd, BLKFLSBUF, NULL); /* do it again, big time */
@@ -1255,121 +1322,118 @@ static void flush_buffer_cache(int fd)
 #endif
 }
 
-static int seek_to_zero(int fd)
+static void seek_to_zero(/*int fd*/ void)
 {
-       if (lseek(fd, (off_t) 0, SEEK_SET))
-               return 1;
-       return 0;
+       xlseek(fd, (off_t) 0, SEEK_SET);
 }
 
-static int read_big_block(int fd, char *buf)
+static void read_big_block(/*int fd,*/ char *buf)
 {
        int i;
 
-       i = read(fd, buf, TIMING_BUF_BYTES);
-       if (i != TIMING_BUF_BYTES) {
-               bb_error_msg("read(%d bytes) failed (rc=%d)", TIMING_BUF_BYTES, i);
-               return 1;
-       }
+       xread(fd, buf, TIMING_BUF_BYTES);
        /* access all sectors of buf to ensure the read fully completed */
        for (i = 0; i < TIMING_BUF_BYTES; i += 512)
                buf[i] &= 1;
-       return 0;
 }
 
-static int do_blkgetsize(int fd, unsigned long long *blksize64)
+static unsigned dev_size_mb(/*int fd*/ void)
 {
-       int rc;
-       unsigned blksize32 = 0;
+       union {
+               unsigned long long blksize64;
+               unsigned blksize32;
+       } u;
 
-       if (0 == ioctl(fd, BLKGETSIZE64, blksize64)) {  // returns bytes
-               *blksize64 /= 512;
-               return 0;
+       if (0 == ioctl(fd, BLKGETSIZE64, &u.blksize64)) { // bytes
+               u.blksize64 /= (1024 * 1024);
+       } else {
+               xioctl(fd, BLKGETSIZE, &u.blksize32); // sectors
+               u.blksize64 = u.blksize32 / (2 * 1024);
        }
-       rc = ioctl_or_warn(fd, BLKGETSIZE, &blksize32); // returns sectors
-       *blksize64 = blksize32;
-       return rc;
+       if (u.blksize64 > UINT_MAX)
+               return UINT_MAX;
+       return u.blksize64;
 }
 
-static void print_timing(unsigned t, double e)
+static void print_timing(unsigned m, unsigned elapsed_us)
 {
-       if (t >= e)  /* more than 1MB/s */
-               printf("%4d MB in %.2f seconds = %.2f %cB/sec\n", t, e, t / e, 'M');
-       else
-               printf("%4d MB in %.2f seconds = %.2f %cB/sec\n", t, e, t / e * 1024, 'k');
+       unsigned sec = elapsed_us / 1000000;
+       unsigned hs = (elapsed_us % 1000000) / 10000;
+
+       printf("%5u MB in %u.%02u seconds = %u kB/s\n",
+               m, sec, hs,
+               /* "| 1" prevents div-by-0 */
+               (unsigned) ((unsigned long long)m * (1024 * 1000000) / (elapsed_us | 1))
+               // ~= (m * 1024) / (elapsed_us / 1000000)
+               // = kb / elapsed_sec
+       );
 }
 
-static void do_time(int flag, int fd)
-/* flag = 0 time_cache, 1 time_device */
+static void do_time(int cache /*,int fd*/)
+/* cache=1: time cache: repeatedly read N MB at offset 0
+ * cache=0: time device: linear read, starting at offset 0
+ */
 {
-       static const struct itimerval thousand = {{1000, 0}, {1000, 0}};
-
-       struct itimerval itv;
+       unsigned max_iterations, iterations;
+       unsigned start; /* doesn't need to be long long */
        unsigned elapsed, elapsed2;
-       unsigned max_iterations, total_MB, iterations;
-       unsigned long long blksize;
-       RESERVE_CONFIG_BUFFER(buf, TIMING_BUF_BYTES);
+       unsigned total_MB;
+       char *buf = xmalloc(TIMING_BUF_BYTES);
 
-       if (mlock(buf, TIMING_BUF_BYTES)) {
-               bb_perror_msg("mlock");
-               goto quit2;
-       }
-
-       max_iterations = 1024;
-       if (0 == do_blkgetsize(fd, &blksize)) {
-               max_iterations = blksize / (2 * 1024) / TIMING_BUF_MB;
-       }
+       if (mlock(buf, TIMING_BUF_BYTES))
+               bb_perror_msg_and_die("mlock");
 
-       /* Clear out the device request queues & give them time to complete */
+       /* Clear out the device request queues & give them time to complete.
+        * NB: *small* delay. User is expected to have a clue and to not run
+        * heavy io in parallel with measurements. */
        sync();
-       sleep(2);
-       if (flag == 0) { /* Time cache */
-               if (seek_to_zero(fd))
-                       goto quit;
-               if (read_big_block(fd, buf))
-                       goto quit;
-               printf(" Timing buffer-cache reads:  ");
+       sleep(1);
+       if (cache) { /* Time cache */
+               seek_to_zero();
+               read_big_block(buf);
+               printf("Timing buffer-cache reads: ");
        } else { /* Time device */
-               printf(" Timing buffered disk reads: ");
+               printf("Timing buffered disk reads:");
        }
        fflush(stdout);
-       iterations = 0;
-       /*
-        * getitimer() is used rather than gettimeofday() because
-        * it is much more consistent (on my machine, at least).
-        */
-       setitimer(ITIMER_REAL, &thousand, NULL);
+
        /* Now do the timing */
+       iterations = 0;
+       /* Max time to run (small for cache, avoids getting
+        * huge total_MB which can overlow unsigned type) */
+       elapsed2 = 510000; /* cache */
+       max_iterations = UINT_MAX;
+       if (!cache) {
+               elapsed2 = 3000000; /* not cache */
+               /* Don't want to read past the end! */
+               max_iterations = dev_size_mb() / TIMING_BUF_MB;
+       }
+       start = monotonic_us();
        do {
+               if (cache)
+                       seek_to_zero();
+               read_big_block(buf);
+               elapsed = (unsigned)monotonic_us() - start;
                ++iterations;
-               if ((flag == 0) && seek_to_zero(fd))
-                       goto quit;
-               if (read_big_block(fd, buf))
-                       goto quit;
-               getitimer(ITIMER_REAL, &itv);
-               elapsed = (1000 - itv.it_value.tv_sec) * 1000000
-                               - itv.it_value.tv_usec;
-       } while (elapsed < 3000000 && iterations < max_iterations);
+       } while (elapsed < elapsed2 && iterations < max_iterations);
        total_MB = iterations * TIMING_BUF_MB;
-       if (flag == 0) {
-               /* Now remove the lseek() and getitimer() overheads from the elapsed time */
-               setitimer(ITIMER_REAL, &thousand, NULL);
+       //printf(" elapsed:%u iterations:%u ", elapsed, iterations);
+       if (cache) {
+               /* Cache: remove lseek() and monotonic_us() overheads
+                * from elapsed */
+               start = monotonic_us();
                do {
-                       if (seek_to_zero(fd))
-                               goto quit;
-                       getitimer(ITIMER_REAL, &itv);
-                       elapsed2 = (1000 - itv.it_value.tv_sec) * 1000000
-                                       - itv.it_value.tv_usec;
+                       seek_to_zero();
+                       elapsed2 = (unsigned)monotonic_us() - start;
                } while (--iterations);
+               //printf(" elapsed2:%u ", elapsed2);
                elapsed -= elapsed2;
-               total_MB *= BUFCACHE_FACTOR;
-               flush_buffer_cache(fd);
+               total_MB *= 2; // BUFCACHE_FACTOR (why?)
+               flush_buffer_cache();
        }
-       print_timing(total_MB, elapsed / 1000000.0);
- quit:
+       print_timing(total_MB, elapsed);
        munlock(buf, TIMING_BUF_BYTES);
- quit2:
-       RELEASE_CONFIG_BUFFER(buf);
+       free(buf);
 }
 
 #if ENABLE_FEATURE_HDPARM_HDIO_TRISTATE_HWIF
@@ -1387,88 +1451,52 @@ static void bus_state_value(unsigned value)
 #endif
 
 #ifdef HDIO_DRIVE_CMD
-static void interpret_standby(unsigned standby)
+static void interpret_standby(uint8_t standby)
 {
-       unsigned t;
-
        printf(" (");
-       if (standby == 0)
+       if (standby == 0) {
                printf("off");
-       else if (standby == 252)
-               printf("21 minutes");
-       else if (standby == 253)
-               printf("vendor-specific");
-       else if (standby == 254)
-               printf("Reserved");
-       else if (standby == 255)
-               printf("21 minutes + 15 seconds");
-       else if (standby <= 240) {
-               t = standby * 5;
-               printf("%u minutes + %u seconds", t / 60, t % 60);
+       } else if (standby <= 240 || standby == 252 || standby == 255) {
+               /* standby is in 5 sec units */
+               printf("%u minutes %u seconds", standby / 12, (standby*5) % 60);
        } else if (standby <= 251) {
-               t = (standby - 240) * 30;
-               printf("%u hours + %u minutes", t / 60, t % 60);
-       } else
-               printf("illegal value");
+               unsigned t = (standby - 240); /* t is in 30 min units */;
+               printf("%u.%c hours", t / 2, (t & 1) ? '0' : '5');
+       }
+       if (standby == 253)
+               printf("vendor-specific");
+       if (standby == 254)
+               printf("reserved");
        printf(")\n");
 }
 
-struct xfermode_entry {
-       int val;
-       const char *name;
+static const uint8_t xfermode_val[] ALIGN1 = {
+        8,      9,     10,     11,     12,     13,     14,     15,
+       16,     17,     18,     19,     20,     21,     22,     23,
+       32,     33,     34,     35,     36,     37,     38,     39,
+       64,     65,     66,     67,     68,     69,     70,     71
 };
-
-static const struct xfermode_entry xfermode_table[] = {
-       { 8,    "pio0" },
-       { 9,    "pio1" },
-       { 10,   "pio2" },
-       { 11,   "pio3" },
-       { 12,   "pio4" },
-       { 13,   "pio5" },
-       { 14,   "pio6" },
-       { 15,   "pio7" },
-       { 16,   "sdma0" },
-       { 17,   "sdma1" },
-       { 18,   "sdma2" },
-       { 19,   "sdma3" },
-       { 20,   "sdma4" },
-       { 21,   "sdma5" },
-       { 22,   "sdma6" },
-       { 23,   "sdma7" },
-       { 32,   "mdma0" },
-       { 33,   "mdma1" },
-       { 34,   "mdma2" },
-       { 35,   "mdma3" },
-       { 36,   "mdma4" },
-       { 37,   "mdma5" },
-       { 38,   "mdma6" },
-       { 39,   "mdma7" },
-       { 64,   "udma0" },
-       { 65,   "udma1" },
-       { 66,   "udma2" },
-       { 67,   "udma3" },
-       { 68,   "udma4" },
-       { 69,   "udma5" },
-       { 70,   "udma6" },
-       { 71,   "udma7" },
-       { 0, NULL }
+/* NB: we save size by _not_ storing terninating NUL! */
+static const char xfermode_name[][5] ALIGN1 = {
+       "pio0", "pio1", "pio2", "pio3", "pio4", "pio5", "pio6", "pio7",
+       "sdma0","sdma1","sdma2","sdma3","sdma4","sdma5","sdma6","sdma7",
+       "mdma0","mdma1","mdma2","mdma3","mdma4","mdma5","mdma6","mdma7",
+       "udma0","udma1","udma2","udma3","udma4","udma5","udma6","udma7"
 };
 
-static int translate_xfermode(char * name)
+static int translate_xfermode(const char *name)
 {
-       const struct xfermode_entry *tmp;
-       char *endptr;
-       int val = -1;
+       int val, i;
 
-       for (tmp = xfermode_table; tmp->name != NULL; ++tmp) {
-               if (!strcmp(name, tmp->name))
-                       return tmp->val;
+       for (i = 0; i < ARRAY_SIZE(xfermode_val); i++) {
+               if (!strncmp(name, xfermode_name[i], 5))
+                       if (strlen(name) <= 5)
+                               return xfermode_val[i];
        }
-
-       val = strtol(name, &endptr, 10);
-       if (*endptr == '\0')
+       /* Negative numbers are invalid and are caught later */
+       val = bb_strtoi(name, NULL, 10);
+       if (!errno)
                return val;
-
        return -1;
 }
 
@@ -1480,15 +1508,15 @@ static void interpret_xfermode(unsigned xfermode)
        else if (xfermode == 1)
                printf("default PIO mode, disable IORDY");
        else if (xfermode >= 8 && xfermode <= 15)
-               printf("PIO flow control mode%u", xfermode-8);
+               printf("PIO flow control mode%u", xfermode - 8);
        else if (xfermode >= 16 && xfermode <= 23)
-               printf("singleword DMA mode%u", xfermode-16);
+               printf("singleword DMA mode%u", xfermode - 16);
        else if (xfermode >= 32 && xfermode <= 39)
-               printf("multiword DMA mode%u", xfermode-32);
+               printf("multiword DMA mode%u", xfermode - 32);
        else if (xfermode >= 64 && xfermode <= 71)
-               printf("UltraDMA mode%u", xfermode-64);
+               printf("UltraDMA mode%u", xfermode - 64);
        else
-               printf("Unknown");
+               printf("unknown");
        printf(")\n");
 }
 #endif /* HDIO_DRIVE_CMD */
@@ -1501,7 +1529,7 @@ static void print_flag(int flag, const char *s, unsigned long value)
 
 static void process_dev(char *devname)
 {
-       int fd;
+       /*int fd;*/
        long parm, multcount;
 #ifndef HDIO_DRIVE_CMD
        int force_operation = 0;
@@ -1511,7 +1539,8 @@ static void process_dev(char *devname)
        unsigned char args[4] = { WIN_SETFEATURES, 0, 0, 0 };
        const char *fmt = " %s\t= %2ld";
 
-       fd = xopen(devname, O_RDONLY|O_NONBLOCK);
+       /*fd = xopen(devname, O_RDONLY | O_NONBLOCK);*/
+       xmove_fd(xopen(devname, O_RDONLY | O_NONBLOCK), fd);
        printf("\n%s:\n", devname);
 
        if (set_readahead) {
@@ -1575,10 +1604,12 @@ static void process_dev(char *devname)
                ioctl_or_warn(fd, HDIO_SET_DMA, (int *)dma);
        }
 #endif /* FEATURE_HDPARM_HDIO_GETSET_DMA */
+#ifdef HDIO_SET_QDMA
        if (set_dma_q) {
                print_flag_on_off(get_dma_q, "DMA queue_depth", dma_q);
                ioctl_or_warn(fd, HDIO_SET_QDMA, (int *)dma_q);
        }
+#endif
        if (set_nowerr) {
                print_flag_on_off(get_nowerr, "nowerr", nowerr);
                ioctl_or_warn(fd, HDIO_SET_NOWERR, (int *)nowerr);
@@ -1641,7 +1672,6 @@ static void process_dev(char *devname)
 #ifndef WIN_FLUSHCACHE
 #define WIN_FLUSHCACHE 0xe7
 #endif
-               static unsigned char flushcache[4] = { WIN_FLUSHCACHE, 0, 0, 0 };
 #endif /* DO_FLUSHCACHE */
                args[2] = wcache ? 0x02 : 0x82;
                print_flag_on_off(get_wcache, "drive write-caching", wcache);
@@ -1669,7 +1699,7 @@ static void process_dev(char *devname)
 #endif
                if (get_standbynow) printf(" issuing standby command\n");
                args[0] = WIN_STANDBYNOW1;
-               ioctl_alt_or_warn(fd, HDIO_DRIVE_CMD, args, WIN_STANDBYNOW2);
+               ioctl_alt_or_warn(HDIO_DRIVE_CMD, args, WIN_STANDBYNOW2);
        }
        if (set_sleepnow) {
 #ifndef WIN_SLEEPNOW1
@@ -1680,7 +1710,7 @@ static void process_dev(char *devname)
 #endif
                if (get_sleepnow) printf(" issuing sleep command\n");
                args[0] = WIN_SLEEPNOW1;
-               ioctl_alt_or_warn(fd, HDIO_DRIVE_CMD, args, WIN_SLEEPNOW2);
+               ioctl_alt_or_warn(HDIO_DRIVE_CMD, args, WIN_SLEEPNOW2);
        }
        if (set_seagate) {
                args[0] = 0xfb;
@@ -1700,9 +1730,9 @@ static void process_dev(char *devname)
 #else  /* HDIO_DRIVE_CMD */
        if (force_operation) {
                char buf[512];
-               flush_buffer_cache(fd);
+               flush_buffer_cache();
                if (-1 == read(fd, buf, sizeof(buf)))
-                       bb_perror_msg("read(%d bytes) failed (rc=%d)", sizeof(buf), -1);
+                       bb_perror_msg("read(%d bytes) failed (rc=-1)", sizeof(buf));
        }
 #endif /* HDIO_DRIVE_CMD */
 
@@ -1736,7 +1766,7 @@ static void process_dev(char *devname)
                }
        }
        if (get_unmask) {
-               if(!ioctl_or_warn(fd, HDIO_GET_UNMASKINTR, (unsigned long *)parm))
+               if(!ioctl_or_warn(fd, HDIO_GET_UNMASKINTR, &parm))
                        print_value_on_off("unmaskirq", parm);
        }
 
@@ -1752,25 +1782,27 @@ static void process_dev(char *devname)
                }
        }
 #endif
+#ifdef HDIO_GET_QDMA
        if (get_dma_q) {
-               if(!ioctl_or_warn(fd, HDIO_GET_QDMA, (unsigned long *)parm))
+               if(!ioctl_or_warn(fd, HDIO_GET_QDMA, &parm))
                        print_value_on_off("queue_depth", parm);
        }
+#endif
        if (get_keep) {
-               if(!ioctl_or_warn(fd, HDIO_GET_KEEPSETTINGS, (unsigned long *)parm))
+               if(!ioctl_or_warn(fd, HDIO_GET_KEEPSETTINGS, &parm))
                        print_value_on_off("keepsettings", parm);
        }
 
        if (get_nowerr) {
-               if(!ioctl_or_warn(fd, HDIO_GET_NOWERR, (unsigned long *)parm))
+               if(!ioctl_or_warn(fd, HDIO_GET_NOWERR, &parm))
                        print_value_on_off("nowerr", parm);
        }
        if (get_readonly) {
-               if(!ioctl_or_warn(fd, BLKROGET, (unsigned long *)parm))
+               if(!ioctl_or_warn(fd, BLKROGET, &parm))
                        print_value_on_off("readonly", parm);
        }
        if (get_readahead) {
-               if(!ioctl_or_warn(fd, BLKRAGET, (unsigned long *)parm))
+               if(!ioctl_or_warn(fd, BLKRAGET, &parm))
                        print_value_on_off("readahead", parm);
        }
        if (get_geom) {
@@ -1793,7 +1825,7 @@ static void process_dev(char *devname)
                const char *state;
 
                args[0] = WIN_CHECKPOWERMODE1;
-               if (ioctl_alt_or_warn(fd, HDIO_DRIVE_CMD, args, WIN_CHECKPOWERMODE2)) {
+               if (ioctl_alt_or_warn(HDIO_DRIVE_CMD, args, WIN_CHECKPOWERMODE2)) {
                        if (errno != EIO || args[0] != 0 || args[1] != 0)
                                state = "unknown";
                        else
@@ -1831,7 +1863,7 @@ static void process_dev(char *devname)
                } else if (errno == -ENOMSG)
                        printf(" no identification info available\n");
                else if (ENABLE_IOCTL_HEX2STR_ERROR)  /* To be coherent with ioctl_or_warn */
-                       bb_perror_msg("HDIO_GET_IDENTITY"); 
+                       bb_perror_msg("HDIO_GET_IDENTITY");
                else
                        bb_perror_msg("ioctl %#x failed", HDIO_GET_IDENTITY);
        }
@@ -1842,7 +1874,7 @@ static void process_dev(char *devname)
                memset(args1, 0, sizeof(args1));
                args1[0] = WIN_IDENTIFY;
                args1[3] = 1;
-               if (!ioctl_alt_or_warn(fd, HDIO_DRIVE_CMD, args1, WIN_PIDENTIFY))
+               if (!ioctl_alt_or_warn(HDIO_DRIVE_CMD, args1, WIN_PIDENTIFY))
                        identify((void *)(args1 + 4));
        }
 #endif
@@ -1865,11 +1897,11 @@ static void process_dev(char *devname)
                ioctl_or_warn(fd, BLKRRPART, NULL);
 
        if (do_ctimings)
-               do_time(0, fd); /* time cache */
+               do_time(1 /*,fd*/); /* time cache */
        if (do_timings)
-               do_time(1, fd); /* time device */
+               do_time(0 /*,fd*/); /* time device */
        if (do_flush)
-               flush_buffer_cache(fd);
+               flush_buffer_cache();
        close(fd);
 }
 
@@ -1883,6 +1915,7 @@ static int fromhex(unsigned char c)
        bb_error_msg_and_die("bad char: '%c' 0x%02x", c, c);
 }
 
+static void identify_from_stdin(void) ATTRIBUTE_NORETURN;
 static void identify_from_stdin(void)
 {
        uint16_t sbuf[256];
@@ -1904,6 +1937,8 @@ static void identify_from_stdin(void)
 
        identify(sbuf);
 }
+#else
+void identify_from_stdin(void);
 #endif
 
 /* busybox specific stuff */
@@ -1930,7 +1965,8 @@ static void parse_xfermode(int flag, smallint *get, smallint *set, int *value)
 }
 
 /*------- getopt short options --------*/
-static const char hdparm_options[] = "gfu::n::p:r::m::c::k::a::B:tTh"
+static const char hdparm_options[] ALIGN1 =
+       "gfu::n::p:r::m::c::k::a::B:tT"
        USE_FEATURE_HDPARM_GET_IDENTITY("iI")
        USE_FEATURE_HDPARM_HDIO_GETSET_DMA("d::")
 #ifdef HDIO_DRIVE_CMD
@@ -1950,7 +1986,7 @@ static const char hdparm_options[] = "gfu::n::p:r::m::c::k::a::B:tTh"
 /*-------------------------------------*/
 
 /* our main() routine: */
-int hdparm_main(int argc, char **argv);
+int hdparm_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
 int hdparm_main(int argc, char **argv)
 {
        int c;
@@ -1958,7 +1994,6 @@ int hdparm_main(int argc, char **argv)
 
        while ((c = getopt(argc, argv, hdparm_options)) >= 0) {
                flagcount++;
-               if (c == 'h') bb_show_usage(); /* EXIT */
                USE_FEATURE_HDPARM_GET_IDENTITY(get_IDentity |= (c == 'I'));
                USE_FEATURE_HDPARM_GET_IDENTITY(get_identity |= (c == 'i'));
                get_geom |= (c == 'g');
@@ -1976,7 +2011,7 @@ int hdparm_main(int argc, char **argv)
                do_flush |= do_timings |= (c == 't');
                do_flush |= do_ctimings |= (c == 'T');
 #ifdef HDIO_DRIVE_CMD
-               if (c == 'S') parse_opts(&get_standby, &set_standby, &standby_requested, 0, INT_MAX);
+               if (c == 'S') parse_opts(&get_standby, &set_standby, &standby_requested, 0, 255);
                if (c == 'D') parse_opts(&get_defects, &set_defects, &defects, 0, INT_MAX);
                if (c == 'P') parse_opts(&get_prefetch, &set_prefetch, &prefetch, 0, INT_MAX);
                parse_xfermode((c == 'X'), &get_xfermode, &set_xfermode, &xfermode_requested);
@@ -2024,7 +2059,7 @@ int hdparm_main(int argc, char **argv)
        if (!*argv) {
                if (ENABLE_FEATURE_HDPARM_GET_IDENTITY && !isatty(STDIN_FILENO))
                        identify_from_stdin(); /* EXIT */
-               else bb_show_usage();
+               bb_show_usage();
        }
 
        do {