getty: do not emit bogus error message on EOF

[oweals/busybox.git] / loginutils / chpasswd.c

diff --git a/loginutils/chpasswd.c b/loginutils/chpasswd.c
index 124fc86e24bca3d6c38974cdb8d5e9c946fa0738..18172316993d1d3f1f849e9943dd36543cfff0c6 100644 (file)
--- a/loginutils/chpasswd.c
+++ b/loginutils/chpasswd.c
@@ -5,51 +5,40 @@
  * Written for SLIND (from passwd.c) by Alexander Shishkin <virtuoso@slind.org>
  * Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
  */
-
 #include "libbb.h"
 
-#if ENABLE_GETOPT_LONG
-#include <getopt.h>
-
-static const struct option chpasswd_opts[] = {
-       { "encrypted", no_argument, NULL, 'e' },
-       { "md5", no_argument, NULL, 'm' },
-       { NULL, 0, NULL, 0 }
-};
+#if ENABLE_LONG_OPTS
+static const char chpasswd_longopts[] ALIGN1 =
+       "encrypted\0" No_argument "e"
+       "md5\0"       No_argument "m"
+       ;
 #endif
 
 #define OPT_ENC                1
 #define OPT_MD5                2
 
-int chpasswd_main(int argc, char **argv);
-int chpasswd_main(int argc, char **argv)
+int chpasswd_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
+int chpasswd_main(int argc UNUSED_PARAM, char **argv)
 {
        char *name, *pass;
        char salt[sizeof("$N$XXXXXXXX")];
        int opt, rc;
        int rnd = rnd; /* we *want* it to be non-initialized! */
-       const char *pwfile = bb_path_passwd_file;
 
-       if (getuid() != 0)
+       if (getuid())
                bb_error_msg_and_die(bb_msg_perm_denied_are_you_root);
 
-#if ENABLE_FEATURE_SHADOWPASSWDS
-       if (access(bb_path_shadow_file, F_OK) == 0)
-               pwfile = bb_path_shadow_file;
-#endif
-
-       opt_complementary = "m--e";
-       USE_GETOPT_LONG(applet_long_options = chpasswd_opts;)
-       opt = getopt32(argc, argv, "em");
+       opt_complementary = "m--e:e--m";
+       IF_LONG_OPTS(applet_long_options = chpasswd_longopts;)
+       opt = getopt32(argv, "em");
 
-       while ((name = xmalloc_getline(stdin)) != NULL) {
+       while ((name = xmalloc_fgetline(stdin)) != NULL) {
                pass = strchr(name, ':');
                if (!pass)
                        bb_error_msg_and_die("missing new password");
                *pass++ = '\0';
 
-               //if (!getpwnam(name))
-               //      bb_error_msg_and_die("unknown user %s", name);
+               xuname2uid(name); /* dies if there is no such user */
 
                if (!(opt & OPT_ENC)) {
                        rnd = crypt_make_salt(salt, 1, rnd);
@@ -57,21 +46,26 @@ int chpasswd_main(int argc, char **argv)
                                strcpy(salt, "$1$");
                                rnd = crypt_make_salt(salt + 3, 4, rnd);
                        }
-                       pass = pw_encrypt(pass, salt);
+                       pass = pw_encrypt(pass, salt, 0);
                }
 
-               rc = update_passwd(pwfile, name, pass);
-               /* LOGMODE_BOTH logs to syslog */
+               /* This is rather complex: if user is not found in /etc/shadow,
+                * we try to find & change his passwd in /etc/passwd */
+#if ENABLE_FEATURE_SHADOWPASSWDS
+               rc = update_passwd(bb_path_shadow_file, name, pass, NULL);
+               if (rc == 0) /* no lines updated, no errors detected */
+#endif
+                       rc = update_passwd(bb_path_passwd_file, name, pass, NULL);
+               /* LOGMODE_BOTH logs to syslog also */
                logmode = LOGMODE_BOTH;
                if (rc < 0)
-                       bb_error_msg_and_die("an error occurred updating %s", pwfile);
-               if (rc > 0)
+                       bb_error_msg_and_die("an error occurred updating password for %s", name);
+               if (rc)
                        bb_info_msg("Password for '%s' changed", name);
-               else
-                       bb_info_msg("User '%s' not found", name);
                logmode = LOGMODE_STDIO;
                free(name);
+               if (!(opt & OPT_ENC))
+                       free(pass);
        }
-
-       return 0;
+       return EXIT_SUCCESS;
 }