add/remove-shell,add/deluser,add/delgroup: make them NOEXEC
[oweals/busybox.git] / loginutils / add-remove-shell.c
index 750b44bd6b0e5b5cb272df874a3528b8b1327a75..6d03de254fc3f6a370205d0f8fe19d658406b03c 100644 (file)
@@ -19,9 +19,9 @@
 //config:      help
 //config:      Remove shells from /etc/shells.
 
-//                       APPLET_ODDNAME:name          main              location         suid_type     help
-//applet:IF_ADD_SHELL(   APPLET_ODDNAME(add-shell   , add_remove_shell, BB_DIR_USR_SBIN, BB_SUID_DROP, add_shell   ))
-//applet:IF_REMOVE_SHELL(APPLET_ODDNAME(remove-shell, add_remove_shell, BB_DIR_USR_SBIN, BB_SUID_DROP, remove_shell))
+//                       APPLET_NOEXEC:name          main              location         suid_type     help
+//applet:IF_ADD_SHELL(   APPLET_NOEXEC(add-shell   , add_remove_shell, BB_DIR_USR_SBIN, BB_SUID_DROP, add_shell   ))
+//applet:IF_REMOVE_SHELL(APPLET_NOEXEC(remove-shell, add_remove_shell, BB_DIR_USR_SBIN, BB_SUID_DROP, remove_shell))
 
 //kbuild:lib-$(CONFIG_ADD_SHELL)    += add-remove-shell.o
 //kbuild:lib-$(CONFIG_REMOVE_SHELL) += add-remove-shell.o
@@ -64,6 +64,7 @@ int add_remove_shell_main(int argc UNUSED_PARAM, char **argv)
        if (orig_fp)
                xfstat(fileno(orig_fp), &sb, orig_fn);
 
+
        new_fn = xasprintf("%s.tmp", orig_fn);
        /*
         * O_TRUNC or O_EXCL? At the first glance, O_EXCL looks better,