getty: fix for NOCTTY killing us with SIGHUP

[oweals/busybox.git] / libbb / verror_msg.c

diff --git a/libbb/verror_msg.c b/libbb/verror_msg.c
index dbd8323e43e132f5d179f55b170d809909d40be8..ee95be3e3aa574db7d72af2838b92c3c0d6ba971 100644 (file)
--- a/libbb/verror_msg.c
+++ b/libbb/verror_msg.c
@@ -4,18 +4,19 @@
  *
  * Copyright (C) 1999-2004 by Erik Andersen <andersen@codepoet.org>
  *
- * Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
+ * Licensed under GPLv2 or later, see file LICENSE in this source tree.
  */
-
-#include <syslog.h>
 #include "libbb.h"
+#if ENABLE_FEATURE_SYSLOG
+# include <syslog.h>
+#endif
 
 smallint logmode = LOGMODE_STDIO;
 const char *msg_eol = "\n";
 
-void bb_verror_msg(const char *s, va_list p, const char* strerr)
+void FAST_FUNC bb_verror_msg(const char *s, va_list p, const char* strerr)
 {
-       char *msg;
+       char *msg, *msg1;
        int applet_len, strerr_len, msgeol_len, used;
 
        if (!logmode)
@@ -36,41 +37,49 @@ void bb_verror_msg(const char *s, va_list p, const char* strerr)
        applet_len = strlen(applet_name) + 2; /* "applet: " */
        strerr_len = strerr ? strlen(strerr) : 0;
        msgeol_len = strlen(msg_eol);
+       /* can't use xrealloc: it calls error_msg on failure,
+        * that may result in a recursion */
        /* +3 is for ": " before strerr and for terminating NUL */
-       msg = xrealloc(msg, applet_len + used + strerr_len + msgeol_len + 3);
-       /* TODO: maybe use writev instead of memmoving? Need full_writev? */
-       memmove(msg + applet_len, msg, used);
-       used += applet_len;
-       strcpy(msg, applet_name);
-       msg[applet_len - 2] = ':';
-       msg[applet_len - 1] = ' ';
-       if (strerr) {
-               if (s[0]) { /* not perror_nomsg? */
-                       msg[used++] = ':';
-                       msg[used++] = ' ';
+       msg1 = realloc(msg, applet_len + used + strerr_len + msgeol_len + 3);
+       if (!msg1) {
+               msg[used++] = '\n'; /* overwrites NUL */
+               applet_len = 0;
+       } else {
+               msg = msg1;
+               /* TODO: maybe use writev instead of memmoving? Need full_writev? */
+               memmove(msg + applet_len, msg, used);
+               used += applet_len;
+               strcpy(msg, applet_name);
+               msg[applet_len - 2] = ':';
+               msg[applet_len - 1] = ' ';
+               if (strerr) {
+                       if (s[0]) { /* not perror_nomsg? */
+                               msg[used++] = ':';
+                               msg[used++] = ' ';
+                       }
+                       strcpy(&msg[used], strerr);
+                       used += strerr_len;
                }
-               strcpy(&msg[used], strerr);
-               used += strerr_len;
+               strcpy(&msg[used], msg_eol);
+               used += msgeol_len;
        }
-       strcpy(&msg[used], msg_eol);
 
        if (logmode & LOGMODE_STDIO) {
-               fflush(stdout);
-               full_write(2, msg, used + msgeol_len);
+               fflush_all();
+               full_write(STDERR_FILENO, msg, used);
        }
+#if ENABLE_FEATURE_SYSLOG
        if (logmode & LOGMODE_SYSLOG) {
                syslog(LOG_ERR, "%s", msg + applet_len);
        }
+#endif
        free(msg);
 }
 
-
 #ifdef VERSION_WITH_WRITEV
-
 /* Code size is approximately the same, but currently it's the only user
  * of writev in entire bbox. __libc_writev in uclibc is ~50 bytes. */
-
-void bb_verror_msg(const char *s, va_list p, const char* strerr)
+void FAST_FUNC bb_verror_msg(const char *s, va_list p, const char* strerr)
 {
        int strerr_len, msgeol_len;
        struct iovec iov[3];
@@ -116,12 +125,34 @@ void bb_verror_msg(const char *s, va_list p, const char* strerr)
                iov[1].iov_len = 2;
                /*iov[2].iov_base = msgc;*/
                /*iov[2].iov_len = used;*/
-               fflush(stdout);
-               writev(2, iov, 3);
+               fflush_all();
+               writev(STDERR_FILENO, iov, 3);
        }
+# if ENABLE_FEATURE_SYSLOG
        if (logmode & LOGMODE_SYSLOG) {
                syslog(LOG_ERR, "%s", msgc);
        }
+# endif
        free(msgc);
 }
 #endif
+
+
+void FAST_FUNC bb_error_msg_and_die(const char *s, ...)
+{
+       va_list p;
+
+       va_start(p, s);
+       bb_verror_msg(s, p, NULL);
+       va_end(p);
+       xfunc_die();
+}
+
+void FAST_FUNC bb_error_msg(const char *s, ...)
+{
+       va_list p;
+
+       va_start(p, s);
+       bb_verror_msg(s, p, NULL);
+       va_end(p);
+}