hush: correct exitcode for unterminated ')' - exitcode2.tests testcase

[oweals/busybox.git] / libbb / safe_strncpy.c

diff --git a/libbb/safe_strncpy.c b/libbb/safe_strncpy.c
index 8eb6a014fa2ee14d1fe89f458ac6ab215f6c7b6f..5eb0db0bd4c5732e47e94eadd94d0fa403525b33 100644 (file)
--- a/libbb/safe_strncpy.c
+++ b/libbb/safe_strncpy.c
@@ -20,8 +20,13 @@ char* FAST_FUNC safe_strncpy(char *dst, const char *src, size_t size)
 /* Like strcpy but can copy overlapping strings. */
 void FAST_FUNC overlapping_strcpy(char *dst, const char *src)
 {
-       while ((*dst = *src) != '\0') {
-               dst++;
-               src++;
+       /* Cheap optimization for dst == src case -
+        * better to have it here than in many callers.
+        */
+       if (dst != src) {
+               while ((*dst = *src) != '\0') {
+                       dst++;
+                       src++;
+               }
        }
 }