- don't free user-supplied string (via -e)

[oweals/busybox.git] / libbb / run_shell.c

diff --git a/libbb/run_shell.c b/libbb/run_shell.c
index d154b9852121b4b7eeb4ed6c4a3beb8ba1fa6533..2ccb3a12c7d4833efe007afc34f9f26fdd1e057b 100644 (file)
--- a/libbb/run_shell.c
+++ b/libbb/run_shell.c
@@ -28,53 +28,63 @@
  * SUCH DAMAGE.
  */
 
-#include <stdio.h>
-#include <errno.h>
-#include <unistd.h>
-#include <string.h>
-#include <stdlib.h>
-#include <syslog.h>
-#include <ctype.h>
 #include "libbb.h"
+#if ENABLE_SELINUX
+#include <selinux/selinux.h>  /* for setexeccon  */
+#endif
 
+#if ENABLE_SELINUX
+static security_context_t current_sid;
+
+void FAST_FUNC renew_current_security_context(void)
+{
+       freecon(current_sid);  /* Release old context  */
+       getcon(&current_sid);  /* update */
+}
+void FAST_FUNC set_current_security_context(security_context_t sid)
+{
+       freecon(current_sid);  /* Release old context  */
+       current_sid = sid;
+}
+
+#endif
 
 /* Run SHELL, or DEFAULT_SHELL if SHELL is empty.
    If COMMAND is nonzero, pass it to the shell with the -c option.
    If ADDITIONAL_ARGS is nonzero, pass it to the shell as more
    arguments.  */
 
-void run_shell ( const char *shell, int loginshell, const char *command, const char **additional_args )
+void FAST_FUNC run_shell(const char *shell, int loginshell, const char *command, const char **additional_args)
 {
        const char **args;
        int argno = 1;
        int additional_args_cnt = 0;
-       
-       for ( args = additional_args; args && *args; args++ )
+
+       for (args = additional_args; args && *args; args++)
                additional_args_cnt++;
 
-       if ( additional_args )
-               args = (const char **) xmalloc (sizeof (char *) * ( 4  + additional_args_cnt ));
-       else
-               args = (const char **) xmalloc (sizeof (char *) * 4 );
-               
-       args [0] = bb_get_last_path_component ( bb_xstrdup ( shell ));
-       
-       if ( loginshell ) {
-               char *args0;
-               bb_xasprintf ( &args0, "-%s", args [0] );
-               args [0] = args0;
-       }
-    
-       if ( command ) {
-               args [argno++] = "-c";
-               args [argno++] = command;
+       args = xmalloc(sizeof(char*) * (4 + additional_args_cnt));
+
+       args[0] = bb_get_last_path_component_nostrip(xstrdup(shell));
+
+       if (loginshell)
+               args[0] = xasprintf("-%s", args[0]);
+
+       if (command) {
+               args[argno++] = "-c";
+               args[argno++] = command;
        }
-       if ( additional_args ) {
-               for ( ; *additional_args; ++additional_args )
-                       args [argno++] = *additional_args;
+       if (additional_args) {
+               for (; *additional_args; ++additional_args)
+                       args[argno++] = *additional_args;
        }
-       args [argno] = 0;
-       execv ( shell, (char **) args );
-       bb_perror_msg_and_die ( "cannot run %s", shell );
+       args[argno] = NULL;
+#if ENABLE_SELINUX
+       if (current_sid)
+               setexeccon(current_sid);
+       if (ENABLE_FEATURE_CLEAN_UP)
+               freecon(current_sid);
+#endif
+       execv(shell, (char **) args);
+       bb_perror_msg_and_die("cannot run %s", shell);
 }
-