fix printf warning

[oweals/busybox.git] / libbb / run_parts.c

diff --git a/libbb/run_parts.c b/libbb/run_parts.c
index 58645660b0a68650d418a36fe42387626df48659..4c8841fe597bd9ba2aeb33c7ef7ac7e31fbae415 100644 (file)
--- a/libbb/run_parts.c
+++ b/libbb/run_parts.c
@@ -43,11 +43,11 @@ static int valid_name(const struct dirent *d)
        return 1;
 }
 
-/* test mode = 1 is the same as offical run_parts
- * test_mode = 2 means to fail siliently on missing directories
+/* test mode = 1 is the same as official run_parts
+ * test_mode = 2 means to fail silently on missing directories
  */
 
-extern int run_parts(char **args, const unsigned char test_mode)
+extern int run_parts(char **args, const unsigned char test_mode, char **env)
 {
        struct dirent **namelist = 0;
        struct stat st;
@@ -80,7 +80,7 @@ extern int run_parts(char **args, const unsigned char test_mode)
                        bb_perror_msg_and_die("failed to stat component %s", filename);
                }
                if (S_ISREG(st.st_mode) && !access(filename, X_OK)) {
-                       if (test_mode & 1) {
+                       if (test_mode) {
                                puts(filename);
                        } else {
                                /* exec_errno is common vfork variable */
@@ -92,7 +92,7 @@ extern int run_parts(char **args, const unsigned char test_mode)
                                        bb_perror_msg_and_die("failed to fork");
                                } else if (!pid) {
                                        args[0] = filename;
-                                       execv(filename, args);
+                                       execve(filename, args, env);
                                        exec_errno = errno;
                                        _exit(1);
                                }
@@ -100,7 +100,8 @@ extern int run_parts(char **args, const unsigned char test_mode)
                                waitpid(pid, &result, 0);
                                if(exec_errno) {
                                        errno = exec_errno;
-                                       bb_perror_msg_and_die("failed to exec %s", filename);
+                                       bb_perror_msg("failed to exec %s", filename);
+                                       exitstatus = 1;
                                }
                                if (WIFEXITED(result) && WEXITSTATUS(result)) {
                                        bb_perror_msg("%s exited with return code %d", filename, WEXITSTATUS(result));
@@ -110,7 +111,7 @@ extern int run_parts(char **args, const unsigned char test_mode)
                                        exitstatus = 1;
                                }
                        }
-               } 
+               }
                else if (!S_ISDIR(st.st_mode)) {
                        bb_error_msg("component %s is not an executable plain file", filename);
                        exitstatus = 1;
@@ -120,6 +121,6 @@ extern int run_parts(char **args, const unsigned char test_mode)
                free(filename);
        }
        free(namelist);
-       
+
        return(exitstatus);
 }