libbb/md5: code shrink

[oweals/busybox.git] / libbb / pidfile.c

diff --git a/libbb/pidfile.c b/libbb/pidfile.c
index 79c3108fc20c1f9ff2361fc937e624333c9d231b..a48dfc38b2c8f2a02c99bd42650b79bbcab867d4 100644 (file)
--- a/libbb/pidfile.c
+++ b/libbb/pidfile.c
@@ -4,26 +4,37 @@
  *
  * Copyright (C) 2007 by Stephane Billiart <stephane.billiart@gmail.com>
  *
- * Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
+ * Licensed under GPLv2 or later, see file LICENSE in this source tree.
  */
+
+/* Override ENABLE_FEATURE_PIDFILE */
+#define WANT_PIDFILE 1
 #include "libbb.h"
 
-#if ENABLE_FEATURE_PIDFILE
-int write_pidfile(const char *path)
+smallint wrote_pidfile;
+
+void FAST_FUNC write_pidfile(const char *path)
 {
        int pid_fd;
        char *end;
        char buf[sizeof(int)*3 + 2];
+       struct stat sb;
 
+       if (!path)
+               return;
        /* we will overwrite stale pidfile */
        pid_fd = open(path, O_WRONLY|O_CREAT|O_TRUNC, 0666);
        if (pid_fd < 0)
-               return 0;
-       /* few bytes larger, but doesn't use stdio */
-       end = utoa_to_buf(getpid(), buf, sizeof(buf));
-       end[0] = '\n';
-       full_write(pid_fd, buf, end - buf + 1);
+               return;
+
+       /* path can be "/dev/null"! Test for such cases */
+       wrote_pidfile = (fstat(pid_fd, &sb) == 0) && S_ISREG(sb.st_mode);
+
+       if (wrote_pidfile) {
+               /* few bytes larger, but doesn't use stdio */
+               end = utoa_to_buf(getpid(), buf, sizeof(buf));
+               *end = '\n';
+               full_write(pid_fd, buf, end - buf + 1);
+       }
        close(pid_fd);
-       return 1;
 }
-#endif