Fix a memory leak if parent directory creation failed.

[oweals/busybox.git] / libbb / gz_open.c

diff --git a/libbb/gz_open.c b/libbb/gz_open.c
index 19ec0a066fded86f9eb7605f592898881ca59e0c..ef30ff8945b500149490e1be187674908dd74e79 100644 (file)
--- a/libbb/gz_open.c
+++ b/libbb/gz_open.c
@@ -6,17 +6,17 @@
 #include <unistd.h>
 #include "libbb.h"
 
-extern int gz_open(FILE *compressed_file, int *pid)
+extern FILE *gz_open(FILE *compressed_file, int *pid)
 {
        int unzip_pipe[2];
 
        if (pipe(unzip_pipe)!=0) {
                error_msg("pipe error");
-               return(EXIT_FAILURE);
+               return(NULL);
        }
        if ((*pid = fork()) == -1) {
-               error_msg("fork failured");
-               return(EXIT_FAILURE);
+               error_msg("fork failed");
+               return(NULL);
        }
        if (*pid==0) {
                /* child process */
@@ -27,7 +27,9 @@ extern int gz_open(FILE *compressed_file, int *pid)
                close(unzip_pipe[1]);
                exit(EXIT_SUCCESS);
        }
-       
        close(unzip_pipe[1]);
-       return(unzip_pipe[0]);
-}
\ No newline at end of file
+       if (unzip_pipe[0] == -1) {
+               error_msg("gzip stream init failed");
+       }
+       return(fdopen(unzip_pipe[0], "r"));
+}