remove casts from xmalloc()

[oweals/busybox.git] / libbb / get_line_from_file.c

diff --git a/libbb/get_line_from_file.c b/libbb/get_line_from_file.c
index 722a904b52cd06595808e533960b9c3e2ad5fc54..3f2c6096eefde5ce4d42b2ca244e4a1715c16415 100644 (file)
--- a/libbb/get_line_from_file.c
+++ b/libbb/get_line_from_file.c
@@ -9,12 +9,10 @@
  * Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
  */
 
-#include <stdio.h>
-#include <stdlib.h>
 #include "libbb.h"
 
-/* get_line_from_file() - This function reads an entire line from a text file,
- * up to a newline or NUL byte.  It returns a malloc'ed char * which must be
+/* This function reads an entire line from a text file, up to a newline 
+ * or NUL byte, inclusive.  It returns a malloc'ed char * which must be
  * stored and free'ed  by the caller.  If end is null '\n' isn't considered
  * end of line.  If end isn't null, length of the chunk read is stored in it. */
 
@@ -27,7 +25,7 @@ char *bb_get_chunk_from_file(FILE * file, int *end)
 
        while ((ch = getc(file)) != EOF) {
                /* grow the line buffer as necessary */
-               if (idx > linebufsz - 2) {
+               if (idx >= linebufsz) {
                        linebuf = xrealloc(linebuf, linebufsz += 80);
                }
                linebuf[idx++] = (char) ch;
@@ -37,18 +35,20 @@ char *bb_get_chunk_from_file(FILE * file, int *end)
        if (end)
                *end = idx;
        if (linebuf) {
-               if (ferror(file)) {
-                       free(linebuf);
-                       return NULL;
-               }
+               // huh, does fgets discard prior data on error like this?
+               // I don't think so....
+               //if (ferror(file)) {
+               //      free(linebuf);
+               //      return NULL;
+               //}
                linebuf = xrealloc(linebuf, idx+1);
-               linebuf[idx] = 0;
+               linebuf[idx] = '\0';
        }
        return linebuf;
 }
 
 /* Get line, including trailing \n if any */
-char *bb_get_line_from_file(FILE * file)
+char *xmalloc_fgets(FILE * file)
 {
        int i;
 
@@ -56,7 +56,7 @@ char *bb_get_line_from_file(FILE * file)
 }
 
 /* Get line.  Remove trailing \n */
-char *bb_get_chomped_line_from_file(FILE * file)
+char *xmalloc_getline(FILE * file)
 {
        int i;
        char *c = bb_get_chunk_from_file(file, &i);