bootm: refactor ramdisk locating code
[oweals/u-boot.git] / lib_ppc / bootm.c
index 59cc2a44718ebf83c9d9a60c58f3660c65d6d5b4..e6a6e4461d4b28cfb801bc5bf63f75a436266713 100644 (file)
@@ -23,7 +23,6 @@
  * MA 02111-1307 USA
  */
 
-#define DEBUG
 
 #include <common.h>
 #include <watchdog.h>
@@ -41,9 +40,9 @@
 #include <fdt_support.h>
 
 static void fdt_error (const char *msg);
-static int get_fdt (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
+static int boot_get_fdt (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                bootm_headers_t *images, char **of_flat_tree, ulong *of_size);
-static int fdt_relocate (struct lmb *lmb, ulong bootmap_base,
+static int boot_relocate_fdt (struct lmb *lmb, ulong bootmap_base,
                cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                char **of_flat_tree, ulong *of_size);
 #endif
@@ -52,6 +51,10 @@ static int fdt_relocate (struct lmb *lmb, ulong bootmap_base,
 #include <asm/cache.h>
 #endif
 
+#ifndef CFG_FDT_PAD
+#define CFG_FDT_PAD 0x3000
+#endif
+
 DECLARE_GLOBAL_DATA_PTR;
 
 extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]);
@@ -70,13 +73,14 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
        ulong   sp;
 
        ulong   initrd_start, initrd_end;
-       ulong   rd_data_start, rd_data_end, rd_len;
+       ulong   rd_len;
        ulong   size;
+       phys_size_t bootm_size;
 
        ulong   cmd_start, cmd_end, bootmap_base;
        bd_t    *kbd;
-       ulong   ep = 0;
-       void    (*kernel)(bd_t *, ulong, ulong, ulong, ulong);
+       void    (*kernel)(bd_t *, ulong r4, ulong r5, ulong r6,
+                         ulong r7, ulong r8, ulong r9);
        int     ret;
        ulong   of_size = 0;
        struct lmb *lmb = images->lmb;
@@ -85,23 +89,27 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
        char    *of_flat_tree = NULL;
 #endif
 
+       kernel = (void (*)(bd_t *, ulong, ulong, ulong,
+                          ulong, ulong, ulong))images->ep;
+
        bootmap_base = getenv_bootm_low();
-       size = getenv_bootm_size();
+       bootm_size = getenv_bootm_size();
 
 #ifdef DEBUG
-       if (((u64)bootmap_base + size) > (CFG_SDRAM_BASE + (u64)gd->ram_size))
+       if (((u64)bootmap_base + bootm_size) >
+           (CFG_SDRAM_BASE + (u64)gd->ram_size))
                puts("WARNING: bootm_low + bootm_size exceed total memory\n");
-       if ((bootmap_base + size) > get_effective_memsize())
+       if ((bootmap_base + bootm_size) > get_effective_memsize())
                puts("WARNING: bootm_low + bootm_size exceed eff. memory\n");
 #endif
 
-       size = min(size, get_effective_memsize());
+       size = min(bootm_size, get_effective_memsize());
        size = min(size, CFG_LINUX_LOWMEM_MAX_SIZE);
 
-       if (size < getenv_bootm_size()) {
+       if (size < bootm_size) {
                ulong base = bootmap_base + size;
-               printf("WARNING: adjusting available memory to %x\n", size);
-               lmb_reserve(lmb, base, getenv_bootm_size() - size);
+               printf("WARNING: adjusting available memory to %lx\n", size);
+               lmb_reserve(lmb, base, bootm_size - size);
        }
 
        /*
@@ -122,7 +130,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
 
 #if defined(CONFIG_OF_LIBFDT)
        /* find flattened device tree */
-       ret = get_fdt (cmdtp, flag, argc, argv, images, &of_flat_tree, &of_size);
+       ret = boot_get_fdt (cmdtp, flag, argc, argv, images, &of_flat_tree, &of_size);
 
        if (ret)
                goto error;
@@ -130,14 +138,14 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
 
        if (!of_size) {
                /* allocate space and init command line */
-               ret = get_boot_cmdline (lmb, &cmd_start, &cmd_end, bootmap_base);
+               ret = boot_get_cmdline (lmb, &cmd_start, &cmd_end, bootmap_base);
                if (ret) {
                        puts("ERROR with allocation of cmdline\n");
                        goto error;
                }
 
                /* allocate space for kernel copy of board info */
-               ret = get_boot_kbd (lmb, &kbd, bootmap_base);
+               ret = boot_get_kbd (lmb, &kbd, bootmap_base);
                if (ret) {
                        puts("ERROR with allocation of kernel bd\n");
                        goto error;
@@ -145,31 +153,10 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                set_clocks_in_mhz(kbd);
        }
 
-       /* find kernel entry point */
-       if (images->legacy_hdr_valid) {
-               ep = image_get_ep (images->legacy_hdr_os);
-#if defined(CONFIG_FIT)
-       } else if (images->fit_uname_os) {
-               fit_unsupported_reset ("PPC linux bootm");
-               goto error;
-#endif
-       } else {
-               puts ("Could not find kernel entry point!\n");
-               goto error;
-       }
-       kernel = (void (*)(bd_t *, ulong, ulong, ulong, ulong))ep;
-
-       /* find ramdisk */
-       ret = get_ramdisk (cmdtp, flag, argc, argv, images,
-                       IH_ARCH_PPC, &rd_data_start, &rd_data_end);
-
-       if (ret)
-               goto error;
-
-       rd_len = rd_data_end - rd_data_start;
+       rd_len = images->rd_end - images->rd_start;
 
 #if defined(CONFIG_OF_LIBFDT)
-       ret = fdt_relocate (lmb, bootmap_base,
+       ret = boot_relocate_fdt (lmb, bootmap_base,
                cmdtp, flag, argc, argv, &of_flat_tree, &of_size);
 
        /*
@@ -178,30 +165,57 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
         */
        if (of_size) {
                /* pass in dummy initrd info, we'll fix up later */
-               if (fdt_chosen(of_flat_tree, rd_data_start, rd_data_end, 0) < 0) {
+               if (fdt_chosen(of_flat_tree, images->rd_start, images->rd_end, 0) < 0) {
                        fdt_error ("/chosen node create failed");
                        goto error;
                }
-#ifdef CONFIG_OF_HAS_UBOOT_ENV
-               if (fdt_env(of_flat_tree) < 0) {
-                       fdt_error ("/u-boot-env node create failed");
-                       goto error;
-               }
-#endif
-#ifdef CONFIG_OF_HAS_BD_T
-               if (fdt_bd_t(of_flat_tree) < 0) {
-                       fdt_error ("/bd_t node create failed");
-                       goto error;
-               }
-#endif
 #ifdef CONFIG_OF_BOARD_SETUP
                /* Call the board-specific fixup routine */
                ft_board_setup(of_flat_tree, gd->bd);
 #endif
        }
+
+       /* Fixup the fdt memreserve now that we know how big it is */
+       if (of_flat_tree) {
+               int j;
+               uint64_t addr, size;
+               int total = fdt_num_mem_rsv(of_flat_tree);
+               uint actualsize;
+
+               for (j = 0; j < total; j++) {
+                       fdt_get_mem_rsv(of_flat_tree, j, &addr, &size);
+                       if (addr == (uint64_t)(u32)of_flat_tree) {
+                               fdt_del_mem_rsv(of_flat_tree, j);
+                               break;
+                       }
+               }
+
+               /* Delete the old LMB reservation */
+               lmb_free(lmb, (phys_addr_t)(u32)of_flat_tree,
+                               (phys_size_t)fdt_totalsize(of_flat_tree));
+
+               /* Calculate the actual size of the fdt */
+               actualsize = fdt_off_dt_strings(of_flat_tree) +
+                       fdt_size_dt_strings(of_flat_tree);
+
+               /* Make it so the fdt ends on a page boundary */
+               actualsize = ALIGN(actualsize, 0x1000);
+               actualsize = actualsize - ((uint)of_flat_tree & 0xfff);
+
+               /* Change the fdt header to reflect the correct size */
+               fdt_set_totalsize(of_flat_tree, actualsize);
+               of_size = actualsize;
+
+               /* Add the new reservation */
+               ret = fdt_add_mem_rsv(of_flat_tree, (uint)of_flat_tree,
+                               of_size);
+
+               /* Create a new LMB reservation */
+               lmb_reserve(lmb, (ulong)of_flat_tree, of_size);
+       }
 #endif /* CONFIG_OF_LIBFDT */
 
-       ret = ramdisk_high (lmb, rd_data_start, rd_len, &initrd_start, &initrd_end);
+       ret = boot_ramdisk_high (lmb, images->rd_start, rd_len, &initrd_start, &initrd_end);
        if (ret)
                goto error;
 
@@ -215,7 +229,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                /* Look for the dummy entry and delete it */
                for (j = 0; j < total; j++) {
                        fdt_get_mem_rsv(of_flat_tree, j, &addr, &size);
-                       if (addr == rd_data_start) {
+                       if (addr == images->rd_start) {
                                fdt_del_mem_rsv(of_flat_tree, j);
                                break;
                        }
@@ -247,26 +261,42 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
        if (of_flat_tree) {     /* device tree; boot new style */
                /*
                 * Linux Kernel Parameters (passing device tree):
-                *   r3: pointer to the fdt, followed by the board info data
-                *   r4: physical pointer to the kernel itself
-                *   r5: NULL
-                *   r6: NULL
-                *   r7: NULL
+                *   r3: pointer to the fdt
+                *   r4: 0
+                *   r5: 0
+                *   r6: epapr magic
+                *   r7: size of IMA in bytes
+                *   r8: 0
+                *   r9: 0
                 */
-               (*kernel) ((bd_t *)of_flat_tree, (ulong)kernel, 0, 0, 0);
+#if defined(CONFIG_85xx) || defined(CONFIG_440)
+ #define EPAPR_MAGIC   (0x45504150)
+#else
+ #define EPAPR_MAGIC   (0x65504150)
+#endif
+
+               debug ("   Booting using OF flat tree...\n");
+               (*kernel) ((bd_t *)of_flat_tree, 0, 0, EPAPR_MAGIC,
+                          CFG_BOOTMAPSZ, 0, 0);
                /* does not return */
-       }
+       } else
 #endif
-       /*
-        * Linux Kernel Parameters (passing board info data):
-        *   r3: ptr to board info data
-        *   r4: initrd_start or 0 if no initrd
-        *   r5: initrd_end - unused if r4 is 0
-        *   r6: Start of command line string
-        *   r7: End   of command line string
-        */
-       (*kernel) (kbd, initrd_start, initrd_end, cmd_start, cmd_end);
-       /* does not return */
+       {
+               /*
+                * Linux Kernel Parameters (passing board info data):
+                *   r3: ptr to board info data
+                *   r4: initrd_start or 0 if no initrd
+                *   r5: initrd_end - unused if r4 is 0
+                *   r6: Start of command line string
+                *   r7: End   of command line string
+                *   r8: 0
+                *   r9: 0
+                */
+               debug ("   Booting using board info...\n");
+               (*kernel) (kbd, initrd_start, initrd_end,
+                          cmd_start, cmd_end, 0, 0);
+               /* does not return */
+       }
        return ;
 
 error:
@@ -301,7 +331,7 @@ static void set_clocks_in_mhz (bd_t *kbd)
                kbd->bi_cpmfreq /= 1000000L;
                kbd->bi_brgfreq /= 1000000L;
                kbd->bi_sccfreq /= 1000000L;
-               kbd->bi_vco     /= 1000000L;
+               kbd->bi_vco     /= 1000000L;
 #endif
 #if defined(CONFIG_MPC5xxx)
                kbd->bi_ipbfreq /= 1000000L;
@@ -351,7 +381,48 @@ static image_header_t *image_get_fdt (ulong fdt_addr)
        return fdt_hdr;
 }
 
-static int get_fdt (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
+/**
+ * fit_check_fdt - verify FIT format FDT subimage
+ * @fit_hdr: pointer to the FIT  header
+ * fdt_noffset: FDT subimage node offset within FIT image
+ * @verify: data CRC verification flag
+ *
+ * fit_check_fdt() verifies integrity of the FDT subimage and from
+ * specified FIT image.
+ *
+ * returns:
+ *     1, on success
+ *     0, on failure
+ */
+#if defined(CONFIG_FIT)
+static int fit_check_fdt (const void *fit, int fdt_noffset, int verify)
+{
+       fit_image_print (fit, fdt_noffset, "   ");
+
+       if (verify) {
+               puts ("   Verifying Hash Integrity ... ");
+               if (!fit_image_check_hashes (fit, fdt_noffset)) {
+                       fdt_error ("Bad Data Hash");
+                       return 0;
+               }
+               puts ("OK\n");
+       }
+
+       if (!fit_image_check_type (fit, fdt_noffset, IH_TYPE_FLATDT)) {
+               fdt_error ("Not a FDT image");
+               return 0;
+       }
+
+       if (!fit_image_check_comp (fit, fdt_noffset, IH_COMP_NONE)) {
+               fdt_error ("FDT image is compressed");
+               return 0;
+       }
+
+       return 1;
+}
+#endif /* CONFIG_FIT */
+
+static int boot_get_fdt (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                bootm_headers_t *images, char **of_flat_tree, ulong *of_size)
 {
        ulong           fdt_addr;
@@ -360,59 +431,96 @@ static int get_fdt (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
        ulong           image_start, image_end;
        ulong           load_start, load_end;
 #if defined(CONFIG_FIT)
-        void            *fit_hdr;
-        const char      *fit_uname_config = NULL;
-        const char      *fit_uname_fdt = NULL;
+       void            *fit_hdr;
+       const char      *fit_uname_config = NULL;
+       const char      *fit_uname_fdt = NULL;
        ulong           default_addr;
+       int             cfg_noffset;
+       int             fdt_noffset;
+       const void      *data;
+       size_t          size;
 #endif
 
-       if (argc > 3) {
+       *of_flat_tree = NULL;
+       *of_size = 0;
+
+       if (argc > 3 || genimg_has_config (images)) {
 #if defined(CONFIG_FIT)
-               /*
-                * If the FDT blob comes from the FIT image and the FIT image
-                * address is omitted in the command line argument, try to use
-                * ramdisk or os FIT image address or default load address.
-                */
-               if (images->fit_uname_rd)
-                       default_addr = (ulong)images->fit_hdr_rd;
-               else if (images->fit_uname_os)
-                       default_addr = (ulong)images->fit_hdr_os;
-               else
-                       default_addr = load_addr;
-
-               if (fit_parse_conf (argv[3], default_addr,
-                                       &fdt_addr, &fit_uname_config)) {
-                       debug ("*  fdt: config '%s' from image at 0x%08lx\n",
-                                       fit_uname_config, fdt_addr);
-               } else if (fit_parse_subimage (argv[3], default_addr,
-                                       &fdt_addr, &fit_uname_fdt)) {
-                       debug ("*  fdt: subimage '%s' from image at 0x%08lx\n",
-                                       fit_uname_fdt, fdt_addr);
-               } else
+               if (argc > 3) {
+                       /*
+                        * If the FDT blob comes from the FIT image and the
+                        * FIT image address is omitted in the command line
+                        * argument, try to use ramdisk or os FIT image
+                        * address or default load address.
+                        */
+                       if (images->fit_uname_rd)
+                               default_addr = (ulong)images->fit_hdr_rd;
+                       else if (images->fit_uname_os)
+                               default_addr = (ulong)images->fit_hdr_os;
+                       else
+                               default_addr = load_addr;
+
+                       if (fit_parse_conf (argv[3], default_addr,
+                                               &fdt_addr, &fit_uname_config)) {
+                               debug ("*  fdt: config '%s' from image at 0x%08lx\n",
+                                               fit_uname_config, fdt_addr);
+                       } else if (fit_parse_subimage (argv[3], default_addr,
+                                               &fdt_addr, &fit_uname_fdt)) {
+                               debug ("*  fdt: subimage '%s' from image at 0x%08lx\n",
+                                               fit_uname_fdt, fdt_addr);
+                       } else
 #endif
-               {
-                       fdt_addr = simple_strtoul(argv[3], NULL, 16);
-                       debug ("*  fdt: cmdline image address = 0x%08lx\n",
-                                       fdt_addr);
+                       {
+                               fdt_addr = simple_strtoul(argv[3], NULL, 16);
+                               debug ("*  fdt: cmdline image address = 0x%08lx\n",
+                                               fdt_addr);
+                       }
+#if defined(CONFIG_FIT)
+               } else {
+                       /* use FIT configuration provided in first bootm
+                        * command argument
+                        */
+                       fdt_addr = (ulong)images->fit_hdr_os;
+                       fit_uname_config = images->fit_uname_cfg;
+                       debug ("*  fdt: using config '%s' from image at 0x%08lx\n",
+                                       fit_uname_config, fdt_addr);
+
+                       /*
+                        * Check whether configuration has FDT blob defined,
+                        * if not quit silently.
+                        */
+                       fit_hdr = (void *)fdt_addr;
+                       cfg_noffset = fit_conf_get_node (fit_hdr,
+                                       fit_uname_config);
+                       if (cfg_noffset < 0) {
+                               debug ("*  fdt: no such config\n");
+                               return 0;
+                       }
+
+                       fdt_noffset = fit_conf_get_fdt_node (fit_hdr,
+                                       cfg_noffset);
+                       if (fdt_noffset < 0) {
+                               debug ("*  fdt: no fdt in config\n");
+                               return 0;
+                       }
                }
+#endif
 
-               debug ("## Checking for 'FDT'/'FDT image' at %08lx\n",
+               debug ("## Checking for 'FDT'/'FDT Image' at %08lx\n",
                                fdt_addr);
 
                /* copy from dataflash if needed */
-               fdt_addr = gen_get_image (fdt_addr);
+               fdt_addr = genimg_get_image (fdt_addr);
 
                /*
                 * Check if there is an FDT image at the
                 * address provided in the second bootm argument
                 * check image type, for FIT images get a FIT node.
                 */
-               switch (gen_image_get_format ((void *)fdt_addr)) {
+               switch (genimg_get_format ((void *)fdt_addr)) {
                case IMAGE_FORMAT_LEGACY:
-                       debug ("*  fdt: legacy format image\n");
-
                        /* verify fdt_addr points to a valid image header */
-                       printf ("## Flattened Device Tree Legacy Image at %08lx\n",
+                       printf ("## Flattened Device Tree from Legacy Image at %08lx\n",
                                        fdt_addr);
                        fdt_hdr = image_get_fdt (fdt_addr);
                        if (!fdt_hdr)
@@ -432,11 +540,15 @@ static int get_fdt (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                                fdt_error ("fdt overwritten");
                                goto error;
                        }
-                       memmove ((void *)image_get_load (fdt_hdr),
+
+                       debug ("   Loading FDT from 0x%08lx to 0x%08lx\n",
+                                       image_get_data (fdt_hdr), load_start);
+
+                       memmove ((void *)load_start,
                                        (void *)image_get_data (fdt_hdr),
                                        image_get_data_size (fdt_hdr));
 
-                       fdt_blob = (char *)image_get_load (fdt_hdr);
+                       fdt_blob = (char *)load_start;
                        break;
                case IMAGE_FORMAT_FIT:
                        /*
@@ -446,23 +558,110 @@ static int get_fdt (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                         */
 #if defined(CONFIG_FIT)
                        /* check FDT blob vs FIT blob */
-                       if (0) { /* FIXME: call FIT format verification */
+                       if (fit_check_format ((const void *)fdt_addr)) {
                                /*
                                 * FIT image
                                 */
                                fit_hdr = (void *)fdt_addr;
-                               debug ("*  fdt: FIT format image\n");
-                               fit_unsupported_reset ("PPC fdt");
-                               goto error;
+                               printf ("## Flattened Device Tree from FIT Image at %08lx\n",
+                                               fdt_addr);
+
+                               if (!fit_uname_fdt) {
+                                       /*
+                                        * no FDT blob image node unit name,
+                                        * try to get config node first. If
+                                        * config unit node name is NULL
+                                        * fit_conf_get_node() will try to
+                                        * find default config node
+                                        */
+                                       cfg_noffset = fit_conf_get_node (fit_hdr,
+                                                       fit_uname_config);
+
+                                       if (cfg_noffset < 0) {
+                                               fdt_error ("Could not find configuration node\n");
+                                               goto error;
+                                       }
+
+                                       fit_uname_config = fdt_get_name (fit_hdr,
+                                                       cfg_noffset, NULL);
+                                       printf ("   Using '%s' configuration\n",
+                                                       fit_uname_config);
+
+                                       fdt_noffset = fit_conf_get_fdt_node (fit_hdr,
+                                                       cfg_noffset);
+                                       fit_uname_fdt = fit_get_name (fit_hdr,
+                                                       fdt_noffset, NULL);
+                               } else {
+                                       /* get FDT component image node offset */
+                                       fdt_noffset = fit_image_get_node (fit_hdr,
+                                                       fit_uname_fdt);
+                               }
+                               if (fdt_noffset < 0) {
+                                       fdt_error ("Could not find subimage node\n");
+                                       goto error;
+                               }
+
+                               printf ("   Trying '%s' FDT blob subimage\n",
+                                               fit_uname_fdt);
+
+                               if (!fit_check_fdt (fit_hdr, fdt_noffset,
+                                                       images->verify))
+                                       goto error;
+
+                               /* get ramdisk image data address and length */
+                               if (fit_image_get_data (fit_hdr, fdt_noffset,
+                                                       &data, &size)) {
+                                       fdt_error ("Could not find FDT subimage data");
+                                       goto error;
+                               }
+
+                               /* verift that image data is a proper FDT blob */
+                               if (fdt_check_header ((char *)data) != 0) {
+                                       fdt_error ("Subimage data is not a FTD");
+                                       goto error;
+                               }
+
+                               /*
+                                * move image data to the load address,
+                                * make sure we don't overwrite initial image
+                                */
+                               image_start = (ulong)fit_hdr;
+                               image_end = fit_get_end (fit_hdr);
+
+                               if (fit_image_get_load (fit_hdr, fdt_noffset,
+                                                       &load_start) == 0) {
+                                       load_end = load_start + size;
+
+                                       if ((load_start < image_end) &&
+                                                       (load_end > image_start)) {
+                                               fdt_error ("FDT overwritten");
+                                               goto error;
+                                       }
+
+                                       printf ("   Loading FDT from 0x%08lx to 0x%08lx\n",
+                                                       (ulong)data, load_start);
+
+                                       memmove ((void *)load_start,
+                                                       (void *)data, size);
+
+                                       fdt_blob = (char *)load_start;
+                               } else {
+                                       fdt_blob = (char *)data;
+                               }
+
+                               images->fit_hdr_fdt = fit_hdr;
+                               images->fit_uname_fdt = fit_uname_fdt;
+                               images->fit_noffset_fdt = fdt_noffset;
+                               break;
                        } else
 #endif
                        {
                                /*
                                 * FDT blob
                                 */
-                               debug ("*  fdt: raw FDT blob\n");
-                               printf ("## Flattened Device Tree blob at %08lx\n", fdt_blob);
                                fdt_blob = (char *)fdt_addr;
+                               debug ("*  fdt: raw FDT blob\n");
+                               printf ("## Flattened Device Tree blob at %08lx\n", (long)fdt_blob);
                        }
                        break;
                default:
@@ -470,10 +669,10 @@ static int get_fdt (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                        goto error;
                }
 
-               printf ("   Booting using the fdt blob at 0x%x\n", fdt_blob);
+               printf ("   Booting using the fdt blob at 0x%x\n", (int)fdt_blob);
 
        } else if (images->legacy_hdr_valid &&
-                       image_check_type (images->legacy_hdr_os, IH_TYPE_MULTI)) {
+                       image_check_type (&images->legacy_hdr_os_copy, IH_TYPE_MULTI)) {
 
                ulong fdt_data, fdt_len;
 
@@ -489,7 +688,7 @@ static int get_fdt (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                if (fdt_len) {
 
                        fdt_blob = (char *)fdt_data;
-                       printf ("   Booting using the fdt at 0x%x\n", fdt_blob);
+                       printf ("   Booting using the fdt at 0x%x\n", (int)fdt_blob);
 
                        if (fdt_check_header (fdt_blob) != 0) {
                                fdt_error ("image is not a fdt");
@@ -501,14 +700,11 @@ static int get_fdt (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                                goto error;
                        }
                } else {
-                       fdt_error ("Did not find a Flattened Device Tree "
-                               "in a legacy multi-component image");
-                       goto error;
+                       debug ("## No Flattened Device Tree\n");
+                       return 0;
                }
        } else {
                debug ("## No Flattened Device Tree\n");
-               *of_flat_tree = NULL;
-               *of_size = 0;
                return 0;
        }
 
@@ -524,7 +720,7 @@ error:
        return 1;
 }
 
-static int fdt_relocate (struct lmb *lmb, ulong bootmap_base,
+static int boot_relocate_fdt (struct lmb *lmb, ulong bootmap_base,
                cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
                char **of_flat_tree, ulong *of_size)
 {
@@ -548,22 +744,25 @@ static int fdt_relocate (struct lmb *lmb, ulong bootmap_base,
 #endif
 
        /*
-        * The blob must be within CFG_BOOTMAPSZ,
-        * so we flag it to be copied if it is not.
+        * The blob needs to be inside the boot mapping.
         */
-       if (fdt_blob >= (char *)CFG_BOOTMAPSZ)
+       if (fdt_blob < (char *)bootmap_base)
                relocate = 1;
 
-       of_len = be32_to_cpu (fdt_totalsize (fdt));
+       if ((fdt_blob + *of_size + CFG_FDT_PAD) >=
+                       ((char *)CFG_BOOTMAPSZ + bootmap_base))
+               relocate = 1;
 
        /* move flattend device tree if needed */
        if (relocate) {
                int err;
-               ulong of_start;
+               ulong of_start = 0;
 
                /* position on a 4K boundary before the alloc_current */
-               of_start = lmb_alloc_base(lmb, of_len, 0x1000,
-                                        (CFG_BOOTMAPSZ + bootmap_base));
+               /* Pad the FDT by a specified amount */
+               of_len = *of_size + CFG_FDT_PAD;
+               of_start = (unsigned long)lmb_alloc_base(lmb, of_len, 0x1000,
+                               (CFG_BOOTMAPSZ + bootmap_base));
 
                if (of_start == 0) {
                        puts("device tree - allocation error\n");
@@ -571,7 +770,7 @@ static int fdt_relocate (struct lmb *lmb, ulong bootmap_base,
                }
 
                debug ("## device tree at 0x%08lX ... 0x%08lX (len=%ld=0x%lX)\n",
-                       (ulong)fdt_blob, (ulong)fdt_blob + of_len - 1,
+                       (ulong)fdt_blob, (ulong)fdt_blob + *of_size - 1,
                        of_len, of_len);
 
                printf ("   Loading Device Tree to %08lx, end %08lx ... ",
@@ -585,9 +784,14 @@ static int fdt_relocate (struct lmb *lmb, ulong bootmap_base,
                puts ("OK\n");
 
                *of_flat_tree = (char *)of_start;
+               *of_size = of_len;
        } else {
                *of_flat_tree = fdt_blob;
-               lmb_reserve(lmb, (ulong)fdt, of_len);
+               of_len = (CFG_BOOTMAPSZ + bootmap_base) - (ulong)fdt_blob;
+               lmb_reserve(lmb, (ulong)fdt_blob, of_len);
+               fdt_set_totalsize(*of_flat_tree, of_len);
+
+               *of_size = of_len;
        }
 
        return 0;