*
*/
-/* The parsing engine of this program is officially at a dead-end.
- * Future work in that direction should move to the work posted
- * at http://doolittle.faludi.com/~larry/parser.html .
- * A start on the integration of that work with the rest of sh.c
- * is at http://codepoet.org/sh.c .
+/* This shell's parsing engine is officially at a dead-end.
+ * Future work shell work should be done using hush.c
*/
-//
-//This works pretty well now, and is now on by default.
-#define BB_FEATURE_SH_ENVIRONMENT
-//
-//Backtick support has some problems, use at your own risk!
-//#define BB_FEATURE_SH_BACKTICKS
-//
-//If, then, else, etc. support.. This should now behave basically
-//like any other Bourne shell -- sortof...
-#define BB_FEATURE_SH_IF_EXPRESSIONS
-//
-/* This is currently sortof broken, only for the brave... */
-#undef HANDLE_CONTINUATION_CHARS
-//
-/* This would be great -- if wordexp wouldn't strip all quoting
- * out from the target strings... As is, a parser needs */
-#undef BB_FEATURE_SH_WORDEXP
-//
+
//For debugging/development on the shell only...
//#define DEBUG_SHELL
#include <sys/wait.h>
#include <unistd.h>
#include <getopt.h>
+#include "busybox.h"
+#include "cmdedit.h"
-#undef BB_FEATURE_SH_WORDEXP
+#ifdef BB_LOCALE_SUPPORT
+#include <locale.h>
+#endif
-#if BB_FEATURE_SH_WORDEXP
-#include <wordexp.h>
-#define expand_t wordexp_t
-#undef BB_FEATURE_SH_BACKTICKS
-#else
#include <glob.h>
#define expand_t glob_t
-#endif
-#include "busybox.h"
-#include "cmdedit.h"
-static const int MAX_LINE = 256; /* size of input buffer for cwd data */
static const int MAX_READ = 128; /* size of input buffer for `read' builtin */
#define JOB_STATUS_FORMAT "[%d] %-22s %.40s\n"
/* function prototypes for builtins */
static int builtin_cd(struct child_prog *cmd);
-static int builtin_env(struct child_prog *dummy);
static int builtin_exec(struct child_prog *cmd);
static int builtin_exit(struct child_prog *cmd);
static int builtin_fg_bg(struct child_prog *cmd);
static int builtin_source(struct child_prog *cmd);
static int builtin_unset(struct child_prog *cmd);
static int builtin_read(struct child_prog *cmd);
-#ifdef BB_FEATURE_SH_IF_EXPRESSIONS
-static int builtin_if(struct child_prog *cmd);
-static int builtin_then(struct child_prog *cmd);
-static int builtin_else(struct child_prog *cmd);
-static int builtin_fi(struct child_prog *cmd);
-/* function prototypes for shell stuff */
-static int run_command_predicate(char *cmd);
-#endif
/* function prototypes for shell stuff */
{"read", "Input environment variable", builtin_read},
{".", "Source-in and run commands in a file", builtin_source},
/* to do: add ulimit */
-#ifdef BB_FEATURE_SH_IF_EXPRESSIONS
- {"if", NULL, builtin_if},
- {"then", NULL, builtin_then},
- {"else", NULL, builtin_else},
- {"fi", NULL, builtin_fi},
-#endif
{NULL, NULL, NULL}
};
/* Table of forking built-in functions (things that fork cannot change global
* variables in the parent process, such as the current working directory) */
static struct built_in_command bltins_forking[] = {
- {"env", "Print all environment variables", builtin_env},
{"pwd", "Print current directory", builtin_pwd},
{"help", "List shell built-in commands", builtin_help},
{NULL, NULL, NULL}
/* Globals that are static to this file */
-static char *cwd;
+static const char *cwd;
static char *local_pending_command = NULL;
static struct jobset job_list = { NULL, NULL };
static int argc;
static char **argv;
static struct close_me *close_me_head;
-#ifdef BB_FEATURE_SH_ENVIRONMENT
-static int last_bg_pid;
-static int last_return_code;
-static int show_x_trace;
-#endif
-#ifdef BB_FEATURE_SH_IF_EXPRESSIONS
-static char syntax_err[]="syntax error near unexpected token";
-#endif
+static unsigned int last_jobid;
static char *PS1;
-static char *PS2;
+static char *PS2 = "> ";
#ifdef DEBUG_SHELL
builtin previous use notes
------ ----------------- ---------
cd cmd->progs[0]
-env 0
exec cmd->progs[0] squashed bug: didn't look for applets or forking builtins
exit cmd->progs[0]
fg_bg cmd->progs[0], job_list->head, job_list->fg
help 0
jobs job_list->head
pwd 0
-export cmd->progs[0] passes cmd, job_list to builtin_env(), which ignores them
+export cmd->progs[0]
source cmd->progs[0]
unset cmd->progs[0]
read cmd->progs[0]
-if cmd->job_context, cmd->text
-then cmd->job_context, cmd->text
-else cmd->job_context, cmd->text
-fi cmd->job_context
-
-The use of cmd->text by if/then/else/fi is hopelessly hacky.
-Would it work to increment cmd->progs[0]->argv and recurse,
-somewhat like builtin_exec does?
I added "struct job *family;" to struct child_prog,
and switched API to builtin_foo(struct child_prog *child);
printf("cd: %s: %m\n", newdir);
return EXIT_FAILURE;
}
- getcwd(cwd, sizeof(char)*MAX_LINE);
-
+ cwd = xgetcwd((char *)cwd);
+ if (!cwd)
+ cwd = unknown;
return EXIT_SUCCESS;
}
-/* built-in 'env' handler */
-static int builtin_env(struct child_prog *dummy)
-{
- char **e;
-
- for (e = environ; *e; e++) {
- printf( "%s\n", *e);
- }
- return (0);
-}
-
/* built-in 'exec' handler */
static int builtin_exec(struct child_prog *child)
{
/* built-in 'fg' and 'bg' handler */
static int builtin_fg_bg(struct child_prog *child)
{
- int i, jobNum;
+ int i, jobnum;
struct job *job=NULL;
-
- if (!child->argv[1] || child->argv[2]) {
- error_msg("%s: exactly one argument is expected",
- child->argv[0]);
- return EXIT_FAILURE;
- }
- if (sscanf(child->argv[1], "%%%d", &jobNum) != 1) {
- error_msg("%s: bad argument '%s'",
- child->argv[0], child->argv[1]);
- return EXIT_FAILURE;
- }
-
- for (job = child->family->job_list->head; job; job = job->next) {
- if (job->jobid == jobNum) {
- break;
+ /* If they gave us no args, assume they want the last backgrounded task */
+ if (!child->argv[1]) {
+ for (job = child->family->job_list->head; job; job = job->next) {
+ if (job->jobid == last_jobid) {
+ break;
+ }
+ }
+ if (!job) {
+ error_msg("%s: no current job", child->argv[0]);
+ return EXIT_FAILURE;
+ }
+ } else {
+ if (sscanf(child->argv[1], "%%%d", &jobnum) != 1) {
+ error_msg("%s: bad argument '%s'", child->argv[0], child->argv[1]);
+ return EXIT_FAILURE;
+ }
+ for (job = child->family->job_list->head; job; job = job->next) {
+ if (job->jobid == jobnum) {
+ break;
+ }
+ }
+ if (!job) {
+ error_msg("%s: %d: no such job", child->argv[0], jobnum);
+ return EXIT_FAILURE;
}
- }
-
- if (!job) {
- error_msg("%s: unknown job %d",
- child->argv[0], jobNum);
- return EXIT_FAILURE;
}
if (*child->argv[0] == 'f') {
/* built-in 'pwd' handler */
static int builtin_pwd(struct child_prog *dummy)
{
- getcwd(cwd, MAX_LINE);
- printf( "%s\n", cwd);
+ cwd = xgetcwd((char *)cwd);
+ if (!cwd)
+ cwd = unknown;
+ puts(cwd);
return EXIT_SUCCESS;
}
char *v = child->argv[1];
if (v == NULL) {
- return (builtin_env(child));
+ char **e;
+ for (e = environ; *e; e++) {
+ puts(*e);
+ }
+ return 0;
}
res = putenv(v);
if (res)
fprintf(stderr, "export: %m\n");
-#ifndef BB_FEATURE_SH_SIMPLE_PROMPT
+#ifdef BB_FEATURE_SH_FANCY_PROMPT
if (strncmp(v, "PS1=", 4)==0)
PS1 = getenv("PS1");
- else if (strncmp(v, "PS2=", 4)==0)
- PS2 = getenv("PS2");
#endif
+
+#ifdef BB_LOCALE_SUPPORT
+ if(strncmp(v, "LC_ALL=", 7)==0)
+ setlocale(LC_ALL, getenv("LC_ALL"));
+ if(strncmp(v, "LC_CTYPE=", 9)==0)
+ setlocale(LC_CTYPE, getenv("LC_CTYPE"));
+#endif
+
return (res);
}
return (res);
}
-#ifdef BB_FEATURE_SH_IF_EXPRESSIONS
-/* Built-in handler for 'if' commands */
-static int builtin_if(struct child_prog *child)
-{
- struct job *cmd = child->family;
- int status;
- char* charptr1=cmd->text+3; /* skip over the leading 'if ' */
-
- /* Now run the 'if' command */
- debug_printf( "job=%p entering builtin_if ('%s')-- context=%d\n", cmd, charptr1, cmd->job_context);
- status = run_command_predicate(charptr1);
- debug_printf( "if test returned ");
- if (status == 0) {
- debug_printf( "TRUE\n");
- cmd->job_context |= IF_TRUE_CONTEXT;
- } else {
- debug_printf( "FALSE\n");
- cmd->job_context |= IF_FALSE_CONTEXT;
- }
- debug_printf("job=%p builtin_if set job context to %x\n", cmd, cmd->job_context);
- shell_context++;
-
- return status;
-}
-
-/* Built-in handler for 'then' (part of the 'if' command) */
-static int builtin_then(struct child_prog *child)
-{
- struct job *cmd = child->family;
- char* charptr1=cmd->text+5; /* skip over the leading 'then ' */
-
- debug_printf( "job=%p entering builtin_then ('%s')-- context=%d\n", cmd, charptr1, cmd->job_context);
- if (! (cmd->job_context & (IF_TRUE_CONTEXT|IF_FALSE_CONTEXT))) {
- shell_context = 0; /* Reset the shell's context on an error */
- error_msg("%s `then'", syntax_err);
- return EXIT_FAILURE;
- }
-
- cmd->job_context |= THEN_EXP_CONTEXT;
- debug_printf("job=%p builtin_then set job context to %x\n", cmd, cmd->job_context);
-
- /* If the if result was FALSE, skip the 'then' stuff */
- if (cmd->job_context & IF_FALSE_CONTEXT) {
- return EXIT_SUCCESS;
- }
-
- /* Seems the if result was TRUE, so run the 'then' command */
- debug_printf( "'then' now running '%s'\n", charptr1);
-
- return(run_command_predicate(charptr1));
-}
-
-/* Built-in handler for 'else' (part of the 'if' command) */
-static int builtin_else(struct child_prog *child)
-{
- struct job *cmd = child->family;
- char* charptr1=cmd->text+5; /* skip over the leading 'else ' */
-
- debug_printf( "job=%p entering builtin_else ('%s')-- context=%d\n", cmd, charptr1, cmd->job_context);
-
- if (! (cmd->job_context & THEN_EXP_CONTEXT)) {
- shell_context = 0; /* Reset the shell's context on an error */
- error_msg("%s `else'", syntax_err);
- return EXIT_FAILURE;
- }
- /* If the if result was TRUE, skip the 'else' stuff */
- if (cmd->job_context & IF_TRUE_CONTEXT) {
- return EXIT_SUCCESS;
- }
-
- cmd->job_context |= ELSE_EXP_CONTEXT;
- debug_printf("job=%p builtin_else set job context to %x\n", cmd, cmd->job_context);
-
- /* Now run the 'else' command */
- debug_printf( "'else' now running '%s'\n", charptr1);
- return(run_command_predicate(charptr1));
-}
-
-/* Built-in handler for 'fi' (part of the 'if' command) */
-static int builtin_fi(struct child_prog *child)
-{
- struct job *cmd = child->family;
- debug_printf( "job=%p entering builtin_fi ('%s')-- context=%d\n", cmd, "", cmd->job_context);
- if (! (cmd->job_context & (IF_TRUE_CONTEXT|IF_FALSE_CONTEXT))) {
- shell_context = 0; /* Reset the shell's context on an error */
- error_msg("%s `fi'", syntax_err);
- return EXIT_FAILURE;
- }
- /* Clear out the if and then context bits */
- cmd->job_context &= ~(IF_TRUE_CONTEXT|IF_FALSE_CONTEXT|THEN_EXP_CONTEXT|ELSE_EXP_CONTEXT);
- debug_printf("job=%p builtin_fi set job context to %x\n", cmd, cmd->job_context);
- shell_context--;
- return EXIT_SUCCESS;
-}
-#endif
-
/* Built-in '.' handler (read-in and execute commands from file) */
static int builtin_source(struct child_prog *child)
{
return EXIT_SUCCESS;
}
-#ifdef BB_FEATURE_SH_IF_EXPRESSIONS
-/* currently used by if/then/else.
- *
- * Reparsing the command line for this purpose is gross,
- * incorrect, and fundamentally unfixable; in particular,
- * think about what happens with command substitution.
- * We really need to pull out the run, wait, return status
- * functionality out of busy_loop so we can child->argv++
- * and use that, without going back through parse_command.
- */
-static int run_command_predicate(char *cmd)
-{
- int n=strlen(cmd);
- local_pending_command = xmalloc(n+1);
- strncpy(local_pending_command, cmd, n);
- local_pending_command[n]='\0';
- return( busy_loop(NULL));
-}
-#endif
-
static void mark_open(int fd)
{
struct close_me *new = xmalloc(sizeof(struct close_me));
static void free_job(struct job *cmd)
{
int i;
+ struct jobset *keep;
for (i = 0; i < cmd->num_progs; i++) {
free(cmd->progs[i].argv);
if (cmd->progs[i].redirects)
free(cmd->progs[i].redirects);
}
- free(cmd->progs);
+ if (cmd->progs)
+ free(cmd->progs);
if (cmd->text)
free(cmd->text);
- free(cmd->cmdbuf);
+ if (cmd->cmdbuf)
+ free(cmd->cmdbuf);
+ keep = cmd->job_list;
memset(cmd, 0, sizeof(struct job));
+ cmd->job_list = keep;
}
-/* remove a job from the job_list */
-static void remove_job(struct jobset *job_list, struct job *job)
+/* remove a job from a jobset */
+static void remove_job(struct jobset *j_list, struct job *job)
{
struct job *prevjob;
free_job(job);
- if (job == job_list->head) {
- job_list->head = job->next;
+ if (job == j_list->head) {
+ j_list->head = job->next;
} else {
- prevjob = job_list->head;
+ prevjob = j_list->head;
while (prevjob->next != job)
prevjob = prevjob->next;
prevjob->next = job->next;
/* Checks to see if any background processes have exited -- if they
have, figure out why and see if a job has completed */
-static void checkjobs(struct jobset *job_list)
+static void checkjobs(struct jobset *j_list)
{
struct job *job;
pid_t childpid;
int prognum = 0;
while ((childpid = waitpid(-1, &status, WNOHANG | WUNTRACED)) > 0) {
- for (job = job_list->head; job; job = job->next) {
+ for (job = j_list->head; job; job = job->next) {
prognum = 0;
while (prognum < job->num_progs &&
job->progs[prognum].pid != childpid) prognum++;
if (!job->running_progs) {
printf(JOB_STATUS_FORMAT, job->jobid, "Done", job->text);
- remove_job(job_list, job);
+ last_jobid=0;
+ remove_job(j_list, job);
}
} else {
/* child stopped */
static inline void cmdedit_set_initial_prompt(void)
{
-#ifdef BB_FEATURE_SH_SIMPLE_PROMPT
+#ifndef BB_FEATURE_SH_FANCY_PROMPT
PS1 = NULL;
- PS2 = "> ";
#else
PS1 = getenv("PS1");
- if(PS1==0) {
+ if(PS1==0)
PS1 = "\\w \\$ ";
- }
- PS2 = getenv("PS2");
- if(PS2==0)
- PS2 = "> ";
#endif
}
static inline void setup_prompt_string(char **prompt_str)
{
-#ifdef BB_FEATURE_SH_SIMPLE_PROMPT
+#ifndef BB_FEATURE_SH_FANCY_PROMPT
/* Set up the prompt */
if (shell_context == 0) {
if (PS1)
return 1;
}
- /* remove trailing newline */
- chomp(command);
-
return 0;
}
-#ifdef BB_FEATURE_SH_ENVIRONMENT
-static char* itoa(register int i)
-{
- static char a[7]; /* Max 7 ints */
- register char *b = a + sizeof(a) - 1;
- int sign = (i < 0);
-
- if (sign)
- i = -i;
- *b = 0;
- do
- {
- *--b = '0' + (i % 10);
- i /= 10;
- }
- while (i);
- if (sign)
- *--b = '-';
- return b;
-}
-#endif
-
-#if defined BB_FEATURE_SH_ENVIRONMENT && ! defined BB_FEATURE_SH_WORDEXP
-char * strsep_space( char *string, int * index)
-{
- char *token, *begin;
-
- begin = string;
-
- /* Short circuit the trivial case */
- if ( !string || ! string[*index])
- return NULL;
-
- /* Find the end of the token. */
- while( string && string[*index] && !isspace(string[*index]) ) {
- (*index)++;
- }
-
- /* Find the end of any whitespace trailing behind
- * the token and let that be part of the token */
- while( string && string[*index] && isspace(string[*index]) ) {
- (*index)++;
- }
-
- if (! string && *index==0) {
- /* Nothing useful was found */
- return NULL;
- }
-
- token = xmalloc(*index);
- token[*index] = '\0';
- strncpy(token, string, *index);
-
- return token;
-}
-#endif
-
static int expand_arguments(char *command)
{
-#ifdef BB_FEATURE_SH_ENVIRONMENT
- expand_t expand_result;
- char *src, *dst, *var;
- int index = 0;
- int i=0, length, total_length=0, retval;
- const char *out_of_space = "out of space during expansion";
-#endif
+ int ix = 0;
/* get rid of the terminating \n */
chomp(command);
/* Fix up escape sequences to be the Real Thing(tm) */
- while( command && command[index]) {
- if (command[index] == '\\') {
- char *tmp = command+index+1;
- command[index+1] = process_escape_sequence( &tmp );
- memmove(command+index, command+index+1, strlen(command+index));
- }
- index++;
- }
-
-#ifdef BB_FEATURE_SH_ENVIRONMENT
-
-
-#if BB_FEATURE_SH_WORDEXP
- /* This first part uses wordexp() which is a wonderful C lib
- * function which expands nearly everything. */
- retval = wordexp (command, &expand_result, WRDE_SHOWERR);
- if (retval == WRDE_NOSPACE) {
- /* Mem may have been allocated... */
- wordfree (&expand_result);
- error_msg(out_of_space);
- return FALSE;
- }
- if (retval < 0) {
- /* Some other error. */
- error_msg("syntax error");
- return FALSE;
- }
-
- if (expand_result.we_wordc > 0) {
- /* Convert from char** (one word per string) to a simple char*,
- * but don't overflow command which is BUFSIZ in length */
- *command = '\0';
- while (i < expand_result.we_wordc && total_length < BUFSIZ) {
- length=strlen(expand_result.we_wordv[i])+1;
- if (BUFSIZ-total_length-length <= 0) {
- error_msg(out_of_space);
- return FALSE;
- }
- strcat(command+total_length, expand_result.we_wordv[i++]);
- strcat(command+total_length, " ");
- total_length+=length;
- }
- wordfree (&expand_result);
- }
-#else
-
- /* Ok. They don't have a recent glibc and they don't have uClibc. Chances
- * are about 100% they don't have wordexp(). So instead the best we can do
- * is use glob and then fixup environment variables and such ourselves.
- * This is better then nothing, but certainly not perfect */
-
- /* It turns out that glob is very stupid. We have to feed it one word at a
- * time since it can't cope with a full string. Here we convert command
- * (char*) into cmd (char**, one word per string) */
- {
-
- int flags = GLOB_NOCHECK
-#ifdef GLOB_BRACE
- | GLOB_BRACE
-#endif
-#ifdef GLOB_TILDE
- | GLOB_TILDE
-#endif
- ;
- char *tmpcmd, *cmd, *cmd_copy;
- /* We need a clean copy, so strsep can mess up the copy while
- * we write stuff into the original (in a minute) */
- cmd = cmd_copy = strdup(command);
- *command = '\0';
- for (index = 0, tmpcmd = cmd;
- (tmpcmd = strsep_space(cmd, &index)) != NULL; cmd += index, index=0) {
- if (*tmpcmd == '\0')
- break;
- retval = glob(tmpcmd, flags, NULL, &expand_result);
- free(tmpcmd); /* Free mem allocated by strsep_space */
- if (retval == GLOB_NOSPACE) {
- /* Mem may have been allocated... */
- globfree (&expand_result);
- error_msg(out_of_space);
- return FALSE;
- } else if (retval != 0) {
- /* Some other error. GLOB_NOMATCH shouldn't
- * happen because of the GLOB_NOCHECK flag in
- * the glob call. */
- error_msg("syntax error");
- return FALSE;
- } else {
- /* Convert from char** (one word per string) to a simple char*,
- * but don't overflow command which is BUFSIZ in length */
- for (i=0; i < expand_result.gl_pathc; i++) {
- length=strlen(expand_result.gl_pathv[i])+1;
- if (BUFSIZ-total_length-length <= 0) {
- error_msg(out_of_space);
- return FALSE;
- }
- strcat(command+total_length, expand_result.gl_pathv[i]);
- strcat(command+total_length, " ");
- total_length+=length;
- }
- globfree (&expand_result);
- }
- }
- free(cmd_copy);
- trim(command);
- }
-
-#endif
-
- /* Now do the shell variable substitutions which
- * wordexp can't do for us, namely $? and $! */
- src = command;
- while((dst = strchr(src,'$')) != NULL){
- var = NULL;
- switch(*(dst+1)) {
- case '?':
- var = itoa(last_return_code);
- break;
- case '!':
- if (last_bg_pid==-1)
- *(var)='\0';
- else
- var = itoa(last_bg_pid);
- break;
- /* Everything else like $$, $#, $[0-9], etc should all be
- * expanded by wordexp(), so we can in theory skip that stuff
- * here, but just to be on the safe side (i.e. since uClibc
- * wordexp doesn't do this stuff yet), lets leave it in for
- * now. */
- case '$':
- var = itoa(getpid());
- break;
- case '#':
- var = itoa(argc-1);
- break;
- case '0':case '1':case '2':case '3':case '4':
- case '5':case '6':case '7':case '8':case '9':
- {
- int index=*(dst + 1)-48;
- if (index >= argc) {
- var='\0';
- } else {
- var = argv[index];
- }
- }
- break;
-
- }
- if (var) {
- /* a single character construction was found, and
- * already handled in the case statement */
- src=dst+2;
- } else {
- /* Looks like an environment variable */
- char delim_hold;
- int num_skip_chars=1;
- int dstlen = strlen(dst);
- /* Is this a ${foo} type variable? */
- if (dstlen >=2 && *(dst+1) == '{') {
- src=strchr(dst+1, '}');
- num_skip_chars=2;
- } else {
- src=strpbrk(dst+1, " \t~`!$^&*()=|\\[];\"'<>?./");
- }
- if (src == NULL) {
- src = dst+dstlen;
- }
- delim_hold=*src;
- *src='\0'; /* temporary */
- var = getenv(dst + num_skip_chars);
- *src=delim_hold;
- if (num_skip_chars==2) {
- src++;
- }
- }
- if (var == NULL) {
- /* Seems we got an un-expandable variable. So delete it. */
- var = "";
- }
- {
- int subst_len = strlen(var);
- int trail_len = strlen(src);
- if (dst+subst_len+trail_len >= command+BUFSIZ) {
- error_msg(out_of_space);
- return FALSE;
- }
- /* Move stuff to the end of the string to accommodate
- * filling the created gap with the new stuff */
- memmove(dst+subst_len, src, trail_len);
- *(dst+subst_len+trail_len)='\0';
- /* Now copy in the new stuff */
- memcpy(dst, var, subst_len);
- src = dst+subst_len;
+ while( command && command[ix]) {
+ if (command[ix] == '\\') {
+ const char *tmp = command+ix+1;
+ command[ix] = process_escape_sequence( &tmp );
+ memmove(command+ix + 1, tmp, strlen(tmp)+1);
}
+ ix++;
}
-#endif
return TRUE;
}
int argc_l = 0;
int done = 0;
int argv_alloced;
- int i;
+ int i, saw_quote = 0;
char quote = '\0';
int count;
struct child_prog *prog;
*src == ']') *buf++ = '\\';
*buf++ = *src;
} else if (isspace(*src)) {
- if (*prog->argv[argc_l]) {
+ if (*prog->argv[argc_l] || saw_quote) {
buf++, argc_l++;
/* +1 here leaves room for the NULL which ends argv */
if ((argc_l + 1) == argv_alloced) {
argv_alloced);
}
prog->argv[argc_l] = buf;
+ saw_quote = 0;
}
} else
switch (*src) {
case '"':
case '\'':
quote = *src;
+ saw_quote = 1;
break;
case '#': /* comment */
chptr++;
if (!*chptr) {
- error_msg("file name expected after %c", *src);
+ error_msg("file name expected after %c", *(src-1));
free_job(job);
job->num_progs=0;
return 1;
case '|': /* pipe */
/* finish this command */
- if (*prog->argv[argc_l])
+ if (*prog->argv[argc_l] || saw_quote)
argc_l++;
if (!argc_l) {
error_msg("empty command in pipe");
return_command = *command_ptr + (src - *command_ptr) + 1;
break;
-#ifdef BB_FEATURE_SH_BACKTICKS
- case '`':
- /* Exec a backtick-ed command */
- /* Besides any previous brokenness, I have not
- * updated backtick handling for close_me support.
- * I don't know if it needs it or not. -- LRD */
- {
- char* charptr1=NULL, *charptr2;
- char* ptr=NULL;
- struct job *newjob;
- struct jobset njob_list = { NULL, NULL };
- int pipefd[2];
- int size;
-
- ptr=strchr(++src, '`');
- if (ptr==NULL) {
- fprintf(stderr, "Unmatched '`' in command\n");
- free_job(job);
- return 1;
- }
-
- /* Make some space to hold just the backticked command */
- charptr1 = charptr2 = xmalloc(1+ptr-src);
- memcpy(charptr1, src, ptr-src);
- charptr1[ptr-src] = '\0';
- newjob = xmalloc(sizeof(struct job));
- newjob->job_list = &njob_list;
- /* Now parse and run the backticked command */
- if (!parse_command(&charptr1, newjob, inbg)
- && newjob->num_progs) {
- pipe(pipefd);
- run_command(newjob, 0, pipefd);
- }
- checkjobs(job->job_list);
- free_job(newjob); /* doesn't actually free newjob,
- looks like a memory leak */
- free(charptr2);
-
- /* Make a copy of any stuff left over in the command
- * line after the second backtick */
- charptr2 = xmalloc(strlen(ptr)+1);
- memcpy(charptr2, ptr+1, strlen(ptr));
-
-
- /* Copy the output from the backtick-ed command into the
- * command line, making extra room as needed */
- --src;
- charptr1 = xmalloc(BUFSIZ);
- while ( (size=full_read(pipefd[0], charptr1, BUFSIZ-1)) >0) {
- int newsize=src - *command_ptr + size + 1 + strlen(charptr2);
- if (newsize > BUFSIZ) {
- *command_ptr=xrealloc(*command_ptr, newsize);
- }
- memcpy(src, charptr1, size);
- src+=size;
- }
- free(charptr1);
- close(pipefd[0]);
- if (*(src-1)=='\n')
- --src;
-
- /* Now paste into the *command_ptr all the stuff
- * leftover after the second backtick */
- memcpy(src, charptr2, strlen(charptr2)+1);
- free(charptr2);
-
- /* Now recursively call parse_command to deal with the new
- * and improved version of the command line with the backtick
- * results expanded in place... */
- {
- struct jobset *jl=job->job_list;
- free_job(job);
- job->job_list = jl;
- }
- return(parse_command(command_ptr, job, inbg));
- }
- break;
-#endif // BB_FEATURE_SH_BACKTICKS
-
case '\\':
src++;
if (!*src) {
-/* This is currently a little broken... */
-#ifdef HANDLE_CONTINUATION_CHARS
- /* They fed us a continuation char, so continue reading stuff
- * on the next line, then tack that onto the end of the current
- * command */
- char *command;
- int newsize;
- printf("erik: found a continue char at EOL...\n");
- command = (char *) xcalloc(BUFSIZ, sizeof(char));
- if (get_command(input, command)) {
- error_msg("character expected after \\");
- free(command);
- free_job(job);
- return 1;
- }
- newsize = strlen(*command_ptr) + strlen(command) + 2;
- if (newsize > BUFSIZ) {
- printf("erik: doing realloc\n");
- *command_ptr=xrealloc(*command_ptr, newsize);
- }
- printf("erik: A: *command_ptr='%s'\n", *command_ptr);
- memcpy(--src, command, strlen(command));
- printf("erik: B: *command_ptr='%s'\n", *command_ptr);
- free(command);
- break;
-#else
error_msg("character expected after \\");
- free(command);
free_job(job);
return 1;
-#endif
}
if (*src == '*' || *src == '[' || *src == ']'
|| *src == '?') *buf++ = '\\';
src++;
}
- if (*prog->argv[argc_l]) {
+ if (*prog->argv[argc_l] || saw_quote) {
argc_l++;
}
if (!argc_l) {
#endif
{
- char** argv=child->argv;
+ char** argv_l=child->argv;
int argc_l;
- for(argc_l=0;*argv!=NULL; argv++, argc_l++);
+ for(argc_l=0;*argv_l!=NULL; argv_l++, argc_l++);
optind = 1;
run_applet_by_name(name, argc_l, child->argv);
}
static void insert_job(struct job *newjob, int inbg)
{
struct job *thejob;
- struct jobset *job_list=newjob->job_list;
+ struct jobset *j_list=newjob->job_list;
/* find the ID for thejob to use */
newjob->jobid = 1;
- for (thejob = job_list->head; thejob; thejob = thejob->next)
+ for (thejob = j_list->head; thejob; thejob = thejob->next)
if (thejob->jobid >= newjob->jobid)
newjob->jobid = thejob->jobid + 1;
/* add thejob to the list of running jobs */
- if (!job_list->head) {
- thejob = job_list->head = xmalloc(sizeof(*thejob));
+ if (!j_list->head) {
+ thejob = j_list->head = xmalloc(sizeof(*thejob));
} else {
- for (thejob = job_list->head; thejob->next; thejob = thejob->next) /* nothing */;
+ for (thejob = j_list->head; thejob->next; thejob = thejob->next) /* nothing */;
thejob->next = xmalloc(sizeof(*thejob));
thejob = thejob->next;
}
to the list of backgrounded thejobs and leave it alone */
printf("[%d] %d\n", thejob->jobid,
newjob->progs[newjob->num_progs - 1].pid);
-#ifdef BB_FEATURE_SH_ENVIRONMENT
- last_bg_pid=newjob->progs[newjob->num_progs - 1].pid;
-#endif
+ last_jobid = newjob->jobid;
} else {
newjob->job_list->fg = thejob;
}
}
-#ifdef BB_FEATURE_SH_ENVIRONMENT
- if (show_x_trace==TRUE) {
- int j;
- fputc('+', stderr);
- for (j = 0; child->argv[j]; j++) {
- fputc(' ', stderr);
- fputs(child->argv[j], stderr);
- }
- fputc('\n', stderr);
- }
-#endif
/* Check if the command matches any non-forking builtins,
* but only if this is a simple command.
job_list.fg->running_progs--;
job_list.fg->progs[i].pid = 0;
-#ifdef BB_FEATURE_SH_ENVIRONMENT
- last_return_code=WEXITSTATUS(status);
- debug_printf("'%s' exited -- return code %d\n",
- job_list.fg->text, last_return_code);
-#endif
if (!job_list.fg->running_progs) {
/* child exited */
remove_job(&job_list, job_list.fg);
if (!job_list.fg) {
/* move the shell to the foreground */
/* suppress messages when run from /linuxrc mag@sysgo.de */
- if (tcsetpgrp(0, getpid()) && errno != ENOTTY)
+ if (tcsetpgrp(0, getpgrp()) && errno != ENOTTY)
perror_msg("tcsetpgrp");
}
}
#ifdef BB_FEATURE_CLEAN_UP
void free_memory(void)
{
- if (cwd)
+ if (cwd) {
free(cwd);
+ }
if (local_pending_command)
free(local_pending_command);
argv = argv_l;
/* These variables need re-initializing when recursing */
+ last_jobid = 0;
shell_context = 0;
- cwd=NULL;
local_pending_command = NULL;
close_me_head = NULL;
job_list.head = NULL;
job_list.fg = NULL;
-#ifdef BB_FEATURE_SH_ENVIRONMENT
- last_bg_pid=1;
- last_return_code=1;
- show_x_trace=FALSE;
-#endif
if (argv[0] && argv[0][0] == '-') {
FILE *prof_input;
optind++;
argv = argv+optind;
break;
-#ifdef BB_FEATURE_SH_ENVIRONMENT
- case 'x':
- show_x_trace = TRUE;
- break;
-#endif
case 'i':
interactive = TRUE;
break;
if (interactive==TRUE) {
//printf( "optind=%d argv[optind]='%s'\n", optind, argv[optind]);
/* Looks like they want an interactive shell */
- printf( "\n\nBusyBox v%s (%s) Built-in shell (lash)\n", BB_VER, BB_BT);
+ printf( "\n\n" BB_BANNER " Built-in shell (lash)\n");
printf( "Enter 'help' for a list of built-in commands.\n\n");
} else if (local_pending_command==NULL) {
//printf( "optind=%d argv[optind]='%s'\n", optind, argv[optind]);
}
/* initialize the cwd -- this is never freed...*/
- cwd=(char*)xmalloc(sizeof(char)*MAX_LINE+1);
- getcwd(cwd, sizeof(char)*MAX_LINE);
+ cwd = xgetcwd(0);
+ if (!cwd)
+ cwd = unknown;
#ifdef BB_FEATURE_CLEAN_UP
atexit(free_memory);
cmdedit_set_initial_prompt();
#else
PS1 = NULL;
- PS2 = "> ";
#endif
return (busy_loop(input));