Silence a silly warning

[oweals/busybox.git] / id.c

diff --git a/id.c b/id.c
index 8ded0e521c4e3cba24caa16a647799deba27c8c9..3f90d55f63b2321043e729c68721b390841ab309 100644 (file)
--- a/id.c
+++ b/id.c
@@ -2,7 +2,6 @@
 /*
  * Mini id implementation for busybox
  *
- *
  * Copyright (C) 2000 by Randolph Chung <tausq@debian.org>
  *
  * This program is free software; you can redistribute it and/or modify
@@ -21,50 +20,46 @@
  *
  */
 
-#include "internal.h"
+#include "busybox.h"
 #include <stdio.h>
 #include <unistd.h>
-#include <pwd.h>
-#include <grp.h>
+#include <getopt.h>
+#include <string.h>
 #include <sys/types.h>
 
-static const char id_usage[] =
-       "id [OPTIONS]... [USERNAME]\n\n"
-       "Print information for USERNAME or the current user\n\n"
-       "\t-g\tprints only the group ID\n"
-       "\t-u\tprints only the user ID\n"
-       "\t-r\tprints the real user ID instead of the effective ID (with -ug)\n\n";
-
 extern int id_main(int argc, char **argv)
 {
        int no_user = 0, no_group = 0, print_real = 0;
-       char *cp, *user, *group;
-       gid_t gid;
+       int name_not_number = 0;
+       char user[9], group[9];
+       long gid;
+       long pwnam, grnam;
+       int opt;
        
-       cp = user = group = NULL;
+       gid = 0;
 
-       argc--; argv++;
-
-       while (argc > 0) {
-               cp = *argv;
-               if (*cp == '-') {
-                       switch (*++cp) {
-                       case 'u': no_group = 1; break;
-                       case 'g': no_user = 1; break;
-                       case 'r': print_real = 1; break;
-                       default: usage(id_usage);
-                       }
-               } else {
-                       user = cp;                      
+       while ((opt = getopt(argc, argv, "ugrn")) > 0) {
+               switch (opt) {
+                       case 'u':
+                               no_group++;
+                               break;
+                       case 'g':
+                               no_user++;
+                               break;
+                       case 'r':
+                               print_real++;
+                               break;
+                       case 'n':
+                               name_not_number++;
+                               break;
+                       default:
+                               show_usage();
                }
-               argc--; argv++;
        }
 
-       if (no_user && no_group) usage(id_usage);
+       if (no_user && no_group) show_usage();
 
-       if (user == NULL) {
-               user = xmalloc(9);
-               group = xmalloc(9);
+       if (argv[optind] == NULL) {
                if (print_real) {
                        my_getpwuid(user, getuid());
                        my_getgrgid(group, getgid());
@@ -73,19 +68,29 @@ extern int id_main(int argc, char **argv)
                        my_getgrgid(group, getegid());
                }
        } else {
-               group = xmalloc(9);
+               strncpy(user, argv[optind], 8);
+               user[8] = '\0';
            gid = my_getpwnamegid(user);
                my_getgrgid(group, gid);
        }
 
-       if (no_group) printf("%u\n", my_getpwnam(user));
-       else if (no_user) printf("%u\n", my_getgrnam(group));
-       else
-               printf("uid=%u(%s) gid=%u(%s)\n",
-                          my_getpwnam(user), user, my_getgrnam(group), group);
-       
+       pwnam=my_getpwnam(user);
+       grnam=my_getgrnam(group);
 
-       exit(0);
+       if (no_group) {
+               if(name_not_number && user)
+                       printf("%s\n",user);
+               else
+                       printf("%ld\n", pwnam);
+       } else if (no_user) {
+               if(name_not_number && group)
+                       printf("%s\n", group);
+               else
+                       printf("%ld\n", grnam);
+       } else {
+               printf("uid=%ld(%s) gid=%ld(%s)\n", pwnam, user, grnam, group);
+       }
+       return(0);
 }