cp: revert a recent buggy change, and add a comment why it's wrong
[oweals/busybox.git] / findutils / xargs.c
index ea7c220604e717e3016dacc60ce18295184d1af3..76d1d5489037a63aae2e7cc7c387ccca80287627 100644 (file)
  *
  */
 
-#include "busybox.h"
+#include "libbb.h"
+
+/* This is a NOEXEC applet. Be very careful! */
+
 
 /* COMPAT:  SYSV version defaults size (and has a max value of) to 470.
    We try to make it as large as possible. */
    This function has special algorithm.
    Don't use fork and include to main!
 */
-static int xargs_exec(char *const *args)
+static int xargs_exec(char **args)
 {
-       pid_t p;
-       volatile int exec_errno = 0;    /* shared vfork stack */
        int status;
 
-       p = vfork();
-       if (p < 0)
-               bb_perror_msg_and_die("vfork");
-
-       if (p == 0) {
-               /* vfork -- child */
-               BB_EXECVP(args[0], args);
-               exec_errno = errno;     /* set error to shared stack */
-               _exit(1);
+       status = spawn_and_wait(args);
+       if (status < 0) {
+               bb_simple_perror_msg(args[0]);
+               return errno == ENOENT ? 127 : 126;
        }
-
-       /* vfork -- parent */
-       while (wait(&status) == (pid_t) -1)
-               if (errno != EINTR)
-                       break;
-       if (exec_errno) {
-               errno = exec_errno;
-               bb_perror_msg("%s", args[0]);
-               return exec_errno == ENOENT ? 127 : 126;
-       }
-       if (WEXITSTATUS(status) == 255) {
+       if (status == 255) {
                bb_error_msg("%s: exited with status 255; aborting", args[0]);
                return 124;
        }
+/* Huh? I think we won't see this, ever. We don't wait with WUNTRACED!
        if (WIFSTOPPED(status)) {
                bb_error_msg("%s: stopped by signal %d",
                        args[0], WSTOPSIG(status));
                return 125;
        }
-       if (WIFSIGNALED(status)) {
+*/
+       if (status >= 1000) {
                bb_error_msg("%s: terminated by signal %d",
-                       args[0], WTERMSIG(status));
+                       args[0], status - 1000);
                return 125;
        }
-       if (WEXITSTATUS(status))
+       if (status)
                return 123;
        return 0;
 }
 
 
 typedef struct xlist_t {
-       char *data;
-       size_t length;
        struct xlist_t *link;
+       size_t length;
+       char xstr[1];
 } xlist_t;
 
 static smallint eof_stdin_detected;
@@ -117,7 +105,7 @@ static xlist_t *process_stdin(xlist_t *list_arg,
 
        char *s = NULL;         /* start word */
        char *p = NULL;         /* pointer to end word */
-       char q = 0;             /* quote char */
+       char q = '\0';          /* quote char */
        char state = NORM;
        char eof_str_detected = 0;
        size_t line_l = 0;      /* size loaded args line */
@@ -125,10 +113,10 @@ static xlist_t *process_stdin(xlist_t *list_arg,
        xlist_t *cur;
        xlist_t *prev;
 
-       cur = list_arg;
+       prev = cur = list_arg;
        while (1) {
-               prev = cur;
                if (!cur) break;
+               prev = cur;
                line_l += cur->length;
                cur = cur->link;
        }
@@ -147,19 +135,16 @@ static xlist_t *process_stdin(xlist_t *list_arg,
                        state = NORM;
                        goto set;
                } else if (state == QUOTE) {
-                       if (c == q) {
-                               q = 0;
-                               state = NORM;
-                       } else {
+                       if (c != q)
                                goto set;
-                       }
-               } else { /* if(state == NORM) */
-
+                       q = '\0';
+                       state = NORM;
+               } else { /* if (state == NORM) */
                        if (ISSPACE(c)) {
                                if (s) {
-unexpected_eof:
+ unexpected_eof:
                                        state = SPACE;
-                                       c = 0;
+                                       c = '\0';
                                        goto set;
                                }
                        } else {
@@ -171,7 +156,7 @@ unexpected_eof:
                                        q = c;
                                        state = QUOTE;
                                } else {
-set:
+ set:
                                        if ((size_t)(p - buf) >= mc)
                                                bb_error_msg_and_die("argument line too long");
                                        *p++ = c;
@@ -189,11 +174,11 @@ set:
                        }
                        if (!eof_str_detected) {
                                size_t length = (p - buf);
-
-                               cur = xzalloc(sizeof(xlist_t) + length);
-                               cur->data = memcpy(cur + 1, s, length);
+                               /* Dont xzalloc - it can be quite big */
+                               cur = xmalloc(offsetof(xlist_t, xstr) + length);
+                               cur->link = NULL;
                                cur->length = length;
-                               /*cur->link = NULL;*/
+                               memcpy(cur->xstr, s, length);
                                if (prev == NULL) {
                                        list_arg = cur;
                                } else {
@@ -226,10 +211,10 @@ static xlist_t *process_stdin(xlist_t *list_arg,
        xlist_t *cur;
        xlist_t *prev;
 
-       cur = list_arg;
+       prev = cur = list_arg;
        while (1) {
-               prev = cur;
                if (!cur) break;
+               prev = cur;
                line_l += cur->length;
                cur = cur->link;
        }
@@ -248,9 +233,9 @@ static xlist_t *process_stdin(xlist_t *list_arg,
                }
                if (s == NULL)
                        s = p = buf;
-               if ((p - buf) >= mc)
+               if ((size_t)(p - buf) >= mc)
                        bb_error_msg_and_die("argument line too long");
-               *p++ = c == EOF ? 0 : c;
+               *p++ = (c == EOF ? '\0' : c);
                if (c == EOF) { /* word's delimiter or EOF detected */
                        /* word loaded */
                        if (eof_str) {
@@ -258,11 +243,11 @@ static xlist_t *process_stdin(xlist_t *list_arg,
                        }
                        if (!eof_str_detected) {
                                size_t length = (p - buf);
-
-                               cur = xzalloc(sizeof(xlist_t) + length);
-                               cur->data = memcpy(cur + 1, s, length);
+                               /* Dont xzalloc - it can be quite big */
+                               cur = xmalloc(offsetof(xlist_t, xstr) + length);
+                               cur->link = NULL;
                                cur->length = length;
-                               /*cur->link = NULL;*/
+                               memcpy(cur->xstr, s, length);
                                if (prev == NULL) {
                                        list_arg = cur;
                                } else {
@@ -292,7 +277,7 @@ static int xargs_ask_confirmation(void)
        FILE *tty_stream;
        int c, savec;
 
-       tty_stream = xfopen(CURRENT_TTY, "r");
+       tty_stream = xfopen_for_read(CURRENT_TTY);
        fputs(" ?...", stderr);
        fflush(stderr);
        c = savec = getc(tty_stream);
@@ -307,7 +292,7 @@ static int xargs_ask_confirmation(void)
 
 #if ENABLE_FEATURE_XARGS_SUPPORT_ZERO_TERM
 static xlist_t *process0_stdin(xlist_t *list_arg,
-               const char *eof_str ATTRIBUTE_UNUSED, size_t mc, char *buf)
+               const char *eof_str UNUSED_PARAM, size_t mc, char *buf)
 {
        int c;                  /* current char */
        char *s = NULL;         /* start word */
@@ -316,10 +301,10 @@ static xlist_t *process0_stdin(xlist_t *list_arg,
        xlist_t *cur;
        xlist_t *prev;
 
-       cur = list_arg;
+       prev = cur = list_arg;
        while (1) {
-               prev = cur;
                if (!cur) break;
+               prev = cur;
                line_l += cur->length;
                cur = cur->link;
        }
@@ -330,21 +315,21 @@ static xlist_t *process0_stdin(xlist_t *list_arg,
                        eof_stdin_detected = 1;
                        if (s == NULL)
                                break;
-                       c = 0;
+                       c = '\0';
                }
                if (s == NULL)
                        s = p = buf;
                if ((size_t)(p - buf) >= mc)
                        bb_error_msg_and_die("argument line too long");
                *p++ = c;
-               if (c == 0) {   /* word's delimiter or EOF detected */
+               if (c == '\0') {   /* word's delimiter or EOF detected */
                        /* word loaded */
                        size_t length = (p - buf);
-
-                       cur = xzalloc(sizeof(xlist_t) + length);
-                       cur->data = memcpy(cur + 1, s, length);
+                       /* Dont xzalloc - it can be quite big */
+                       cur = xmalloc(offsetof(xlist_t, xstr) + length);
+                       cur->link = NULL;
                        cur->length = length;
-                       /*cur->link = NULL;*/
+                       memcpy(cur->xstr, s, length);
                        if (prev == NULL) {
                                list_arg = cur;
                        } else {
@@ -370,25 +355,27 @@ enum {
        OPTBIT_UPTO_NUMBER,
        OPTBIT_UPTO_SIZE,
        OPTBIT_EOF_STRING,
-       USE_FEATURE_XARGS_SUPPORT_CONFIRMATION(OPTBIT_INTERACTIVE,)
-       USE_FEATURE_XARGS_SUPPORT_TERMOPT(     OPTBIT_TERMINATE  ,)
-       USE_FEATURE_XARGS_SUPPORT_ZERO_TERM(   OPTBIT_ZEROTERM   ,)
-
-       OPT_VERBOSE     = 1<<OPTBIT_VERBOSE    ,
-       OPT_NO_EMPTY    = 1<<OPTBIT_NO_EMPTY   ,
-       OPT_UPTO_NUMBER = 1<<OPTBIT_UPTO_NUMBER,
-       OPT_UPTO_SIZE   = 1<<OPTBIT_UPTO_SIZE  ,
-       OPT_EOF_STRING  = 1<<OPTBIT_EOF_STRING ,
-       OPT_INTERACTIVE = USE_FEATURE_XARGS_SUPPORT_CONFIRMATION((1<<OPTBIT_INTERACTIVE)) + 0,
-       OPT_TERMINATE   = USE_FEATURE_XARGS_SUPPORT_TERMOPT(     (1<<OPTBIT_TERMINATE  )) + 0,
-       OPT_ZEROTERM    = USE_FEATURE_XARGS_SUPPORT_ZERO_TERM(   (1<<OPTBIT_ZEROTERM   )) + 0,
+       OPTBIT_EOF_STRING1,
+       IF_FEATURE_XARGS_SUPPORT_CONFIRMATION(OPTBIT_INTERACTIVE,)
+       IF_FEATURE_XARGS_SUPPORT_TERMOPT(     OPTBIT_TERMINATE  ,)
+       IF_FEATURE_XARGS_SUPPORT_ZERO_TERM(   OPTBIT_ZEROTERM   ,)
+
+       OPT_VERBOSE     = 1 << OPTBIT_VERBOSE    ,
+       OPT_NO_EMPTY    = 1 << OPTBIT_NO_EMPTY   ,
+       OPT_UPTO_NUMBER = 1 << OPTBIT_UPTO_NUMBER,
+       OPT_UPTO_SIZE   = 1 << OPTBIT_UPTO_SIZE  ,
+       OPT_EOF_STRING  = 1 << OPTBIT_EOF_STRING , /* GNU: -e[<param>] */
+       OPT_EOF_STRING1 = 1 << OPTBIT_EOF_STRING1, /* SUS: -E<param> */
+       OPT_INTERACTIVE = IF_FEATURE_XARGS_SUPPORT_CONFIRMATION((1 << OPTBIT_INTERACTIVE)) + 0,
+       OPT_TERMINATE   = IF_FEATURE_XARGS_SUPPORT_TERMOPT(     (1 << OPTBIT_TERMINATE  )) + 0,
+       OPT_ZEROTERM    = IF_FEATURE_XARGS_SUPPORT_ZERO_TERM(   (1 << OPTBIT_ZEROTERM   )) + 0,
 };
-#define OPTION_STR "+trn:s:e::" \
-       USE_FEATURE_XARGS_SUPPORT_CONFIRMATION("p") \
-       USE_FEATURE_XARGS_SUPPORT_TERMOPT(     "x") \
-       USE_FEATURE_XARGS_SUPPORT_ZERO_TERM(   "0")
+#define OPTION_STR "+trn:s:e::E:" \
+       IF_FEATURE_XARGS_SUPPORT_CONFIRMATION("p") \
+       IF_FEATURE_XARGS_SUPPORT_TERMOPT(     "x") \
+       IF_FEATURE_XARGS_SUPPORT_ZERO_TERM(   "0")
 
-int xargs_main(int argc, char **argv);
+int xargs_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
 int xargs_main(int argc, char **argv)
 {
        char **args;
@@ -400,7 +387,7 @@ int xargs_main(int argc, char **argv)
        int n_max_arg;
        size_t n_chars = 0;
        long orig_arg_max;
-       const char *eof_str = "_";
+       const char *eof_str = NULL;
        unsigned opt;
        size_t n_max_chars;
 #if ENABLE_FEATURE_XARGS_SUPPORT_ZERO_TERM
@@ -409,10 +396,16 @@ int xargs_main(int argc, char **argv)
 #define read_args process_stdin
 #endif
 
-       opt = getopt32(argc, argv, OPTION_STR, &max_args, &max_chars, &eof_str);
+       opt = getopt32(argv, OPTION_STR, &max_args, &max_chars, &eof_str, &eof_str);
+
+       /* -E ""? You may wonder why not just omit -E?
+        * This is used for portability:
+        * old xargs was using "_" as default for -E / -e */
+       if ((opt & OPT_EOF_STRING1) && eof_str[0] == '\0')
+               eof_str = NULL;
 
        if (opt & OPT_ZEROTERM)
-               USE_FEATURE_XARGS_SUPPORT_ZERO_TERM(read_args = process0_stdin);
+               IF_FEATURE_XARGS_SUPPORT_ZERO_TERM(read_args = process0_stdin);
 
        argv += optind;
        argc -= optind;
@@ -490,7 +483,7 @@ int xargs_main(int argc, char **argv)
                        args[i] = argv[i];
                /* (taken from stdin) */
                for (cur = list; n; cur = cur->link) {
-                       args[i++] = cur->data;
+                       args[i++] = cur->xstr;
                        n--;
                }
 
@@ -517,7 +510,7 @@ int xargs_main(int argc, char **argv)
                if (child_error > 0 && child_error != 123) {
                        break;
                }
-       }
+       } /* while */
        if (ENABLE_FEATURE_CLEAN_UP)
                free(max_chars);
        return child_error;
@@ -532,7 +525,7 @@ void bb_show_usage(void)
 {
        fprintf(stderr, "Usage: %s [-p] [-r] [-t] -[x] [-n max_arg] [-s max_chars]\n",
                applet_name);
-       exit(1);
+       exit(EXIT_FAILURE);
 }
 
 int main(int argc, char **argv)