libarchive: open_zipped() does not need to check extensions for e.g. gzip
[oweals/busybox.git] / editors / patch.c
index 4fadbb8fe991d4357e6ae457bb2f6de048064b5b..13785ef460ab45821ac6451119255707709b1a21 100644 (file)
  * -D define wrap #ifdef and #ifndef around changes
  * -o outfile output here instead of in place
  * -r rejectfile write rejected hunks to this file
+ * --dry-run (regression!)
  *
  * -f force (no questions asked)
  * -F fuzz (number, default 2)
  * [file] which file to patch
  */
 
-//applet:IF_PATCH(APPLET(patch, _BB_DIR_USR_BIN, _BB_SUID_DROP))
-
-//kbuild:lib-$(CONFIG_PATCH) += patch.o
-
 //config:config PATCH
 //config:      bool "patch"
 //config:      default y
 //config:      help
 //config:        Apply a unified diff formatted patch.
 
+//applet:IF_PATCH(APPLET(patch, BB_DIR_USR_BIN, BB_SUID_DROP))
+
+//kbuild:lib-$(CONFIG_PATCH) += patch.o
+
 //usage:#define patch_trivial_usage
 //usage:       "[OPTIONS] [ORIGFILE [PATCHFILE]]"
 //usage:#define patch_full_usage "\n\n"
@@ -39,7 +40,7 @@
 //usage:     "\n       -i,--input DIFF         Read DIFF instead of stdin"
 //usage:     "\n       -R,--reverse            Reverse patch"
 //usage:     "\n       -N,--forward            Ignore already applied patches"
-//usage:     "\n       --dry-run               Don't actually change files"
+/*usage:     "\n       --dry-run               Don't actually change files" - TODO */
 //usage:     "\n       -E,--remove-empty-files Remove output files if they become empty"
 //usage:       )
 //usage:       IF_NOT_LONG_OPTS(
@@ -49,6 +50,8 @@
 //usage:     "\n       -N      Ignore already applied patches"
 //usage:     "\n       -E      Remove output files if they become empty"
 //usage:       )
+/* -u "interpret as unified diff" is supported but not documented: this info is not useful for --help */
+/* -x "debug" is supported but does nothing */
 //usage:
 //usage:#define patch_example_usage
 //usage:       "$ patch -p1 < example.diff\n"
 
 #include "libbb.h"
 
+
+// libbb candidate?
+
 struct double_list {
        struct double_list *next;
        struct double_list *prev;
        char *data;
 };
 
-// Return the first item from the list, advancing the list (which must be called
-// as &list)
-static
-void *TOY_llist_pop(void *list)
-{
-       // I'd use a void ** for the argument, and even accept the typecast in all
-       // callers as documentation you need the &, except the stupid compiler
-       // would then scream about type-punned pointers.  Screw it.
-       void **llist = (void **)list;
-       void **next = (void **)*llist;
-       *llist = *next;
-
-       return (void *)next;
-}
-
 // Free all the elements of a linked list
-// if freeit!=NULL call freeit() on each element before freeing it.
-static
-void TOY_llist_free(void *list, void (*freeit)(void *data))
+// Call freeit() on each element before freeing it.
+static void dlist_free(struct double_list *list, void (*freeit)(void *data))
 {
        while (list) {
-               void *pop = TOY_llist_pop(&list);
-               if (freeit) freeit(pop);
-               else free(pop);
-
-               // End doubly linked list too.
-               if (list==pop) break;
+               void *pop = list;
+               list = list->next;
+               freeit(pop);
+               // Bail out also if list is circular.
+               if (list == pop) break;
        }
 }
-//Override bbox's names
-#define llist_pop TOY_llist_pop
-#define llist_free TOY_llist_free
 
-// Add an entry to the end off a doubly linked list
-static
-struct double_list *dlist_add(struct double_list **list, char *data)
+// Add an entry before "list" element in (circular) doubly linked list
+static struct double_list *dlist_add(struct double_list **list, char *data)
 {
-       struct double_list *line = xmalloc(sizeof(struct double_list));
+       struct double_list *llist;
+       struct double_list *line = xmalloc(sizeof(*line));
 
        line->data = data;
-       if (*list) {
-               line->next = *list;
-               line->prev = (*list)->prev;
-               (*list)->prev->next = line;
-               (*list)->prev = line;
-       } else *list = line->next = line->prev = line;
+       llist = *list;
+       if (llist) {
+               struct double_list *p;
+               line->next = llist;
+               p = line->prev = llist->prev;
+               // (list is circular, we assume p is never NULL)
+               p->next = line;
+               llist->prev = line;
+       } else
+               *list = line->next = line->prev = line;
 
        return line;
 }
 
 
-
 struct globals {
        char *infile;
        long prefix;
 
        struct double_list *current_hunk;
+
        long oldline, oldlen, newline, newlen;
        long linenum;
-       int context, state, filein, fileout, hunknum;
+       int context, state, hunknum;
+       int filein, fileout;
        char *tempname;
 
-       // was toys.foo:
        int exitval;
 };
 #define TT (*ptr_to_globals)
@@ -141,8 +131,8 @@ struct globals {
 #define FLAG_INPUT   (1 << 3)
 #define FLAG_IGNORE  (1 << 4)
 #define FLAG_RMEMPTY (1 << 5)
-//non-standard:
-#define FLAG_DEBUG   (1 << 6)
+/* Enable this bit and use -x for debug output: */
+#define FLAG_DEBUG   (0 << 6)
 
 // Dispose of a line of input, either by writing it out or discarding it.
 
@@ -193,7 +183,6 @@ static void finish_oldfile(void)
 static void fail_hunk(void)
 {
        if (!TT.current_hunk) return;
-       TT.current_hunk->prev->next = NULL;
 
        fdprintf(2, "Hunk %d FAILED %ld/%ld.\n", TT.hunknum, TT.oldline, TT.newline);
        TT.exitval = 1;
@@ -202,7 +191,8 @@ static void fail_hunk(void)
        // this file and advance to next file.
 
        TT.state = 2;
-       llist_free(TT.current_hunk, do_line);
+       TT.current_hunk->prev->next = NULL;
+       dlist_free(TT.current_hunk, do_line);
        TT.current_hunk = NULL;
 
        // Abort the copy and delete the temporary file.
@@ -240,7 +230,7 @@ static int apply_one_hunk(void)
                else matcheof = 0;
                if (PATCH_DEBUG) fdprintf(2, "HUNK:%s\n", plist->data);
        }
-       matcheof = matcheof < TT.context;
+       matcheof = !matcheof || matcheof < TT.context;
 
        if (PATCH_DEBUG) fdprintf(2,"MATCHEOF=%c\n", matcheof ? 'Y' : 'N');
 
@@ -249,8 +239,8 @@ static int apply_one_hunk(void)
        // complete hunk.
        plist = TT.current_hunk;
        buf = NULL;
-       if (TT.context) for (;;) {
-               char *data = xmalloc_reads(TT.filein, NULL, NULL);
+       if (reverse ? TT.oldlen : TT.newlen) for (;;) {
+               char *data = xmalloc_reads(TT.filein, NULL);
 
                TT.linenum++;
 
@@ -308,7 +298,8 @@ static int apply_one_hunk(void)
                                        fdprintf(2, "NOT: %s\n", plist->data);
 
                                TT.state = 3;
-                               check = llist_pop(&buf);
+                               check = buf;
+                               buf = buf->next;
                                check->prev->next = buf;
                                buf->prev = check->prev;
                                do_line(check);
@@ -335,13 +326,13 @@ static int apply_one_hunk(void)
 out:
        // We have a match.  Emit changed data.
        TT.state = "-+"[reverse ^ dummy_revert];
-       llist_free(TT.current_hunk, do_line);
+       dlist_free(TT.current_hunk, do_line);
        TT.current_hunk = NULL;
        TT.state = 1;
 done:
        if (buf) {
                buf->prev->next = NULL;
-               llist_free(buf, do_line);
+               dlist_free(buf, do_line);
        }
 
        return TT.state;
@@ -362,6 +353,8 @@ int patch_main(int argc UNUSED_PARAM, char **argv)
        int reverse, state = 0;
        char *oldname = NULL, *newname = NULL;
        char *opt_p, *opt_i;
+       long oldlen = oldlen; /* for compiler */
+       long newlen = newlen; /* for compiler */
 
        INIT_TT();
 
@@ -401,8 +394,8 @@ int patch_main(int argc UNUSED_PARAM, char **argv)
                        if (*patchline==' ' || *patchline=='+' || *patchline=='-') {
                                dlist_add(&TT.current_hunk, patchline);
 
-                               if (*patchline != '+') TT.oldlen--;
-                               if (*patchline != '-') TT.newlen--;
+                               if (*patchline != '+') oldlen--;
+                               if (*patchline != '-') newlen--;
 
                                // Context line?
                                if (*patchline==' ' && state==2) TT.context++;
@@ -410,7 +403,7 @@ int patch_main(int argc UNUSED_PARAM, char **argv)
 
                                // If we've consumed all expected hunk lines, apply the hunk.
 
-                               if (!TT.oldlen && !TT.newlen) state = apply_one_hunk();
+                               if (!oldlen && !newlen) state = apply_one_hunk();
                                continue;
                        }
                        fail_hunk();
@@ -457,11 +450,14 @@ int patch_main(int argc UNUSED_PARAM, char **argv)
 
                        // Read oldline[,oldlen] +newline[,newlen]
 
-                       TT.oldlen = TT.newlen = 1;
+                       TT.oldlen = oldlen = TT.newlen = newlen = 1;
                        TT.oldline = strtol(s, &s, 10);
-                       if (*s == ',') TT.oldlen=strtol(s+1, &s, 10);
+                       if (*s == ',') TT.oldlen = oldlen = strtol(s+1, &s, 10);
                        TT.newline = strtol(s+2, &s, 10);
-                       if (*s == ',') TT.newlen = strtol(s+1, &s, 10);
+                       if (*s == ',') TT.newlen = newlen = strtol(s+1, &s, 10);
+
+                       if (oldlen < 1 && newlen < 1)
+                               bb_error_msg_and_die("Really? %s", patchline);
 
                        TT.context = 0;
                        state = 2;
@@ -471,26 +467,28 @@ int patch_main(int argc UNUSED_PARAM, char **argv)
                                int oldsum, newsum, empty = 0;
                                char *name;
 
-                               oldsum = TT.oldline + TT.oldlen;
-                               newsum = TT.newline + TT.newlen;
+                               oldsum = TT.oldline + oldlen;
+                               newsum = TT.newline + newlen;
 
                                name = reverse ? oldname : newname;
 
                                // We're deleting oldname if new file is /dev/null (before -p)
                                // or if new hunk is empty (zero context) after patching
-                               if (!strcmp(name, "/dev/null") || !(reverse ? oldsum : newsum))
-                               {
+                               if (!strcmp(name, "/dev/null") || !(reverse ? oldsum : newsum)) {
                                        name = reverse ? newname : oldname;
                                        empty++;
                                }
 
                                // handle -p path truncation.
-                               for (i=0, s = name; *s;) {
-                                       if ((option_mask32 & FLAG_PATHLEN) && TT.prefix == i) break;
-                                       if (*(s++)=='/') {
-                                               name = s;
-                                               i++;
-                                       }
+                               for (i = 0, s = name; *s;) {
+                                       if ((option_mask32 & FLAG_PATHLEN) && TT.prefix == i)
+                                               break;
+                                       if (*s++ != '/')
+                                               continue;
+                                       while (*s == '/')
+                                               s++;
+                                       i++;
+                                       name = s;
                                }
 
                                if (empty) {