find:: get rid of nested function (it's a gcc-ism)

[oweals/busybox.git] / editors / cmp.c

diff --git a/editors/cmp.c b/editors/cmp.c
index 384e57c22faa1b572658459f9240ebab3ed67f67..fbe6b975387d7419c5e1614cc36c1dbbb3d8632c 100644 (file)
--- a/editors/cmp.c
+++ b/editors/cmp.c
@@ -4,29 +4,26 @@
  *
  * Copyright (C) 2000,2001 by Matt Kraai <kraai@alumni.carnegiemellon.edu>
  *
- * Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
+ * Licensed under GPLv2 or later, see file LICENSE in this source tree.
  */
 
 /* BB_AUDIT SUSv3 (virtually) compliant -- uses nicer GNU format for -l. */
 /* http://www.opengroup.org/onlinepubs/007904975/utilities/cmp.html */
 
-/* Mar 16, 2003      Manuel Novoa III   (mjn3@codepoet.org)
- *
- * Original version majorly reworked for SUSv3 compliance, bug fixes, and
- * size optimizations.  Changes include:
- * 1) Now correctly distinguishes between errors and actual file differences.
- * 2) Proper handling of '-' args.
- * 3) Actual error checking of i/o.
- * 4) Accept SUSv3 -l option.  Note that we use the slightly nicer gnu format
- *    in the '-l' case.
- */
+//usage:#define cmp_trivial_usage
+//usage:       "[-l] [-s] FILE1 [FILE2" IF_DESKTOP(" [SKIP1 [SKIP2]]") "]"
+//usage:#define cmp_full_usage "\n\n"
+//usage:       "Compare FILE1 with FILE2 (or stdin)\n"
+//usage:     "\n       -l      Write the byte numbers (decimal) and values (octal)"
+//usage:     "\n               for all differing bytes"
+//usage:     "\n       -s      Quiet"
 
 #include "libbb.h"
 
 static const char fmt_eof[] ALIGN1 = "cmp: EOF on %s\n";
-static const char fmt_differ[] ALIGN1 = "%s %s differ: char %"OFF_FMT"d, line %d\n";
-// This fmt_l_opt uses gnu-isms.  SUSv3 would be "%.0s%.0s%"OFF_FMT"d %o %o\n"
-static const char fmt_l_opt[] ALIGN1 = "%.0s%.0s%"OFF_FMT"d %3o %3o\n";
+static const char fmt_differ[] ALIGN1 = "%s %s differ: char %"OFF_FMT"u, line %u\n";
+// This fmt_l_opt uses gnu-isms.  SUSv3 would be "%.0s%.0s%"OFF_FMT"u %o %o\n"
+static const char fmt_l_opt[] ALIGN1 = "%.0s%.0s%"OFF_FMT"u %3o %3o\n";
 
 static const char opt_chars[] ALIGN1 = "sl";
 #define CMP_OPT_s (1<<0)
@@ -37,16 +34,13 @@ int cmp_main(int argc UNUSED_PARAM, char **argv)
 {
        FILE *fp1, *fp2, *outfile = stdout;
        const char *filename1, *filename2 = "-";
-       IF_DESKTOP(off_t skip1 = 0, skip2 = 0;)
-       off_t char_pos = 0;
+       off_t skip1 = 0, skip2 = 0, char_pos = 0;
        int line_pos = 1; /* Hopefully won't overflow... */
        const char *fmt;
        int c1, c2;
        unsigned opt;
        int retval = 0;
 
-       xfunc_error_retval = 2; /* 1 is returned if files are different. */
-
        opt_complementary = "-1"
                        IF_DESKTOP(":?4")
                        IF_NOT_DESKTOP(":?2")
@@ -55,20 +49,20 @@ int cmp_main(int argc UNUSED_PARAM, char **argv)
        argv += optind;
 
        filename1 = *argv;
-       fp1 = xfopen_stdin(filename1);
-
        if (*++argv) {
                filename2 = *argv;
-#if ENABLE_DESKTOP
-               if (*++argv) {
+               if (ENABLE_DESKTOP && *++argv) {
                        skip1 = XATOOFF(*argv);
                        if (*++argv) {
                                skip2 = XATOOFF(*argv);
                        }
                }
-#endif
        }
 
+       xfunc_error_retval = 2;  /* missing file results in exitcode 2 */
+       if (opt & CMP_OPT_s)
+               logmode = 0;  /* -s suppresses open error messages */
+       fp1 = xfopen_stdin(filename1);
        fp2 = xfopen_stdin(filename2);
        if (fp1 == fp2) {               /* Paranoia check... stdin == stdin? */
                /* Note that we don't bother reading stdin.  Neither does gnu wc.
@@ -77,16 +71,17 @@ int cmp_main(int argc UNUSED_PARAM, char **argv)
                 */
                return 0;
        }
+       logmode = LOGMODE_STDIO;
 
        if (opt & CMP_OPT_l)
                fmt = fmt_l_opt;
        else
                fmt = fmt_differ;
 
-#if ENABLE_DESKTOP
-       while (skip1) { getc(fp1); skip1--; }
-       while (skip2) { getc(fp2); skip2--; }
-#endif
+       if (ENABLE_DESKTOP) {
+               while (skip1) { getc(fp1); skip1--; }
+               while (skip2) { getc(fp2); skip2--; }
+       }
        do {
                c1 = getc(fp1);
                c2 = getc(fp2);