arm: bcm283x: serial: Move ofdata reading to probe() method

[oweals/u-boot.git] / drivers / serial / serial-uclass.c

diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
index 68ca2d09d1b30a9054e2021538366cd90f4a6c1f..7703c674929ceae005cf7e71d41f88fc9475f68c 100644 (file)
--- a/drivers/serial/serial-uclass.c
+++ b/drivers/serial/serial-uclass.c
@@ -1,13 +1,13 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Copyright (c) 2014 The Chromium OS Authors.
- *
- * SPDX-License-Identifier:    GPL-2.0+
  */
 
 #include <common.h>
 #include <dm.h>
-#include <environment.h>
+#include <env_internal.h>
 #include <errno.h>
+#include <malloc.h>
 #include <os.h>
 #include <serial.h>
 #include <stdio_dev.h>
@@ -27,31 +27,34 @@ static const unsigned long baudrate_table[] = CONFIG_SYS_BAUDRATE_TABLE;
 #error "Serial is required before relocation - define CONFIG_$(SPL_)SYS_MALLOC_F_LEN to make this work"
 #endif
 
+#if CONFIG_IS_ENABLED(SERIAL_PRESENT)
 static int serial_check_stdout(const void *blob, struct udevice **devp)
 {
-       int node;
+       int node = -1;
+       const char *str, *p, *name;
+       int namelen;
 
        /* Check for a chosen console */
-       node = fdtdec_get_chosen_node(blob, "stdout-path");
-       if (node < 0) {
-               const char *str, *p, *name;
-
-               /*
-                * Deal with things like
-                *      stdout-path = "serial0:115200n8";
-                *
-                * We need to look up the alias and then follow it to the
-                * correct node.
-                */
-               str = fdtdec_get_chosen_prop(blob, "stdout-path");
-               if (str) {
-                       p = strchr(str, ':');
-                       name = fdt_get_alias_namelen(blob, str,
-                                       p ? p - str : strlen(str));
+       str = fdtdec_get_chosen_prop(blob, "stdout-path");
+       if (str) {
+               p = strchr(str, ':');
+               namelen = p ? p - str : strlen(str);
+               node = fdt_path_offset_namelen(blob, str, namelen);
+
+               if (node < 0) {
+                       /*
+                        * Deal with things like
+                        *      stdout-path = "serial0:115200n8";
+                        *
+                        * We need to look up the alias and then follow it to
+                        * the correct node.
+                        */
+                       name = fdt_get_alias_namelen(blob, str, namelen);
                        if (name)
                                node = fdt_path_offset(blob, name);
                }
        }
+
        if (node < 0)
                node = fdt_path_offset(blob, "console");
        if (!uclass_get_device_by_of_offset(UCLASS_SERIAL, node, devp))
@@ -62,7 +65,7 @@ static int serial_check_stdout(const void *blob, struct udevice **devp)
         * anyway.
         */
        if (node > 0 && !lists_bind_fdt(gd->dm_root, offset_to_ofnode(node),
-                                       devp)) {
+                                       devp, false)) {
                if (!device_probe(*devp))
                        return 0;
        }
@@ -74,7 +77,9 @@ static void serial_find_console_or_panic(void)
 {
        const void *blob = gd->fdt_blob;
        struct udevice *dev;
+#ifdef CONFIG_SERIAL_SEARCH_ALL
        int ret;
+#endif
 
        if (CONFIG_IS_ENABLED(OF_PLATDATA)) {
                uclass_first_device(UCLASS_SERIAL, &dev);
@@ -113,6 +118,8 @@ static void serial_find_console_or_panic(void)
 #else
 #define INDEX 0
 #endif
+
+#ifdef CONFIG_SERIAL_SEARCH_ALL
                if (!uclass_get_device_by_seq(UCLASS_SERIAL, INDEX, &dev) ||
                    !uclass_get_device(UCLASS_SERIAL, INDEX, &dev)) {
                        if (dev->flags & DM_FLAG_ACTIVATED) {
@@ -131,6 +138,15 @@ static void serial_find_console_or_panic(void)
                                return;
                        }
                }
+#else
+               if (!uclass_get_device_by_seq(UCLASS_SERIAL, INDEX, &dev) ||
+                   !uclass_get_device(UCLASS_SERIAL, INDEX, &dev) ||
+                   (!uclass_first_device(UCLASS_SERIAL, &dev) && dev)) {
+                       gd->cur_serial_dev = dev;
+                       return;
+               }
+#endif
+
 #undef INDEX
        }
 
@@ -138,12 +154,16 @@ static void serial_find_console_or_panic(void)
        panic_str("No serial driver found");
 #endif
 }
+#endif /* CONFIG_SERIAL_PRESENT */
 
 /* Called prior to relocation */
 int serial_init(void)
 {
+#if CONFIG_IS_ENABLED(SERIAL_PRESENT)
        serial_find_console_or_panic();
        gd->flags |= GD_FLG_SERIAL_READY;
+       serial_setbrg();
+#endif
 
        return 0;
 }
@@ -216,6 +236,9 @@ static int _serial_getc(struct udevice *dev)
        struct serial_dev_priv *upriv = dev_get_uclass_priv(dev);
        char val;
 
+       if (upriv->rd_ptr == upriv->wr_ptr)
+               return __serial_getc(dev);
+
        val = upriv->buf[upriv->rd_ptr++];
        upriv->rd_ptr %= CONFIG_SERIAL_RX_BUFFER_SIZE;
 
@@ -275,6 +298,44 @@ void serial_setbrg(void)
                ops->setbrg(gd->cur_serial_dev, gd->baudrate);
 }
 
+int serial_getconfig(struct udevice *dev, uint *config)
+{
+       struct dm_serial_ops *ops;
+
+       ops = serial_get_ops(dev);
+       if (ops->getconfig)
+               return ops->getconfig(dev, config);
+
+       return 0;
+}
+
+int serial_setconfig(struct udevice *dev, uint config)
+{
+       struct dm_serial_ops *ops;
+
+       ops = serial_get_ops(dev);
+       if (ops->setconfig)
+               return ops->setconfig(dev, config);
+
+       return 0;
+}
+
+int serial_getinfo(struct udevice *dev, struct serial_device_info *info)
+{
+       struct dm_serial_ops *ops;
+
+       if (!info)
+               return -EINVAL;
+
+       info->baudrate = gd->baudrate;
+
+       ops = serial_get_ops(dev);
+       if (ops->getinfo)
+               return ops->getinfo(dev, info);
+
+       return -EINVAL;
+}
+
 void serial_stdio_init(void)
 {
 }
@@ -386,10 +447,16 @@ static int serial_post_probe(struct udevice *dev)
                ops->pending += gd->reloc_off;
        if (ops->clear)
                ops->clear += gd->reloc_off;
+       if (ops->getconfig)
+               ops->getconfig += gd->reloc_off;
+       if (ops->setconfig)
+               ops->setconfig += gd->reloc_off;
 #if CONFIG_POST & CONFIG_SYS_POST_UART
        if (ops->loop)
-               ops->loop += gd->reloc_off
+               ops->loop += gd->reloc_off;
 #endif
+       if (ops->getinfo)
+               ops->getinfo += gd->reloc_off;
 #endif
        /* Set the baud rate */
        if (ops->setbrg) {