net: smc911x: Invert the logic in smc911x_miiphy_{read,write}()

[oweals/u-boot.git] / drivers / net / smc911x.c

diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index 6da6c8954696e226265e16c524dc1e8b033da5c9..ceb4f81215212857c1c9830244f16684d6bfb82b 100644 (file)
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -216,24 +216,29 @@ static int smc911x_recv(struct eth_device *dev)
 static int smc911x_miiphy_read(struct mii_dev *bus, int phy, int devad,
                               int reg)
 {
-       u16 val = 0;
        struct eth_device *dev = eth_get_dev_by_name(bus->name);
-       if (dev) {
-               int retval = smc911x_eth_phy_read(dev, phy, reg, &val);
-               if (retval < 0)
-                       return retval;
-               return val;
-       }
-       return -ENODEV;
+       u16 val = 0;
+       int ret;
+
+       if (!dev)
+               return -ENODEV;
+
+       ret = smc911x_eth_phy_read(dev, phy, reg, &val);
+       if (ret < 0)
+               return ret;
+
+       return val;
 }
 /* wrapper for smc911x_eth_phy_write */
 static int smc911x_miiphy_write(struct mii_dev *bus, int phy, int devad,
                                int reg, u16 val)
 {
        struct eth_device *dev = eth_get_dev_by_name(bus->name);
-       if (dev)
-               return smc911x_eth_phy_write(dev, phy, reg, val);
-       return -ENODEV;
+
+       if (!dev)
+               return -ENODEV;
+
+       return smc911x_eth_phy_write(dev, phy, reg, val);
 }
 #endif