Merge git://git.denx.de/u-boot-x86
[oweals/u-boot.git] / drivers / misc / cros_ec.c
index e3229efed0bb44529653b662765705949e852b13..190505c11c74e06a6753353b6ade455ebea6ecac 100644 (file)
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Chromium OS cros_ec driver
  *
  * Copyright (c) 2012 The Chromium OS Authors.
- *
- * SPDX-License-Identifier:    GPL-2.0+
  */
 
 /*
 #include <fdtdec.h>
 #include <malloc.h>
 #include <spi.h>
-#include <asm/errno.h>
+#include <linux/errno.h>
 #include <asm/io.h>
 #include <asm-generic/gpio.h>
 #include <dm/device-internal.h>
-#include <dm/root.h>
+#include <dm/of_extra.h>
 #include <dm/uclass-internal.h>
 
 #ifdef DEBUG_TRACE
@@ -42,11 +41,6 @@ enum {
        CROS_EC_CMD_HASH_TIMEOUT_MS = 2000,
 };
 
-DECLARE_GLOBAL_DATA_PTR;
-
-/* Note: depends on enum ec_current_image */
-static const char * const ec_current_image_name[] = {"unknown", "RO", "RW"};
-
 void cros_ec_dump_data(const char *name, int cmd, const uint8_t *data, int len)
 {
 #ifdef DEBUG
@@ -89,15 +83,15 @@ int cros_ec_calc_checksum(const uint8_t *data, int size)
  * @param dout_len      Size of output data in bytes
  * @return packet size in bytes, or <0 if error.
  */
-static int create_proto3_request(struct cros_ec_dev *dev,
+static int create_proto3_request(struct cros_ec_dev *cdev,
                                 int cmd, int cmd_version,
                                 const void *dout, int dout_len)
 {
-       struct ec_host_request *rq = (struct ec_host_request *)dev->dout;
+       struct ec_host_request *rq = (struct ec_host_request *)cdev->dout;
        int out_bytes = dout_len + sizeof(*rq);
 
        /* Fail if output size is too big */
-       if (out_bytes > (int)sizeof(dev->dout)) {
+       if (out_bytes > (int)sizeof(cdev->dout)) {
                debug("%s: Cannot send %d bytes\n", __func__, dout_len);
                return -EC_RES_REQUEST_TRUNCATED;
        }
@@ -114,9 +108,9 @@ static int create_proto3_request(struct cros_ec_dev *dev,
        memcpy(rq + 1, dout, dout_len);
 
        /* Write checksum field so the entire packet sums to 0 */
-       rq->checksum = (uint8_t)(-cros_ec_calc_checksum(dev->dout, out_bytes));
+       rq->checksum = (uint8_t)(-cros_ec_calc_checksum(cdev->dout, out_bytes));
 
-       cros_ec_dump_data("out", cmd, dev->dout, out_bytes);
+       cros_ec_dump_data("out", cmd, cdev->dout, out_bytes);
 
        /* Return size of request packet */
        return out_bytes;
@@ -129,12 +123,12 @@ static int create_proto3_request(struct cros_ec_dev *dev,
  * @param din_len       Maximum size of response in bytes
  * @return maximum expected number of bytes in response, or <0 if error.
  */
-static int prepare_proto3_response_buffer(struct cros_ec_dev *dev, int din_len)
+static int prepare_proto3_response_buffer(struct cros_ec_dev *cdev, int din_len)
 {
        int in_bytes = din_len + sizeof(struct ec_host_response);
 
        /* Fail if input size is too big */
-       if (in_bytes > (int)sizeof(dev->din)) {
+       if (in_bytes > (int)sizeof(cdev->din)) {
                debug("%s: Cannot receive %d bytes\n", __func__, din_len);
                return -EC_RES_RESPONSE_TOO_BIG;
        }
@@ -203,7 +197,7 @@ static int handle_proto3_response(struct cros_ec_dev *dev,
        return rs->data_len;
 }
 
-static int send_command_proto3(struct cros_ec_dev *dev,
+static int send_command_proto3(struct cros_ec_dev *cdev,
                               int cmd, int cmd_version,
                               const void *dout, int dout_len,
                               uint8_t **dinp, int din_len)
@@ -213,23 +207,24 @@ static int send_command_proto3(struct cros_ec_dev *dev,
        int rv;
 
        /* Create request packet */
-       out_bytes = create_proto3_request(dev, cmd, cmd_version,
+       out_bytes = create_proto3_request(cdev, cmd, cmd_version,
                                          dout, dout_len);
        if (out_bytes < 0)
                return out_bytes;
 
        /* Prepare response buffer */
-       in_bytes = prepare_proto3_response_buffer(dev, din_len);
+       in_bytes = prepare_proto3_response_buffer(cdev, din_len);
        if (in_bytes < 0)
                return in_bytes;
 
-       ops = dm_cros_ec_get_ops(dev->dev);
-       rv = ops->packet ? ops->packet(dev->dev, out_bytes, in_bytes) : -ENOSYS;
+       ops = dm_cros_ec_get_ops(cdev->dev);
+       rv = ops->packet ? ops->packet(cdev->dev, out_bytes, in_bytes) :
+                       -ENOSYS;
        if (rv < 0)
                return rv;
 
        /* Process the response */
-       return handle_proto3_response(dev, dinp, din_len);
+       return handle_proto3_response(cdev, dinp, din_len);
 }
 
 static int send_command(struct cros_ec_dev *dev, uint8_t cmd, int cmd_version,
@@ -268,15 +263,16 @@ static int send_command(struct cros_ec_dev *dev, uint8_t cmd, int cmd_version,
  * @param din_len       Maximum size of response in bytes
  * @return number of bytes in response, or -ve on error
  */
-static int ec_command_inptr(struct cros_ec_dev *dev, uint8_t cmd,
-               int cmd_version, const void *dout, int dout_len, uint8_t **dinp,
-               int din_len)
+static int ec_command_inptr(struct udevice *dev, uint8_t cmd,
+                           int cmd_version, const void *dout, int dout_len,
+                           uint8_t **dinp, int din_len)
 {
+       struct cros_ec_dev *cdev = dev_get_uclass_priv(dev);
        uint8_t *din = NULL;
        int len;
 
-       len = send_command(dev, cmd, cmd_version, dout, dout_len,
-                               &din, din_len);
+       len = send_command(cdev, cmd, cmd_version, dout, dout_len, &din,
+                          din_len);
 
        /* If the command doesn't complete, wait a while */
        if (len == -EC_RES_IN_PROGRESS) {
@@ -289,9 +285,9 @@ static int ec_command_inptr(struct cros_ec_dev *dev, uint8_t cmd,
                        int ret;
 
                        mdelay(50);     /* Insert some reasonable delay */
-                       ret = send_command(dev, EC_CMD_GET_COMMS_STATUS, 0,
-                                       NULL, 0,
-                                       (uint8_t **)&resp, sizeof(*resp));
+                       ret = send_command(cdev, EC_CMD_GET_COMMS_STATUS, 0,
+                                          NULL, 0,
+                                          (uint8_t **)&resp, sizeof(*resp));
                        if (ret < 0)
                                return ret;
 
@@ -304,12 +300,11 @@ static int ec_command_inptr(struct cros_ec_dev *dev, uint8_t cmd,
 
                /* OK it completed, so read the status response */
                /* not sure why it was 0 for the last argument */
-               len = send_command(dev, EC_CMD_RESEND_RESPONSE, 0,
-                               NULL, 0, &din, din_len);
+               len = send_command(cdev, EC_CMD_RESEND_RESPONSE, 0, NULL, 0,
+                                  &din, din_len);
        }
 
-       debug("%s: len=%d, dinp=%p, *dinp=%p\n", __func__, len, dinp,
-             dinp ? *dinp : NULL);
+       debug("%s: len=%d, din=%p\n", __func__, len, din);
        if (dinp) {
                /* If we have any data to return, it must be 64bit-aligned */
                assert(len <= 0 || !((uintptr_t)din & 7));
@@ -335,7 +330,7 @@ static int ec_command_inptr(struct cros_ec_dev *dev, uint8_t cmd,
  * @param din_len       Maximum size of response in bytes
  * @return number of bytes in response, or -ve on error
  */
-static int ec_command(struct cros_ec_dev *dev, uint8_t cmd, int cmd_version,
+static int ec_command(struct udevice *dev, uint8_t cmd, int cmd_version,
                      const void *dout, int dout_len,
                      void *din, int din_len)
 {
@@ -344,7 +339,7 @@ static int ec_command(struct cros_ec_dev *dev, uint8_t cmd, int cmd_version,
 
        assert((din_len == 0) || din);
        len = ec_command_inptr(dev, cmd, cmd_version, dout, dout_len,
-                       &in_buffer, din_len);
+                              &in_buffer, din_len);
        if (len > 0) {
                /*
                 * If we were asked to put it somewhere, do so, otherwise just
@@ -360,16 +355,14 @@ static int ec_command(struct cros_ec_dev *dev, uint8_t cmd, int cmd_version,
 
 int cros_ec_scan_keyboard(struct udevice *dev, struct mbkp_keyscan *scan)
 {
-       struct cros_ec_dev *cdev = dev_get_uclass_priv(dev);
-
-       if (ec_command(cdev, EC_CMD_MKBP_STATE, 0, NULL, 0, scan,
+       if (ec_command(dev, EC_CMD_MKBP_STATE, 0, NULL, 0, scan,
                       sizeof(scan->data)) != sizeof(scan->data))
                return -1;
 
        return 0;
 }
 
-int cros_ec_read_id(struct cros_ec_dev *dev, char *id, int maxlen)
+int cros_ec_read_id(struct udevice *dev, char *id, int maxlen)
 {
        struct ec_response_get_version *r;
 
@@ -395,8 +388,8 @@ int cros_ec_read_id(struct cros_ec_dev *dev, char *id, int maxlen)
        return 0;
 }
 
-int cros_ec_read_version(struct cros_ec_dev *dev,
-                      struct ec_response_get_version **versionp)
+int cros_ec_read_version(struct udevice *dev,
+                        struct ec_response_get_version **versionp)
 {
        if (ec_command_inptr(dev, EC_CMD_GET_VERSION, 0, NULL, 0,
                        (uint8_t **)versionp, sizeof(**versionp))
@@ -406,7 +399,7 @@ int cros_ec_read_version(struct cros_ec_dev *dev,
        return 0;
 }
 
-int cros_ec_read_build_info(struct cros_ec_dev *dev, char **strp)
+int cros_ec_read_build_info(struct udevice *dev, char **strp)
 {
        if (ec_command_inptr(dev, EC_CMD_GET_BUILD_INFO, 0, NULL, 0,
                        (uint8_t **)strp, EC_PROTO2_MAX_PARAM_SIZE) < 0)
@@ -415,8 +408,8 @@ int cros_ec_read_build_info(struct cros_ec_dev *dev, char **strp)
        return 0;
 }
 
-int cros_ec_read_current_image(struct cros_ec_dev *dev,
-               enum ec_current_image *image)
+int cros_ec_read_current_image(struct udevice *dev,
+                              enum ec_current_image *image)
 {
        struct ec_response_get_version *r;
 
@@ -428,8 +421,8 @@ int cros_ec_read_current_image(struct cros_ec_dev *dev,
        return 0;
 }
 
-static int cros_ec_wait_on_hash_done(struct cros_ec_dev *dev,
-                                 struct ec_response_vboot_hash *hash)
+static int cros_ec_wait_on_hash_done(struct udevice *dev,
+                                    struct ec_response_vboot_hash *hash)
 {
        struct ec_params_vboot_hash p;
        ulong start;
@@ -451,14 +444,14 @@ static int cros_ec_wait_on_hash_done(struct cros_ec_dev *dev,
        return 0;
 }
 
-
-int cros_ec_read_hash(struct cros_ec_dev *dev,
-               struct ec_response_vboot_hash *hash)
+int cros_ec_read_hash(struct udevice *dev, uint hash_offset,
+                     struct ec_response_vboot_hash *hash)
 {
        struct ec_params_vboot_hash p;
        int rv;
 
        p.cmd = EC_VBOOT_HASH_GET;
+       p.offset = hash_offset;
        if (ec_command(dev, EC_CMD_VBOOT_HASH, 0, &p, sizeof(p),
                       hash, sizeof(*hash)) < 0)
                return -1;
@@ -481,7 +474,7 @@ int cros_ec_read_hash(struct cros_ec_dev *dev,
        p.cmd = EC_VBOOT_HASH_START;
        p.hash_type = EC_VBOOT_HASH_TYPE_SHA256;
        p.nonce_size = 0;
-       p.offset = EC_VBOOT_HASH_OFFSET_RW;
+       p.offset = hash_offset;
 
        if (ec_command(dev, EC_CMD_VBOOT_HASH, 0, &p, sizeof(p),
                       hash, sizeof(*hash)) < 0)
@@ -496,7 +489,7 @@ int cros_ec_read_hash(struct cros_ec_dev *dev,
        return 0;
 }
 
-static int cros_ec_invalidate_hash(struct cros_ec_dev *dev)
+static int cros_ec_invalidate_hash(struct udevice *dev)
 {
        struct ec_params_vboot_hash p;
        struct ec_response_vboot_hash *hash;
@@ -521,8 +514,7 @@ static int cros_ec_invalidate_hash(struct cros_ec_dev *dev)
        return 0;
 }
 
-int cros_ec_reboot(struct cros_ec_dev *dev, enum ec_reboot_cmd cmd,
-               uint8_t flags)
+int cros_ec_reboot(struct udevice *dev, enum ec_reboot_cmd cmd, uint8_t flags)
 {
        struct ec_params_reboot_ec p;
 
@@ -562,7 +554,7 @@ int cros_ec_interrupt_pending(struct udevice *dev)
        return dm_gpio_get_value(&cdev->ec_int);
 }
 
-int cros_ec_info(struct cros_ec_dev *dev, struct ec_response_mkbp_info *info)
+int cros_ec_info(struct udevice *dev, struct ec_response_mkbp_info *info)
 {
        if (ec_command(dev, EC_CMD_MKBP_INFO, 0, NULL, 0, info,
                       sizeof(*info)) != sizeof(*info))
@@ -571,7 +563,7 @@ int cros_ec_info(struct cros_ec_dev *dev, struct ec_response_mkbp_info *info)
        return 0;
 }
 
-int cros_ec_get_host_events(struct cros_ec_dev *dev, uint32_t *events_ptr)
+int cros_ec_get_host_events(struct udevice *dev, uint32_t *events_ptr)
 {
        struct ec_response_host_event_mask *resp;
 
@@ -590,7 +582,7 @@ int cros_ec_get_host_events(struct cros_ec_dev *dev, uint32_t *events_ptr)
        return 0;
 }
 
-int cros_ec_clear_host_events(struct cros_ec_dev *dev, uint32_t events)
+int cros_ec_clear_host_events(struct udevice *dev, uint32_t events)
 {
        struct ec_params_host_event_mask params;
 
@@ -607,9 +599,9 @@ int cros_ec_clear_host_events(struct cros_ec_dev *dev, uint32_t events)
        return 0;
 }
 
-int cros_ec_flash_protect(struct cros_ec_dev *dev,
-                      uint32_t set_mask, uint32_t set_flags,
-                      struct ec_response_flash_protect *resp)
+int cros_ec_flash_protect(struct udevice *dev, uint32_t set_mask,
+                         uint32_t set_flags,
+                         struct ec_response_flash_protect *resp)
 {
        struct ec_params_flash_protect params;
 
@@ -624,17 +616,18 @@ int cros_ec_flash_protect(struct cros_ec_dev *dev,
        return 0;
 }
 
-static int cros_ec_check_version(struct cros_ec_dev *dev)
+static int cros_ec_check_version(struct udevice *dev)
 {
+       struct cros_ec_dev *cdev = dev_get_uclass_priv(dev);
        struct ec_params_hello req;
        struct ec_response_hello *resp;
 
        struct dm_cros_ec_ops *ops;
        int ret;
 
-       ops = dm_cros_ec_get_ops(dev->dev);
+       ops = dm_cros_ec_get_ops(dev);
        if (ops->check_version) {
-               ret = ops->check_version(dev->dev);
+               ret = ops->check_version(dev);
                if (ret)
                        return ret;
        }
@@ -654,7 +647,7 @@ static int cros_ec_check_version(struct cros_ec_dev *dev)
         */
 
        /* Try sending a version 3 packet */
-       dev->protocol_version = 3;
+       cdev->protocol_version = 3;
        req.in_data = 0;
        if (ec_command_inptr(dev, EC_CMD_HELLO, 0, &req, sizeof(req),
                             (uint8_t **)&resp, sizeof(*resp)) > 0) {
@@ -662,9 +655,9 @@ static int cros_ec_check_version(struct cros_ec_dev *dev)
        }
 
        /* Try sending a version 2 packet */
-       dev->protocol_version = 2;
+       cdev->protocol_version = 2;
        if (ec_command_inptr(dev, EC_CMD_HELLO, 0, &req, sizeof(req),
-                      (uint8_t **)&resp, sizeof(*resp)) > 0) {
+                            (uint8_t **)&resp, sizeof(*resp)) > 0) {
                return 0;
        }
 
@@ -674,12 +667,12 @@ static int cros_ec_check_version(struct cros_ec_dev *dev)
         * version is no longer supported, and we don't know about any new
         * protocol versions.
         */
-       dev->protocol_version = 0;
+       cdev->protocol_version = 0;
        printf("%s: ERROR: old EC interface not supported\n", __func__);
        return -1;
 }
 
-int cros_ec_test(struct cros_ec_dev *dev)
+int cros_ec_test(struct udevice *dev)
 {
        struct ec_params_hello req;
        struct ec_response_hello *resp;
@@ -698,7 +691,7 @@ int cros_ec_test(struct cros_ec_dev *dev)
        return 0;
 }
 
-int cros_ec_flash_offset(struct cros_ec_dev *dev, enum ec_flash_region region,
+int cros_ec_flash_offset(struct udevice *dev, enum ec_flash_region region,
                      uint32_t *offset, uint32_t *size)
 {
        struct ec_params_flash_region_info p;
@@ -720,7 +713,7 @@ int cros_ec_flash_offset(struct cros_ec_dev *dev, enum ec_flash_region region,
        return 0;
 }
 
-int cros_ec_flash_erase(struct cros_ec_dev *dev, uint32_t offset, uint32_t size)
+int cros_ec_flash_erase(struct udevice *dev, uint32_t offset, uint32_t size)
 {
        struct ec_params_flash_erase p;
 
@@ -748,24 +741,33 @@ int cros_ec_flash_erase(struct cros_ec_dev *dev, uint32_t offset, uint32_t size)
  * @param size         Number of bytes to write
  * @return 0 if ok, -1 on error
  */
-static int cros_ec_flash_write_block(struct cros_ec_dev *dev,
-               const uint8_t *data, uint32_t offset, uint32_t size)
+static int cros_ec_flash_write_block(struct udevice *dev, const uint8_t *data,
+                                    uint32_t offset, uint32_t size)
 {
-       struct ec_params_flash_write p;
+       struct ec_params_flash_write *p;
+       int ret;
 
-       p.offset = offset;
-       p.size = size;
-       assert(data && p.size <= EC_FLASH_WRITE_VER0_SIZE);
-       memcpy(&p + 1, data, p.size);
+       p = malloc(sizeof(*p) + size);
+       if (!p)
+               return -ENOMEM;
 
-       return ec_command_inptr(dev, EC_CMD_FLASH_WRITE, 0,
-                         &p, sizeof(p), NULL, 0) >= 0 ? 0 : -1;
+       p->offset = offset;
+       p->size = size;
+       assert(data && p->size <= EC_FLASH_WRITE_VER0_SIZE);
+       memcpy(p + 1, data, p->size);
+
+       ret = ec_command_inptr(dev, EC_CMD_FLASH_WRITE, 0,
+                         p, sizeof(*p) + size, NULL, 0) >= 0 ? 0 : -1;
+
+       free(p);
+
+       return ret;
 }
 
 /**
  * Return optimal flash write burst size
  */
-static int cros_ec_flash_write_burst_size(struct cros_ec_dev *dev)
+static int cros_ec_flash_write_burst_size(struct udevice *dev)
 {
        return EC_FLASH_WRITE_VER0_SIZE;
 }
@@ -791,9 +793,31 @@ static int cros_ec_data_is_erased(const uint32_t *data, int size)
        return 1;
 }
 
-int cros_ec_flash_write(struct cros_ec_dev *dev, const uint8_t *data,
-                    uint32_t offset, uint32_t size)
+/**
+ * Read back flash parameters
+ *
+ * This function reads back parameters of the flash as reported by the EC
+ *
+ * @param dev  Pointer to device
+ * @param info Pointer to output flash info struct
+ */
+int cros_ec_read_flashinfo(struct udevice *dev,
+                          struct ec_response_flash_info *info)
+{
+       int ret;
+
+       ret = ec_command(dev, EC_CMD_FLASH_INFO, 0,
+                        NULL, 0, info, sizeof(*info));
+       if (ret < 0)
+               return ret;
+
+       return ret < sizeof(*info) ? -1 : 0;
+}
+
+int cros_ec_flash_write(struct udevice *dev, const uint8_t *data,
+                       uint32_t offset, uint32_t size)
 {
+       struct cros_ec_dev *cdev = dev_get_uclass_priv(dev);
        uint32_t burst = cros_ec_flash_write_burst_size(dev);
        uint32_t end, off;
        int ret;
@@ -808,8 +832,8 @@ int cros_ec_flash_write(struct cros_ec_dev *dev, const uint8_t *data,
 
                /* If the data is empty, there is no point in programming it */
                todo = min(end - off, burst);
-               if (dev->optimise_flash_write &&
-                               cros_ec_data_is_erased((uint32_t *)data, todo))
+               if (cdev->optimise_flash_write &&
+                   cros_ec_data_is_erased((uint32_t *)data, todo))
                        continue;
 
                ret = cros_ec_flash_write_block(dev, data, off, todo);
@@ -835,8 +859,8 @@ int cros_ec_flash_write(struct cros_ec_dev *dev, const uint8_t *data,
  * @param size         Number of bytes to read
  * @return 0 if ok, -1 on error
  */
-static int cros_ec_flash_read_block(struct cros_ec_dev *dev, uint8_t *data,
-                                uint32_t offset, uint32_t size)
+static int cros_ec_flash_read_block(struct udevice *dev, uint8_t *data,
+                                   uint32_t offset, uint32_t size)
 {
        struct ec_params_flash_read p;
 
@@ -847,8 +871,8 @@ static int cros_ec_flash_read_block(struct cros_ec_dev *dev, uint8_t *data,
                          &p, sizeof(p), data, size) >= 0 ? 0 : -1;
 }
 
-int cros_ec_flash_read(struct cros_ec_dev *dev, uint8_t *data, uint32_t offset,
-                   uint32_t size)
+int cros_ec_flash_read(struct udevice *dev, uint8_t *data, uint32_t offset,
+                      uint32_t size)
 {
        uint32_t burst = cros_ec_flash_write_burst_size(dev);
        uint32_t end, off;
@@ -865,13 +889,14 @@ int cros_ec_flash_read(struct cros_ec_dev *dev, uint8_t *data, uint32_t offset,
        return 0;
 }
 
-int cros_ec_flash_update_rw(struct cros_ec_dev *dev,
-                        const uint8_t *image, int image_size)
+int cros_ec_flash_update_rw(struct udevice *dev, const uint8_t *image,
+                           int image_size)
 {
        uint32_t rw_offset, rw_size;
        int ret;
 
-       if (cros_ec_flash_offset(dev, EC_FLASH_REGION_RW, &rw_offset, &rw_size))
+       if (cros_ec_flash_offset(dev, EC_FLASH_REGION_ACTIVE, &rw_offset,
+               &rw_size))
                return -1;
        if (image_size > (int)rw_size)
                return -1;
@@ -904,26 +929,31 @@ int cros_ec_flash_update_rw(struct cros_ec_dev *dev,
        return 0;
 }
 
-int cros_ec_read_vbnvcontext(struct cros_ec_dev *dev, uint8_t *block)
+int cros_ec_read_nvdata(struct udevice *dev, uint8_t *block, int size)
 {
        struct ec_params_vbnvcontext p;
        int len;
 
+       if (size != EC_VBNV_BLOCK_SIZE)
+               return -EINVAL;
+
        p.op = EC_VBNV_CONTEXT_OP_READ;
 
        len = ec_command(dev, EC_CMD_VBNV_CONTEXT, EC_VER_VBNV_CONTEXT,
                        &p, sizeof(p), block, EC_VBNV_BLOCK_SIZE);
        if (len < EC_VBNV_BLOCK_SIZE)
-               return -1;
+               return -EIO;
 
        return 0;
 }
 
-int cros_ec_write_vbnvcontext(struct cros_ec_dev *dev, const uint8_t *block)
+int cros_ec_write_nvdata(struct udevice *dev, const uint8_t *block, int size)
 {
        struct ec_params_vbnvcontext p;
        int len;
 
+       if (size != EC_VBNV_BLOCK_SIZE)
+               return -EINVAL;
        p.op = EC_VBNV_CONTEXT_OP_WRITE;
        memcpy(p.block, block, sizeof(p.block));
 
@@ -937,13 +967,12 @@ int cros_ec_write_vbnvcontext(struct cros_ec_dev *dev, const uint8_t *block)
 
 int cros_ec_set_ldo(struct udevice *dev, uint8_t index, uint8_t state)
 {
-       struct cros_ec_dev *cdev = dev_get_uclass_priv(dev);
        struct ec_params_ldo_set params;
 
        params.index = index;
        params.state = state;
 
-       if (ec_command_inptr(cdev, EC_CMD_LDO_SET, 0, &params, sizeof(params),
+       if (ec_command_inptr(dev, EC_CMD_LDO_SET, 0, &params, sizeof(params),
                             NULL, 0))
                return -1;
 
@@ -952,13 +981,12 @@ int cros_ec_set_ldo(struct udevice *dev, uint8_t index, uint8_t state)
 
 int cros_ec_get_ldo(struct udevice *dev, uint8_t index, uint8_t *state)
 {
-       struct cros_ec_dev *cdev = dev_get_uclass_priv(dev);
        struct ec_params_ldo_get params;
        struct ec_response_ldo_get *resp;
 
        params.index = index;
 
-       if (ec_command_inptr(cdev, EC_CMD_LDO_GET, 0, &params, sizeof(params),
+       if (ec_command_inptr(dev, EC_CMD_LDO_GET, 0, &params, sizeof(params),
                             (uint8_t **)&resp, sizeof(*resp)) !=
                             sizeof(*resp))
                return -1;
@@ -971,22 +999,19 @@ int cros_ec_get_ldo(struct udevice *dev, uint8_t index, uint8_t *state)
 int cros_ec_register(struct udevice *dev)
 {
        struct cros_ec_dev *cdev = dev_get_uclass_priv(dev);
-       const void *blob = gd->fdt_blob;
-       int node = dev->of_offset;
        char id[MSG_BYTES];
 
        cdev->dev = dev;
        gpio_request_by_name(dev, "ec-interrupt", 0, &cdev->ec_int,
                             GPIOD_IS_IN);
-       cdev->optimise_flash_write = fdtdec_get_bool(blob, node,
-                                                    "optimise-flash-write");
+       cdev->optimise_flash_write = dev_read_bool(dev, "optimise-flash-write");
 
-       if (cros_ec_check_version(cdev)) {
+       if (cros_ec_check_version(dev)) {
                debug("%s: Could not detect CROS-EC version\n", __func__);
                return -CROS_EC_ERR_CHECK_VERSION;
        }
 
-       if (cros_ec_read_id(cdev, id, sizeof(id))) {
+       if (cros_ec_read_id(dev, id, sizeof(id))) {
                debug("%s: Could not read KBC ID\n", __func__);
                return -CROS_EC_ERR_READ_ID;
        }
@@ -998,50 +1023,31 @@ int cros_ec_register(struct udevice *dev)
        return 0;
 }
 
-int cros_ec_decode_region(int argc, char * const argv[])
+int cros_ec_decode_ec_flash(struct udevice *dev, struct fdt_cros_ec *config)
 {
-       if (argc > 0) {
-               if (0 == strcmp(*argv, "rw"))
-                       return EC_FLASH_REGION_RW;
-               else if (0 == strcmp(*argv, "ro"))
-                       return EC_FLASH_REGION_RO;
-
-               debug("%s: Invalid region '%s'\n", __func__, *argv);
-       } else {
-               debug("%s: Missing region parameter\n", __func__);
-       }
-
-       return -1;
-}
+       ofnode flash_node, node;
 
-int cros_ec_decode_ec_flash(const void *blob, int node,
-                           struct fdt_cros_ec *config)
-{
-       int flash_node;
-
-       flash_node = fdt_subnode_offset(blob, node, "flash");
-       if (flash_node < 0) {
+       flash_node = dev_read_subnode(dev, "flash");
+       if (!ofnode_valid(flash_node)) {
                debug("Failed to find flash node\n");
                return -1;
        }
 
-       if (fdtdec_read_fmap_entry(blob, flash_node, "flash",
-                                  &config->flash)) {
-               debug("Failed to decode flash node in chrome-ec'\n");
+       if (ofnode_read_fmap_entry(flash_node,  &config->flash)) {
+               debug("Failed to decode flash node in chrome-ec\n");
                return -1;
        }
 
-       config->flash_erase_value = fdtdec_get_int(blob, flash_node,
-                                                   "erase-value", -1);
-       for (node = fdt_first_subnode(blob, flash_node); node >= 0;
-            node = fdt_next_subnode(blob, node)) {
-               const char *name = fdt_get_name(blob, node, NULL);
+       config->flash_erase_value = ofnode_read_s32_default(flash_node,
+                                                           "erase-value", -1);
+       ofnode_for_each_subnode(node, flash_node) {
+               const char *name = ofnode_get_name(node);
                enum ec_flash_region region;
 
                if (0 == strcmp(name, "ro")) {
                        region = EC_FLASH_REGION_RO;
                } else if (0 == strcmp(name, "rw")) {
-                       region = EC_FLASH_REGION_RW;
+                       region = EC_FLASH_REGION_ACTIVE;
                } else if (0 == strcmp(name, "wp-ro")) {
                        region = EC_FLASH_REGION_WP_RO;
                } else {
@@ -1049,8 +1055,7 @@ int cros_ec_decode_ec_flash(const void *blob, int node,
                        return -1;
                }
 
-               if (fdtdec_read_fmap_entry(blob, node, "reg",
-                                          &config->region[region])) {
+               if (ofnode_read_fmap_entry(node, &config->region[region])) {
                        debug("Failed to decode flash region in chrome-ec'\n");
                        return -1;
                }
@@ -1059,9 +1064,9 @@ int cros_ec_decode_ec_flash(const void *blob, int node,
        return 0;
 }
 
-int cros_ec_i2c_tunnel(struct udevice *dev, struct i2c_msg *in, int nmsgs)
+int cros_ec_i2c_tunnel(struct udevice *dev, int port, struct i2c_msg *in,
+                      int nmsgs)
 {
-       struct cros_ec_dev *cdev = dev_get_uclass_priv(dev);
        union {
                struct ec_params_i2c_passthru p;
                uint8_t outbuf[EC_PROTO2_MAX_PARAM_SIZE];
@@ -1079,7 +1084,7 @@ int cros_ec_i2c_tunnel(struct udevice *dev, struct i2c_msg *in, int nmsgs)
        int rv;
        int i;
 
-       p->port = 0;
+       p->port = port;
 
        p->num_msgs = nmsgs;
        size = sizeof(*p) + p->num_msgs * sizeof(*msg);
@@ -1111,7 +1116,7 @@ int cros_ec_i2c_tunnel(struct udevice *dev, struct i2c_msg *in, int nmsgs)
                }
        }
 
-       rv = ec_command(cdev, EC_CMD_I2C_PASSTHRU, 0, p, pdata - (uint8_t *)p,
+       rv = ec_command(dev, EC_CMD_I2C_PASSTHRU, 0, p, pdata - (uint8_t *)p,
                        r, sizeof(*r) + read_len);
        if (rv < 0)
                return rv;
@@ -1134,353 +1139,9 @@ int cros_ec_i2c_tunnel(struct udevice *dev, struct i2c_msg *in, int nmsgs)
        return 0;
 }
 
-#ifdef CONFIG_CMD_CROS_EC
-
-/**
- * Perform a flash read or write command
- *
- * @param dev          CROS-EC device to read/write
- * @param is_write     1 do to a write, 0 to do a read
- * @param argc         Number of arguments
- * @param argv         Arguments (2 is region, 3 is address)
- * @return 0 for ok, 1 for a usage error or -ve for ec command error
- *     (negative EC_RES_...)
- */
-static int do_read_write(struct cros_ec_dev *dev, int is_write, int argc,
-                        char * const argv[])
-{
-       uint32_t offset, size = -1U, region_size;
-       unsigned long addr;
-       char *endp;
-       int region;
-       int ret;
-
-       region = cros_ec_decode_region(argc - 2, argv + 2);
-       if (region == -1)
-               return 1;
-       if (argc < 4)
-               return 1;
-       addr = simple_strtoul(argv[3], &endp, 16);
-       if (*argv[3] == 0 || *endp != 0)
-               return 1;
-       if (argc > 4) {
-               size = simple_strtoul(argv[4], &endp, 16);
-               if (*argv[4] == 0 || *endp != 0)
-                       return 1;
-       }
-
-       ret = cros_ec_flash_offset(dev, region, &offset, &region_size);
-       if (ret) {
-               debug("%s: Could not read region info\n", __func__);
-               return ret;
-       }
-       if (size == -1U)
-               size = region_size;
-
-       ret = is_write ?
-               cros_ec_flash_write(dev, (uint8_t *)addr, offset, size) :
-               cros_ec_flash_read(dev, (uint8_t *)addr, offset, size);
-       if (ret) {
-               debug("%s: Could not %s region\n", __func__,
-                     is_write ? "write" : "read");
-               return ret;
-       }
-
-       return 0;
-}
-
-static int do_cros_ec(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
-{
-       struct cros_ec_dev *dev;
-       struct udevice *udev;
-       const char *cmd;
-       int ret = 0;
-
-       if (argc < 2)
-               return CMD_RET_USAGE;
-
-       cmd = argv[1];
-       if (0 == strcmp("init", cmd)) {
-               /* Remove any existing device */
-               ret = uclass_find_device(UCLASS_CROS_EC, 0, &udev);
-               if (!ret)
-                       device_remove(udev);
-               ret = uclass_get_device(UCLASS_CROS_EC, 0, &udev);
-               if (ret) {
-                       printf("Could not init cros_ec device (err %d)\n", ret);
-                       return 1;
-               }
-               return 0;
-       }
-
-       ret = uclass_get_device(UCLASS_CROS_EC, 0, &udev);
-       if (ret) {
-               printf("Cannot get cros-ec device (err=%d)\n", ret);
-               return 1;
-       }
-       dev = dev_get_uclass_priv(udev);
-       if (0 == strcmp("id", cmd)) {
-               char id[MSG_BYTES];
-
-               if (cros_ec_read_id(dev, id, sizeof(id))) {
-                       debug("%s: Could not read KBC ID\n", __func__);
-                       return 1;
-               }
-               printf("%s\n", id);
-       } else if (0 == strcmp("info", cmd)) {
-               struct ec_response_mkbp_info info;
-
-               if (cros_ec_info(dev, &info)) {
-                       debug("%s: Could not read KBC info\n", __func__);
-                       return 1;
-               }
-               printf("rows     = %u\n", info.rows);
-               printf("cols     = %u\n", info.cols);
-               printf("switches = %#x\n", info.switches);
-       } else if (0 == strcmp("curimage", cmd)) {
-               enum ec_current_image image;
-
-               if (cros_ec_read_current_image(dev, &image)) {
-                       debug("%s: Could not read KBC image\n", __func__);
-                       return 1;
-               }
-               printf("%d\n", image);
-       } else if (0 == strcmp("hash", cmd)) {
-               struct ec_response_vboot_hash hash;
-               int i;
-
-               if (cros_ec_read_hash(dev, &hash)) {
-                       debug("%s: Could not read KBC hash\n", __func__);
-                       return 1;
-               }
-
-               if (hash.hash_type == EC_VBOOT_HASH_TYPE_SHA256)
-                       printf("type:    SHA-256\n");
-               else
-                       printf("type:    %d\n", hash.hash_type);
-
-               printf("offset:  0x%08x\n", hash.offset);
-               printf("size:    0x%08x\n", hash.size);
-
-               printf("digest:  ");
-               for (i = 0; i < hash.digest_size; i++)
-                       printf("%02x", hash.hash_digest[i]);
-               printf("\n");
-       } else if (0 == strcmp("reboot", cmd)) {
-               int region;
-               enum ec_reboot_cmd cmd;
-
-               if (argc >= 3 && !strcmp(argv[2], "cold"))
-                       cmd = EC_REBOOT_COLD;
-               else {
-                       region = cros_ec_decode_region(argc - 2, argv + 2);
-                       if (region == EC_FLASH_REGION_RO)
-                               cmd = EC_REBOOT_JUMP_RO;
-                       else if (region == EC_FLASH_REGION_RW)
-                               cmd = EC_REBOOT_JUMP_RW;
-                       else
-                               return CMD_RET_USAGE;
-               }
-
-               if (cros_ec_reboot(dev, cmd, 0)) {
-                       debug("%s: Could not reboot KBC\n", __func__);
-                       return 1;
-               }
-       } else if (0 == strcmp("events", cmd)) {
-               uint32_t events;
-
-               if (cros_ec_get_host_events(dev, &events)) {
-                       debug("%s: Could not read host events\n", __func__);
-                       return 1;
-               }
-               printf("0x%08x\n", events);
-       } else if (0 == strcmp("clrevents", cmd)) {
-               uint32_t events = 0x7fffffff;
-
-               if (argc >= 3)
-                       events = simple_strtol(argv[2], NULL, 0);
-
-               if (cros_ec_clear_host_events(dev, events)) {
-                       debug("%s: Could not clear host events\n", __func__);
-                       return 1;
-               }
-       } else if (0 == strcmp("read", cmd)) {
-               ret = do_read_write(dev, 0, argc, argv);
-               if (ret > 0)
-                       return CMD_RET_USAGE;
-       } else if (0 == strcmp("write", cmd)) {
-               ret = do_read_write(dev, 1, argc, argv);
-               if (ret > 0)
-                       return CMD_RET_USAGE;
-       } else if (0 == strcmp("erase", cmd)) {
-               int region = cros_ec_decode_region(argc - 2, argv + 2);
-               uint32_t offset, size;
-
-               if (region == -1)
-                       return CMD_RET_USAGE;
-               if (cros_ec_flash_offset(dev, region, &offset, &size)) {
-                       debug("%s: Could not read region info\n", __func__);
-                       ret = -1;
-               } else {
-                       ret = cros_ec_flash_erase(dev, offset, size);
-                       if (ret) {
-                               debug("%s: Could not erase region\n",
-                                     __func__);
-                       }
-               }
-       } else if (0 == strcmp("regioninfo", cmd)) {
-               int region = cros_ec_decode_region(argc - 2, argv + 2);
-               uint32_t offset, size;
-
-               if (region == -1)
-                       return CMD_RET_USAGE;
-               ret = cros_ec_flash_offset(dev, region, &offset, &size);
-               if (ret) {
-                       debug("%s: Could not read region info\n", __func__);
-               } else {
-                       printf("Region: %s\n", region == EC_FLASH_REGION_RO ?
-                                       "RO" : "RW");
-                       printf("Offset: %x\n", offset);
-                       printf("Size:   %x\n", size);
-               }
-       } else if (0 == strcmp("vbnvcontext", cmd)) {
-               uint8_t block[EC_VBNV_BLOCK_SIZE];
-               char buf[3];
-               int i, len;
-               unsigned long result;
-
-               if (argc <= 2) {
-                       ret = cros_ec_read_vbnvcontext(dev, block);
-                       if (!ret) {
-                               printf("vbnv_block: ");
-                               for (i = 0; i < EC_VBNV_BLOCK_SIZE; i++)
-                                       printf("%02x", block[i]);
-                               putc('\n');
-                       }
-               } else {
-                       /*
-                        * TODO(clchiou): Move this to a utility function as
-                        * cmd_spi might want to call it.
-                        */
-                       memset(block, 0, EC_VBNV_BLOCK_SIZE);
-                       len = strlen(argv[2]);
-                       buf[2] = '\0';
-                       for (i = 0; i < EC_VBNV_BLOCK_SIZE; i++) {
-                               if (i * 2 >= len)
-                                       break;
-                               buf[0] = argv[2][i * 2];
-                               if (i * 2 + 1 >= len)
-                                       buf[1] = '0';
-                               else
-                                       buf[1] = argv[2][i * 2 + 1];
-                               strict_strtoul(buf, 16, &result);
-                               block[i] = result;
-                       }
-                       ret = cros_ec_write_vbnvcontext(dev, block);
-               }
-               if (ret) {
-                       debug("%s: Could not %s VbNvContext\n", __func__,
-                                       argc <= 2 ?  "read" : "write");
-               }
-       } else if (0 == strcmp("test", cmd)) {
-               int result = cros_ec_test(dev);
-
-               if (result)
-                       printf("Test failed with error %d\n", result);
-               else
-                       puts("Test passed\n");
-       } else if (0 == strcmp("version", cmd)) {
-               struct ec_response_get_version *p;
-               char *build_string;
-
-               ret = cros_ec_read_version(dev, &p);
-               if (!ret) {
-                       /* Print versions */
-                       printf("RO version:    %1.*s\n",
-                              (int)sizeof(p->version_string_ro),
-                              p->version_string_ro);
-                       printf("RW version:    %1.*s\n",
-                              (int)sizeof(p->version_string_rw),
-                              p->version_string_rw);
-                       printf("Firmware copy: %s\n",
-                               (p->current_image <
-                                       ARRAY_SIZE(ec_current_image_name) ?
-                               ec_current_image_name[p->current_image] :
-                               "?"));
-                       ret = cros_ec_read_build_info(dev, &build_string);
-                       if (!ret)
-                               printf("Build info:    %s\n", build_string);
-               }
-       } else if (0 == strcmp("ldo", cmd)) {
-               uint8_t index, state;
-               char *endp;
-
-               if (argc < 3)
-                       return CMD_RET_USAGE;
-               index = simple_strtoul(argv[2], &endp, 10);
-               if (*argv[2] == 0 || *endp != 0)
-                       return CMD_RET_USAGE;
-               if (argc > 3) {
-                       state = simple_strtoul(argv[3], &endp, 10);
-                       if (*argv[3] == 0 || *endp != 0)
-                               return CMD_RET_USAGE;
-                       ret = cros_ec_set_ldo(udev, index, state);
-               } else {
-                       ret = cros_ec_get_ldo(udev, index, &state);
-                       if (!ret) {
-                               printf("LDO%d: %s\n", index,
-                                       state == EC_LDO_STATE_ON ?
-                                       "on" : "off");
-                       }
-               }
-
-               if (ret) {
-                       debug("%s: Could not access LDO%d\n", __func__, index);
-                       return ret;
-               }
-       } else {
-               return CMD_RET_USAGE;
-       }
-
-       if (ret < 0) {
-               printf("Error: CROS-EC command failed (error %d)\n", ret);
-               ret = 1;
-       }
-
-       return ret;
-}
-
-int cros_ec_post_bind(struct udevice *dev)
-{
-       /* Scan for available EC devices (e.g. I2C tunnel) */
-       return dm_scan_fdt_node(dev, gd->fdt_blob, dev->of_offset, false);
-}
-
-U_BOOT_CMD(
-       crosec, 6,      1,      do_cros_ec,
-       "CROS-EC utility command",
-       "init                Re-init CROS-EC (done on startup automatically)\n"
-       "crosec id                  Read CROS-EC ID\n"
-       "crosec info                Read CROS-EC info\n"
-       "crosec curimage            Read CROS-EC current image\n"
-       "crosec hash                Read CROS-EC hash\n"
-       "crosec reboot [rw | ro | cold]  Reboot CROS-EC\n"
-       "crosec events              Read CROS-EC host events\n"
-       "crosec clrevents [mask]    Clear CROS-EC host events\n"
-       "crosec regioninfo <ro|rw>  Read image info\n"
-       "crosec erase <ro|rw>       Erase EC image\n"
-       "crosec read <ro|rw> <addr> [<size>]   Read EC image\n"
-       "crosec write <ro|rw> <addr> [<size>]  Write EC image\n"
-       "crosec vbnvcontext [hexstring]        Read [write] VbNvContext from EC\n"
-       "crosec ldo <idx> [<state>] Switch/Read LDO state\n"
-       "crosec test                run tests on cros_ec\n"
-       "crosec version             Read CROS-EC version"
-);
-#endif
-
 UCLASS_DRIVER(cros_ec) = {
        .id             = UCLASS_CROS_EC,
        .name           = "cros_ec",
        .per_device_auto_alloc_size = sizeof(struct cros_ec_dev),
-       .post_bind      = cros_ec_post_bind,
+       .post_bind      = dm_scan_fdt_dev,
 };