comm: almost total rewrite; add testsuite

[oweals/busybox.git] / coreutils / sum.c

diff --git a/coreutils/sum.c b/coreutils/sum.c
index 5799d142d63d3ab7d65f8822961eabf14a5b26f3..60f3b30073d8d18288db988f3c528adad86f1ca3 100644 (file)
--- a/coreutils/sum.c
+++ b/coreutils/sum.c
@@ -21,20 +21,17 @@ enum { SUM_BSD, PRINT_NAME, SUM_SYSV };
    The checksum varies depending on sizeof (int). */
 /* SYSV: calculate and print the checksum and the size in 512-byte blocks */
 /* Return 1 if successful.  */
-static unsigned sum_file(const char *file, const unsigned type)
+static unsigned sum_file(const char *file, unsigned type)
 {
 #define buf bb_common_bufsiz1
-       uintmax_t total_bytes = 0;
-       int fd = 0, r;
-
+       unsigned long long total_bytes = 0;
+       int fd, r;
        /* The sum of all the input bytes, modulo (UINT_MAX + 1).  */
        unsigned s = 0;
 
-       if (NOT_LONE_DASH(file)) {
-               fd = open(file, O_RDONLY);
-               if (fd == -1)
-                       goto ret_bad;
-       }
+       fd = open_or_warn_stdin(file);
+       if (fd == -1)
+               return 0;
 
        while (1) {
                size_t bytes_read = safe_read(fd, buf, BUFSIZ);
@@ -44,7 +41,6 @@ static unsigned sum_file(const char *file, const unsigned type)
                        if (!bytes_read && !r)
                                /* no error */
                                break;
- ret_bad:
                        bb_perror_msg(file);
                        return 0;
                }
@@ -67,34 +63,37 @@ static unsigned sum_file(const char *file, const unsigned type)
        if (type >= SUM_SYSV) {
                r = (s & 0xffff) + ((s & 0xffffffff) >> 16);
                s = (r & 0xffff) + (r >> 16);
-               printf("%d %ju %s\n", s, (total_bytes+511)/512, file);
+               printf("%d %llu %s\n", s, (total_bytes + 511) / 512, file);
        } else
-               printf("%05d %5ju %s\n", s, (total_bytes+1023)/1024, file);
+               printf("%05d %5llu %s\n", s, (total_bytes + 1023) / 1024, file);
        return 1;
 #undef buf
 }
 
-int sum_main(int argc, char **argv);
-int sum_main(int argc, char **argv)
+int sum_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
+int sum_main(int argc UNUSED_PARAM, char **argv)
 {
        unsigned n;
        unsigned type = SUM_BSD;
 
-       n = getopt32(argc, argv, "sr");
+       n = getopt32(argv, "sr");
+       argv += optind;
        if (n & 1) type = SUM_SYSV;
        /* give the bsd priority over sysv func */
        if (n & 2) type = SUM_BSD;
 
-       if (argc == optind) {
+       if (!argv[0]) {
                /* Do not print the name */
                n = sum_file("-", type);
        } else {
                /* Need to print the name if either
                   - more than one file given
                   - doing sysv */
-               type += argc - 1 > optind || type == SUM_SYSV;
-               for (n = 1; optind < argc; optind++)
-                       n &= sum_file(argv[optind], type);
+               type += (argv[1] || type == SUM_SYSV);
+               n = 1;
+               do {
+                       n &= sum_file(*argv, type);
+               } while (*++argv);
        }
        return !n;
 }