The login applet should always be setuid root

[oweals/busybox.git] / coreutils / mkdir.c

diff --git a/coreutils/mkdir.c b/coreutils/mkdir.c
index 6a4ce6e1a8b43cbd52096e609882a00b595511c0..50364f17fd343c1b47859d87eab552d7933d4ed8 100644 (file)
--- a/coreutils/mkdir.c
+++ b/coreutils/mkdir.c
@@ -20,44 +20,56 @@
  *
  */
 
-#include <errno.h>
-#include <getopt.h>
-#include <sys/stat.h>
-#include <sys/types.h>
-#include <fcntl.h>
-#include <unistd.h>
-#include <stdlib.h>
-#include <string.h>
+/* BB_AUDIT SUSv3 compliant */
+/* http://www.opengroup.org/onlinepubs/007904975/utilities/mkdir.html */
 
+/* Mar 16, 2003      Manuel Novoa III   (mjn3@codepoet.org)
+ *
+ * Fixed broken permission setting when -p was used; especially in
+ * conjunction with -m.
+ */
+
+#include <stdlib.h>
+#include <unistd.h>
+#include <getopt.h>
 #include "busybox.h"
 
+static const struct option mkdir_long_options[] = {
+       { "mode", 1, NULL, 'm' },
+       { "parents", 0, NULL, 'p' },
+       { 0, 0, 0, 0 }
+};
+
 extern int mkdir_main (int argc, char **argv)
 {
-       mode_t mode = -1;
+       mode_t mode = (mode_t)(-1);
+       int status = EXIT_SUCCESS;
        int flags = 0;
-       int i, opt;
+       unsigned long opt;
+       char *smode;
 
-       while ((opt = getopt (argc, argv, "m:p")) != -1) {
-               switch (opt) {
-               case 'm':
+       bb_applet_long_options = mkdir_long_options;
+       opt = bb_getopt_ulflags(argc, argv, "m:p", &smode);
+       if(opt & 1) {
                        mode = 0777;
-                       if (!parse_mode (optarg, &mode))
-                               error_msg_and_die ("invalid mode `%s'", optarg);
-                       break;
-               case 'p':
-                       flags |= FILEUTILS_RECUR;
-                       break;
-               default:
-                       show_usage ();
+               if (!bb_parse_mode (smode, &mode)) {
+                       bb_error_msg_and_die ("invalid mode `%s'", smode);
                }
        }
+       if(opt & 2)
+               flags |= FILEUTILS_RECUR;
 
-       if (optind == argc)
-               show_usage ();
-
-       for (i = optind; i < argc; i++) {
-               make_directory (argv[i], mode, flags);
+       if (optind == argc) {
+               bb_show_usage();
        }
 
-       return(EXIT_SUCCESS);
+       argv += optind;
+
+       do {
+               if (bb_make_directory(*argv, mode, flags)) {
+                       status = EXIT_FAILURE;
+               }
+       } while (*++argv);
+
+       return status;
 }