* Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
*/
-/* BB_AUDIT SUSv3 defects - unsupported options -H, -L, and -P. */
+/* BB_AUDIT SUSv3 defects - none? */
/* BB_AUDIT GNU defects - unsupported long options. */
/* http://www.opengroup.org/onlinepubs/007904975/utilities/chown.html */
#include "busybox.h"
-static uid_t uid = -1;
-static gid_t gid = -1;
-
-static int (*chown_func)(const char *, uid_t, gid_t) = chown;
-
+#define OPT_STR ("Rh" USE_DESKTOP("vcfLHP"))
+#define BIT_RECURSE 1
#define OPT_RECURSE (option_mask32 & 1)
#define OPT_NODEREF (option_mask32 & 2)
-#define OPT_VERBOSE (USE_DESKTOP(option_mask32 & 4) SKIP_DESKTOP(0))
-#define OPT_CHANGED (USE_DESKTOP(option_mask32 & 8) SKIP_DESKTOP(0))
+#define OPT_VERBOSE (USE_DESKTOP(option_mask32 & 0x04) SKIP_DESKTOP(0))
+#define OPT_CHANGED (USE_DESKTOP(option_mask32 & 0x08) SKIP_DESKTOP(0))
#define OPT_QUIET (USE_DESKTOP(option_mask32 & 0x10) SKIP_DESKTOP(0))
-#define OPT_STR ("Rh" USE_DESKTOP("vcf"))
-
-/* TODO:
- * -H if a command line argument is a symbolic link to a directory, traverse it
+/* POSIX options
* -L traverse every symbolic link to a directory encountered
+ * -H if a command line argument is a symbolic link to a directory, traverse it
* -P do not traverse any symbolic links (default)
- */
+ * We do not conform to the following:
+ * "Specifying more than one of -H, -L, and -P is not an error.
+ * The last option specified shall determine the behavior of the utility." */
+/* -L */
+#define BIT_TRAVERSE 0x20
+#define OPT_TRAVERSE (USE_DESKTOP(option_mask32 & BIT_TRAVERSE) SKIP_DESKTOP(0))
+/* -H or -L */
+#define BIT_TRAVERSE_TOP (0x20|0x40)
+#define OPT_TRAVERSE_TOP (USE_DESKTOP(option_mask32 & BIT_TRAVERSE_TOP) SKIP_DESKTOP(0))
+
+typedef int (*chown_fptr)(const char *, uid_t, gid_t);
+
+static struct bb_uidgid_t ugid = { -1, -1 };
static int fileAction(const char *fileName, struct stat *statbuf,
- void ATTRIBUTE_UNUSED *junk, int depth)
+ void *cf, int depth)
{
- // TODO: -H/-L/-P
- // if (depth ... && S_ISLNK(statbuf->st_mode)) ....
+ uid_t u = (ugid.uid == (uid_t)-1) ? statbuf->st_uid : ugid.uid;
+ gid_t g = (ugid.gid == (gid_t)-1) ? statbuf->st_gid : ugid.gid;
- if (!chown_func(fileName,
- (uid == (uid_t)-1) ? statbuf->st_uid : uid,
- (gid == (gid_t)-1) ? statbuf->st_gid : gid)) {
+ if (!((chown_fptr)cf)(fileName, u, g)) {
if (OPT_VERBOSE
- || (OPT_CHANGED && (statbuf->st_uid != uid || statbuf->st_gid != gid))
+ || (OPT_CHANGED && (statbuf->st_uid != u || statbuf->st_gid != g))
) {
- printf("changed ownership of '%s' to %u:%u\n", fileName, uid, gid);
+ printf("changed ownership of '%s' to %u:%u\n",
+ fileName, (unsigned)u, (unsigned)g);
}
return TRUE;
}
return FALSE;
}
+int chown_main(int argc, char **argv);
int chown_main(int argc, char **argv)
{
- char *groupName;
int retval = EXIT_SUCCESS;
+ chown_fptr chown_func;
opt_complementary = "-2";
getopt32(argc, argv, OPT_STR);
argv += optind;
- if (OPT_NODEREF) chown_func = lchown;
-
- /* First, check if there is a group name here */
- groupName = strchr(*argv, '.'); /* deprecated? */
- if (!groupName) {
- groupName = strchr(*argv, ':');
+ /* This matches coreutils behavior (almost - see below) */
+ chown_func = chown;
+ if (OPT_NODEREF
+ /* || (OPT_RECURSE && !OPT_TRAVERSE_TOP): */
+ USE_DESKTOP( || (option_mask32 & (BIT_RECURSE|BIT_TRAVERSE_TOP)) == BIT_RECURSE)
+ ) {
+ chown_func = lchown;
}
- /* First, try parsing "user[:[group]]" */
- if (!groupName) { /* "user" */
- uid = get_ug_id(*argv, xuname2uid);
- } else if (groupName == *argv) { /* ":group" */
- gid = get_ug_id(groupName + 1, xgroup2gid);
- } else {
- struct bb_uidgid_t ugid;
- if (!groupName[1]) /* "user:" */
- *groupName = '\0';
- if (!get_uidgid(&ugid, *argv, 1))
- bb_error_msg_and_die("unknown user/group %s", *argv);
- uid = ugid.uid;
- gid = ugid.gid;
- }
+ parse_chown_usergroup_or_die(&ugid, argv[0]);
/* Ok, ready to do the deed now */
argv++;
do {
- if (!recursive_action(*argv,
- OPT_RECURSE, // recurse
- FALSE, // follow links: TODO: -H/-L/-P
- FALSE, // depth first
- fileAction, // file action
- fileAction, // dir action
- NULL, // user data
- 0) // depth
+ char *arg = *argv;
+
+ if (OPT_TRAVERSE_TOP) {
+ /* resolves symlink (even recursive) */
+ arg = xmalloc_realpath(arg);
+ if (!arg)
+ continue;
+ }
+
+ if (!recursive_action(arg,
+ (OPT_RECURSE ? ACTION_RECURSE : 0) | /* recurse */
+ (OPT_TRAVERSE ? ACTION_FOLLOWLINKS : 0),/* follow links if -L */
+ fileAction, /* file action */
+ fileAction, /* dir action */
+ chown_func, /* user data */
+ 0) /* depth */
) {
retval = EXIT_FAILURE;
}
+
+ if (OPT_TRAVERSE_TOP)
+ free(arg);
} while (*++argv);
return retval;
}
+
+/*
+Testcase. Run in empty directory.
+
+#!/bin/sh
+t1="/tmp/busybox chown"
+t2="/usr/bin/chown"
+create() {
+ rm -rf $1; mkdir $1
+ (
+ cd $1 || exit 1
+ mkdir dir dir2
+ >up
+ >file
+ >dir/file
+ >dir2/file
+ ln -s dir linkdir
+ ln -s file linkfile
+ ln -s ../up dir/linkup
+ ln -s ../dir2 dir/linkupdir2
+ )
+ chown -R 0:0 $1
+}
+tst() {
+ create test1
+ create test2
+ (cd test1; $t1 $1)
+ (cd test2; $t2 $1)
+ (cd test1; ls -lnR) >out1
+ (cd test2; ls -lnR) >out2
+ echo "chown $1" >out.diff
+ if ! diff -u out1 out2 >>out.diff; then exit 1; fi
+ rm out.diff
+}
+tst_for_each() {
+ tst "$1 1:1 file"
+ tst "$1 1:1 dir"
+ tst "$1 1:1 linkdir"
+ tst "$1 1:1 linkfile"
+}
+echo "If script produced 'out.diff' file, then at least one testcase failed"
+# These match coreutils 6.8:
+tst_for_each ""
+tst_for_each "-R"
+tst_for_each "-RP"
+tst_for_each "-RL"
+tst_for_each "-RH"
+tst_for_each "-h"
+tst_for_each "-hR"
+tst_for_each "-hRP"
+# Below: with "chown linkdir" coreutils 6.8 will chown linkdir _target_,
+# we lchown _the link_. I believe we are "more correct".
+#tst_for_each "-hRL"
+#tst_for_each "-hRH"
+
+*/
projects / oweals / busybox.git / blobdiff