lineedit: do not hang on error, but return error indicator.

[oweals/busybox.git] / console-tools / loadkmap.c

diff --git a/console-tools/loadkmap.c b/console-tools/loadkmap.c
index 72247a6e4b6c49d5274a5fdc1f417317ef33c408..2d1c9e2848178d9e4257c524e57c8355de7f1da2 100644 (file)
--- a/console-tools/loadkmap.c
+++ b/console-tools/loadkmap.c
@@ -4,27 +4,11 @@
  *
  * Copyright (C) 1998 Enrique Zanardi <ezanardi@ull.es>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- *
+ * Licensed under GPLv2 or later, see file LICENSE in this source tree.
  */
+#include "libbb.h"
 
-#include "internal.h"
-#include <errno.h>
-#include <fcntl.h>
-#include <stdio.h>
-#include <sys/ioctl.h>
+#define BINARY_KEYMAP_MAGIC "bkeymap"
 
 /* From <linux/kd.h> */
 struct kbentry {
@@ -32,67 +16,43 @@ struct kbentry {
        unsigned char kb_index;
        unsigned short kb_value;
 };
-#define KDSKBENT        0x4B47  /* sets one entry in translation table */
+/* sets one entry in translation table */
+#define KDSKBENT        0x4B47
 
 /* From <linux/keyboard.h> */
 #define NR_KEYS         128
 #define MAX_NR_KEYMAPS  256
 
-
-static const char loadkmap_usage[] = "loadkmap\n"
-#ifndef BB_FEATURE_TRIVIAL_HELP
-       "\nLoads a binary keyboard translation table from standard input.\n"
-#endif
-       ;
-
-
-int loadkmap_main(int argc, char **argv)
+int loadkmap_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
+int loadkmap_main(int argc UNUSED_PARAM, char **argv)
 {
        struct kbentry ke;
-       u_short *ibuff;
-       int i, j, fd, readsz, pos, ibuffsz = NR_KEYS * sizeof(u_short);
-       char flags[MAX_NR_KEYMAPS], magic[] = "bkeymap", buff[7];
-
-       if (argc>=2 && *argv[1]=='-') {
-               usage(loadkmap_usage);
-       }
+       int i, j, fd;
+       uint16_t ibuff[NR_KEYS];
+/*     const char *tty_name = CURRENT_TTY; */
+       RESERVE_CONFIG_BUFFER(flags, MAX_NR_KEYMAPS);
 
-       fd = open("/dev/tty0", O_RDWR);
-       if (fd < 0) {
-               errorMsg("Error opening /dev/tty0: %s\n", strerror(errno));
-               exit(FALSE);
-       }
-
-       read(0, buff, 7);
-       if (0 != strncmp(buff, magic, 7)) {
-               errorMsg("This is not a valid binary keymap.\n");
-               exit(FALSE);
-       }
+       /* When user accidentally runs "loadkmap FILE"
+        * instead of "loadkmap <FILE", we end up waiting for input from tty.
+        * Let's prevent it: */
+       if (argv[1])
+               bb_show_usage();
+/* bb_warn_ignoring_args(argv[1]); */
+       fd = get_console_fd_or_die();
+/* or maybe:
+       opt = getopt32(argv, "C:", &tty_name);
+       fd = xopen_nonblocking(tty_name);
+*/
 
-       if (MAX_NR_KEYMAPS != read(0, flags, MAX_NR_KEYMAPS)) {
-               errorMsg("Error reading keymap flags: %s\n",
-                               strerror(errno));
-               exit(FALSE);
-       }
+       xread(STDIN_FILENO, flags, 7);
+       if (strncmp(flags, BINARY_KEYMAP_MAGIC, 7))
+               bb_error_msg_and_die("not a valid binary keymap");
 
-       ibuff = (u_short *) malloc(ibuffsz);
-       if (!ibuff) {
-               errorMsg("Out of memory.\n");
-               exit(FALSE);
-       }
+       xread(STDIN_FILENO, flags, MAX_NR_KEYMAPS);
 
        for (i = 0; i < MAX_NR_KEYMAPS; i++) {
                if (flags[i] == 1) {
-                       pos = 0;
-                       while (pos < ibuffsz) {
-                               if ((readsz = read(0, (char *) ibuff + pos, ibuffsz - pos))
-                                       < 0) {
-                                       errorMsg("Error reading keymap: %s\n",
-                                                       strerror(errno));
-                                       exit(FALSE);
-                               }
-                               pos += readsz;
-                       }
+                       xread(STDIN_FILENO, ibuff, NR_KEYS * sizeof(uint16_t));
                        for (j = 0; j < NR_KEYS; j++) {
                                ke.kb_index = j;
                                ke.kb_table = i;
@@ -101,8 +61,10 @@ int loadkmap_main(int argc, char **argv)
                        }
                }
        }
-       /* Don't bother to close files.  Exit does that 
-        * automagically, so we can save a few bytes */
-       /* close(fd); */
-       return(TRUE);
+
+       if (ENABLE_FEATURE_CLEAN_UP) {
+               close(fd);
+               RELEASE_CONFIG_BUFFER(flags);
+       }
+       return EXIT_SUCCESS;
 }