Fix incorrect use of getenv() before relocation

[oweals/u-boot.git] / board / hermes / hermes.c

diff --git a/board/hermes/hermes.c b/board/hermes/hermes.c
index 9a3e5f669092ffb19851ee6ad2d2d7464a7b4f90..acf364e2b90b6eb17e43195ba1c256831ec99f30 100644 (file)
--- a/board/hermes/hermes.c
+++ b/board/hermes/hermes.c
@@ -107,21 +107,19 @@ const uint sdram_table[] = {
 
 int checkboard (void)
 {
-       char *s = getenv ("serial#");
-       char *e;
+       char buf[64];
+       int i;
+       int l = getenv_f("serial#", buf, sizeof(buf));
 
        puts ("Board: ");
 
-       if (!s || strncmp (s, "HERMES", 6)) {
+       if (l < 0 || strncmp(buf, "HERMES", 6)) {
                puts ("### No HW ID - assuming HERMES-PRO");
        } else {
-               for (e = s; *e; ++e) {
-                       if (*e == ' ')
+               for (i = 0; i < l; i++) {
+                       if (buf[i] == ' ')
                                break;
-               }
-
-               for (; s < e; ++s) {
-                       putc (*s);
+                       putc (buf[i]);
                }
        }