Patch from Konstantin Isakov <ikm@pisem.net>:
[oweals/busybox.git] / archival / dpkg.c
index f207b23ac19356a908357aea6e6d67ac94d1fa12..6cab77f3846b9dc4f8b2ca8fe514cc143ae2548f 100644 (file)
@@ -2,6 +2,7 @@
  *  Mini dpkg implementation for busybox.
  *  This is not meant as a replacemnt for dpkg
  *
+ *  Written By Glenn McGrath with the help of others
  *  Copyright (C) 2001 by Glenn McGrath
  *             
  *  Started life as a busybox implementation of udpkg
@@ -41,6 +42,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
+#include "unarchive.h"
 #include "busybox.h"
 
 /* NOTE: If you vary HASH_PRIME sizes be aware,
@@ -161,6 +163,7 @@ int search_name_hashtable(const char *key)
 {
        unsigned int probe_address = 0;
        unsigned int probe_decrement = 0;
+//     char *temp;
 
        make_hash(key, &probe_address, &probe_decrement, NAME_HASH_PRIME);
        while(name_hashtable[probe_address] != NULL) {
@@ -174,7 +177,6 @@ int search_name_hashtable(const char *key)
                }
        }
        name_hashtable[probe_address] = xstrdup(key);
-
        return(probe_address);
 }
 
@@ -212,11 +214,12 @@ int version_compare_part(const char *version1, const char *version2)
        int tmp_int;
        int ver_num1;
        int ver_num2;
+       int ret;
 
        if (version1 == NULL) {
                version1 = xstrdup("");
        }
-       if (version2 != NULL) {
+       if (version2 == NULL) {
                version2 = xstrdup("");
        }
        upstream_len1 = strlen(version1);
@@ -234,7 +237,8 @@ int version_compare_part(const char *version1, const char *version2)
                free(name1_char);
                free(name2_char);
                if (tmp_int != 0) {
-                       return(tmp_int);
+                       ret = tmp_int;
+                       goto cleanup_version_compare_part;
                }
 
                /* Compare digits */
@@ -249,13 +253,17 @@ int version_compare_part(const char *version1, const char *version2)
                free(name1_char);
                free(name2_char);
                if (ver_num1 < ver_num2) {
-                       return(-1);
+                       ret = -1;
+                       goto cleanup_version_compare_part;
                }
                else if (ver_num1 > ver_num2) {
-                       return(1);
+                       ret = 1;
+                       goto cleanup_version_compare_part;
                }
        }
-       return(0);
+       ret = 0;
+cleanup_version_compare_part:
+       return(ret);
 }
 
 /* if ver1 < ver2 return -1,
@@ -479,19 +487,17 @@ void add_split_dependencies(common_node_t *parent_node, const char *whole_line,
 
 void free_package(common_node_t *node)
 {
-       int i;
-       if (node != NULL) {
+       unsigned short i;
+       if (node) {
                for (i = 0; i < node->num_of_edges; i++) {
-                       if (node->edge[i] != NULL) {
+                       if (node->edge[i]) {
                                free(node->edge[i]);
                        }
                }
-               if (node->edge != NULL) {
+               if (node->edge) {
                        free(node->edge);
                }
-               if (node != NULL) {
-                       free(node);
-               }
+               free(node);
        }
 }
 
@@ -499,15 +505,16 @@ unsigned int fill_package_struct(char *control_buffer)
 {
        common_node_t *new_node = (common_node_t *) xcalloc(1, sizeof(common_node_t));
 
-       char *field_name = xmalloc(sizeof(char *));
-       char *field_value = xmalloc(sizeof(char *));
+       char *field_name;
+       char *field_value;
        int field_start = 0;
        int num = -1;
        int buffer_length = strlen(control_buffer);
 
        new_node->version = search_name_hashtable("unknown");
        while (field_start < buffer_length) {
-               field_start += read_package_field(&control_buffer[field_start], &field_name, &field_value);
+               field_start += read_package_field(&control_buffer[field_start],
+                               &field_name, &field_value);
 
                if (field_name == NULL) {
                        goto fill_package_struct_cleanup; // Oh no, the dreaded goto statement !!
@@ -544,9 +551,14 @@ unsigned int fill_package_struct(char *control_buffer)
                        add_split_dependencies(new_node, field_value, EDGE_ENHANCES);
                }
 fill_package_struct_cleanup:
-               free(field_name);
-               free(field_value);
+               if (field_name) {
+                       free(field_name);
+               }
+               if (field_value) {
+                       free(field_value);
+               }
        }
+
        if (new_node->version == search_name_hashtable("unknown")) {
                free_package(new_node);
                return(-1);
@@ -615,6 +627,7 @@ void set_status(const unsigned int status_node_num, const char *new_value, const
        new_status = (char *) xmalloc(want_len + flag_len + status_len + 3);
        sprintf(new_status, "%s %s %s", name_hashtable[want], name_hashtable[flag], name_hashtable[status]);
        status_hashtable[status_node_num]->status = search_name_hashtable(new_status);
+       free(new_status);
        return;
 }
 
@@ -755,7 +768,11 @@ void write_status_file(deb_file_t **deb_file)
 
        /* Update previously known packages */
        while ((control_buffer = fgets_str(old_status_file, "\n\n")) != NULL) {
-               tmp_string = strstr(control_buffer, "Package:") + 8;
+               if ((tmp_string = strstr(control_buffer, "Package:")) == NULL) {
+                       continue;
+               }
+
+               tmp_string += 8;
                tmp_string += strspn(tmp_string, " \n\t");
                package_name = xstrndup(tmp_string, strcspn(tmp_string, "\n\0"));
                write_flag = FALSE;
@@ -819,7 +836,6 @@ void write_status_file(deb_file_t **deb_file)
                                }
                                else if (strcmp("config-files", name_hashtable[state_status]) == 0) {
                                        /* only change the status line */
-//                                     buffer_length = strlen(control_buffer);
                                        while (1) {
                                                char *field_name;
                                                char *field_value;
@@ -840,7 +856,7 @@ void write_status_file(deb_file_t **deb_file)
                        }
                }
                /* If the package from the status file wasnt handle above, do it now*/
-               if (write_flag == FALSE) {
+               if (! write_flag) {
                        fprintf(new_status_file, "%s\n\n", control_buffer);
                }
 
@@ -887,9 +903,8 @@ int check_deps(deb_file_t **deb_file, int deb_start, int dep_max_count)
        int state_status;
        int state_flag;
        int state_want;
-       unsigned int status_package_num;
        int i = deb_start;
-       int j, k;
+       int j;
 
        /* Check for conflicts
         * TODO: TEST if conflicts with other packages to be installed
@@ -930,38 +945,49 @@ int check_deps(deb_file_t **deb_file, int deb_start, int dep_max_count)
        }
 
        /* Check conflicts */
-       for (i = 0; i < conflicts_num; i++) {
-               /* Check for conflicts */
-               for (j = 0; j < STATUS_HASH_PRIME; j++) {
-                       if (status_hashtable[j] == NULL) {
-                               continue;
-                       }
-                       state_flag = get_status(j, 2);
-                       state_status = get_status(j, 3);
-                       if ((state_status != search_name_hashtable("installed"))
-                               && (state_flag != search_name_hashtable("want-install"))) {
-                               continue;
-                       }
-                       status_package_num = status_hashtable[j]->package;
-                       for (k = 0; k < package_hashtable[status_package_num]->num_of_edges; k++) {
-                               const edge_t *package_edge = package_hashtable[status_package_num]->edge[k];
-                               if (package_edge->type != EDGE_CONFLICTS) {
-                                       continue;
-                               }
-                               if (package_edge->name != package_hashtable[conflicts[i]]->name) {
-                                       continue;
+       i = 0;
+       while (deb_file[i] != NULL) {
+               const common_node_t *package_node = package_hashtable[deb_file[i]->package];
+               int status_num = 0;
+               status_num = search_status_hashtable(name_hashtable[package_node->name]);
+
+               if (get_status(status_num, 3) == search_name_hashtable("installed")) {
+                       i++;
+                       continue;
+               }
+
+               for (j = 0; j < package_node->num_of_edges; j++) {
+                       const edge_t *package_edge = package_node->edge[j];
+                       const unsigned int package_num = 
+                       search_package_hashtable(package_edge->name,
+                               package_edge->version, package_edge->operator); 
+
+                       if (package_edge->type == EDGE_CONFLICTS) {
+                               int result = 0;
+                               if (package_hashtable[package_num] != NULL) {
+                                       status_num = search_status_hashtable(name_hashtable[package_hashtable[package_num]->name]);
+                                       state_status = get_status(status_num, 3);
+                                       state_flag = get_status(status_num, 1);
+
+                                       result = (state_status == search_name_hashtable("installed")) || 
+                                               (state_flag == search_name_hashtable("want-install"));
+
+                                       if (result) {
+                                               result = test_version(package_hashtable[deb_file[i]->package]->version,
+                                                       package_edge->version, package_edge->operator);
+                                       }
                                }
-                               /* There is a conflict against the package name
-                                * check if version conflict as well */
-                               if (test_version(package_hashtable[deb_file[i]->package]->version,
-                                               package_edge->version, package_edge->operator)) {
-                                       error_msg_and_die("Package %s conflict with %s",
-                                               name_hashtable[package_hashtable[deb_file[i]->package]->name],
-                                               name_hashtable[package_hashtable[status_package_num]->name]);
+
+                               if (result) {
+                                       error_msg_and_die("Package %s conflicts with %s",
+                                               name_hashtable[package_node->name],
+                                               name_hashtable[package_edge->name]);
                                }
                        }
                }
-       }
+               i++;
+       }           
+
 
        /* Check dependendcies */
        i = 0;
@@ -969,70 +995,88 @@ int check_deps(deb_file_t **deb_file, int deb_start, int dep_max_count)
                const common_node_t *package_node = package_hashtable[deb_file[i]->package];
                int status_num = 0;
 
+               status_num = search_status_hashtable(name_hashtable[package_node->name]);         
+               state_status = get_status(status_num, 3);
+               state_want = get_status(status_num, 1);
+
+               if (state_status == search_name_hashtable("installed")) {
+                       i++;
+                       continue;
+               }
+
                for (j = 0; j < package_hashtable[deb_file[i]->package]->num_of_edges; j++) {
                        const edge_t *package_edge = package_node->edge[j];
-                       const unsigned int package_num = search_package_hashtable(package_edge->name,
-                               package_edge->version, package_edge->operator);
+                       unsigned int package_num;
+
+                       package_num = search_package_hashtable(package_edge->name, package_edge->version, package_edge->operator);
 
-                       status_num = search_status_hashtable(name_hashtable[package_hashtable[package_num]->name]);
-                       state_status = get_status(status_num, 3);
-                       state_want = get_status(status_num, 1);
                        switch (package_edge->type) {
                                case(EDGE_PRE_DEPENDS):
-                               case(EDGE_OR_PRE_DEPENDS):
+                               case(EDGE_OR_PRE_DEPENDS): {
+                                       int result=1;
                                        /* It must be already installed */
                                        /* NOTE: This is untested, nothing apropriate in my status file */
-                                       if ((package_hashtable[package_num] == NULL) || (state_status != search_name_hashtable("installed"))) {
+                                       if (package_hashtable[package_num] != NULL) {
+                                               status_num = search_status_hashtable(name_hashtable[package_hashtable[package_num]->name]);
+                                               state_status = get_status(status_num, 3);
+                                               state_want = get_status(status_num, 1);
+                                               result = (state_status != search_name_hashtable("installed"));
+                                       }
+
+                                       if (result) {
                                                error_msg_and_die("Package %s pre-depends on %s, but it is not installed",
                                                        name_hashtable[package_node->name],
                                                        name_hashtable[package_edge->name]);
                                        }
                                        break;
+                               }
                                case(EDGE_DEPENDS):
-                               case(EDGE_OR_DEPENDS):
+                               case(EDGE_OR_DEPENDS): {
+                                       int result=1;
+                                       if (package_hashtable[package_num] != NULL) {
+                                               status_num = search_status_hashtable(name_hashtable[package_hashtable[package_num]->name]);
+                                               state_status = get_status(status_num, 3);
+                                               state_want = get_status(status_num, 1);
+                                               result=(state_status != search_name_hashtable("installed")) && (state_want != search_name_hashtable("want-install"));
+                                       }
                                        /* It must be already installed, or to be installed */
-                                       if ((package_hashtable[package_num] == NULL) ||
-                                               ((state_status != search_name_hashtable("installed")) &&
-                                               (state_want != search_name_hashtable("want_install")))) {
+                                       if (result) {
                                                error_msg_and_die("Package %s depends on %s, but it is not installed, or flaged to be installed",
                                                        name_hashtable[package_node->name],
                                                        name_hashtable[package_edge->name]);
                                        }
                                        break;
+                               }
                        }
                }
                i++;
        }
+       free(conflicts);
        return(TRUE);
 }
 
 char **create_list(const char *filename)
 {
        FILE *list_stream;
-       char **file_list = xmalloc(sizeof(char *));
+       char **file_list = NULL;
        char *line = NULL;
-       char *last_char;
        int length = 0;
        int count = 0;
 
        /* dont use [xw]fopen here, handle error ourself */
        list_stream = fopen(filename, "r");
        if (list_stream == NULL) {
-               *file_list = NULL;
-               return(file_list);
+               return(NULL);
        }
+
        while (getline(&line, &length, list_stream) != -1) {
-               file_list = xrealloc(file_list, sizeof(char *) * (length + 1));
-               last_char = last_char_is(line, '\n');
-               if (last_char) {
-                       *last_char = '\0';
-               }
+               file_list = xrealloc(file_list, sizeof(char *) * (count + 2));
+               chomp(line);
                file_list[count] = xstrdup(line);
-               free(line);
                count++;
-               length = 0;
        }
        fclose(list_stream);
+       free(line);
 
        if (count == 0) {
                return(NULL);
@@ -1085,30 +1129,92 @@ int run_package_script(const char *package_name, const char *script_type)
 {
        struct stat path_stat;
        char *script_path;
+       int result;
 
        script_path = xmalloc(strlen(package_name) + strlen(script_type) + 21);
        sprintf(script_path, "/var/lib/dpkg/info/%s.%s", package_name, script_type);
 
        /* If the file doesnt exist is isnt a fatal */
        if (lstat(script_path, &path_stat) < 0) {
-               return(EXIT_SUCCESS);
+               result = EXIT_SUCCESS;
        } else {
-               return(system(script_path));
+               result = system(script_path);
        }
+       free(script_path);
+       return(result);
 }
 
-void all_control_list(char **remove_files, const char *package_name)
+char **all_control_list(const char *package_name)
 {
-       const char *all_extensions[11] = {"preinst", "postinst", "prerm", "postrm",
+       const char *extensions[11] = {"preinst", "postinst", "prerm", "postrm",
                "list", "md5sums", "shlibs", "conffiles", "config", "templates", NULL };
-       int i;
+       unsigned short i = 0;
+       char **remove_files;
 
        /* Create a list of all /var/lib/dpkg/info/<package> files */
-       for(i = 0; i < 10; i++) {
-               remove_files[i] = xmalloc(strlen(package_name) + strlen(all_extensions[i]) + 21);
-               sprintf(remove_files[i], "/var/lib/dpkg/info/%s.%s", package_name, all_extensions[i]);
+       remove_files = malloc(sizeof(char *) * 11);
+       while (extensions[i]) {
+               remove_files[i] = xmalloc(strlen(package_name) + strlen(extensions[i]) + 21);
+               sprintf(remove_files[i], "/var/lib/dpkg/info/%s.%s", package_name, extensions[i]);
+               i++;
        }
        remove_files[10] = NULL;
+
+       return(remove_files);
+}
+
+void free_array(char **array)
+{
+       
+       if (array) {
+               unsigned short i = 0;
+               while (array[i]) {
+                       free(array[i]);
+                       i++;
+               }
+               free(array);
+       }
+}
+
+/* This function lists information on the installed packages. It loops through
+ * the status_hashtable to retrieve the info. This results in smaller code than
+ * scanning the status file. The resulting list, however, is unsorted. 
+ */
+void list_packages(void)
+{
+        int i;
+
+       printf("    Name           Version\n");
+       printf("+++-==============-==============\n");
+       
+       /* go through status hash, dereference package hash and finally strings */
+       for (i=0; i<STATUS_HASH_PRIME+1; i++) {
+
+               if (status_hashtable[i]) {
+                       const char *stat_str;  /* status string */
+                       const char *name_str;  /* package name */
+                       const char *vers_str;  /* version */
+                       char  s1, s2;          /* status abbreviations */
+                       int   spccnt;          /* space count */      
+                       int   j;
+                       
+                       stat_str = name_hashtable[status_hashtable[i]->status];
+                       name_str = name_hashtable[package_hashtable[status_hashtable[i]->package]->name];
+                       vers_str = name_hashtable[package_hashtable[status_hashtable[i]->package]->version];
+                       
+                       /* get abbreviation for status field 1 */
+                       s1 = stat_str[0] == 'i' ? 'i' : 'r';
+                       
+                       /* get abbreviation for status field 2 */
+                       for (j=0, spccnt=0; stat_str[j] && spccnt<2; j++) {
+                               if (stat_str[j] == ' ') spccnt++;
+                       }
+                       s2 = stat_str[j];
+                       
+                       /* print out the line formatted like Debian dpkg */
+                       printf("%c%c  %-14s %s\n", s1, s2, name_str, vers_str);
+               }
+    }
 }
 
 void remove_package(const unsigned int package_num)
@@ -1125,7 +1231,7 @@ void remove_package(const unsigned int package_num)
        printf("Removing %s ...\n", package_name);
 
        /* run prerm script */
-       return_value = run_package_script(package_name, "prem");
+       return_value = run_package_script(package_name, "prerm");
        if (return_value == -1) {
                error_msg_and_die("script failed, prerm failure");
        }
@@ -1138,11 +1244,9 @@ void remove_package(const unsigned int package_num)
        exclude_files = create_list(conffile_name);
 
        /* Some directories cant be removed straight away, so do multiple passes */
-       while (remove_file_array(remove_files, exclude_files) == TRUE);
-
-       /* Create a list of all /var/lib/dpkg/info/<package> files */
-       remove_files = xmalloc(11);
-       all_control_list(remove_files, package_name);
+       while (remove_file_array(remove_files, exclude_files));
+       free_array(exclude_files);
+       free_array(remove_files);
 
        /* Create a list of files in /var/lib/dpkg/info/<package>.* to keep  */
        exclude_files = xmalloc(sizeof(char*) * 3);
@@ -1151,7 +1255,12 @@ void remove_package(const unsigned int package_num)
        sprintf(exclude_files[1], "/var/lib/dpkg/info/%s.postrm", package_name);
        exclude_files[2] = NULL;
 
+       /* Create a list of all /var/lib/dpkg/info/<package> files */
+       remove_files = all_control_list(package_name);
+
        remove_file_array(remove_files, exclude_files);
+       free_array(remove_files);
+       free_array(exclude_files);
 
        /* rename <package>.conffile to <package>.list */
        rename(conffile_name, list_name);
@@ -1170,7 +1279,7 @@ void purge_package(const unsigned int package_num)
        char list_name[strlen(package_name) + 25];
 
        /* run prerm script */
-       if (run_package_script(package_name, "prerm") == -1) {
+       if (run_package_script(package_name, "prerm") != 0) {
                error_msg_and_die("script failed, prerm failure");
        }
 
@@ -1178,16 +1287,18 @@ void purge_package(const unsigned int package_num)
        sprintf(list_name, "/var/lib/dpkg/info/%s.list", package_name);
        remove_files = create_list(list_name);
 
-       exclude_files = xmalloc(1);
+       exclude_files = xmalloc(sizeof(char*));
        exclude_files[0] = NULL;
 
        /* Some directories cant be removed straight away, so do multiple passes */
-       while (remove_file_array(remove_files, exclude_files) == TRUE);
+       while (remove_file_array(remove_files, exclude_files));
+       free_array(remove_files);
 
        /* Create a list of all /var/lib/dpkg/info/<package> files */
-       remove_files = xmalloc(11);
-       all_control_list(remove_files, package_name);
+       remove_files = all_control_list(package_name);
        remove_file_array(remove_files, exclude_files);
+       free_array(remove_files);
+       free(exclude_files);
 
        /* run postrm script */
        if (run_package_script(package_name, "postrm") == -1) {
@@ -1203,7 +1314,7 @@ void unpack_package(deb_file_t *deb_file)
 {
        const char *package_name = name_hashtable[package_hashtable[deb_file->package]->name];
        const unsigned int status_num = search_status_hashtable(package_name);
-       const unsigned int status_package_num = status_hashtable[status_num]->status;
+       const unsigned int status_package_num = status_hashtable[status_num]->package;
 
        FILE *out_stream;
        char *info_prefix;
@@ -1220,22 +1331,30 @@ void unpack_package(deb_file_t *deb_file)
        }
 
        /* Extract control.tar.gz to /var/lib/dpkg/info/<package>.filename */
-       info_prefix = (char *) xmalloc(sizeof(package_name) + 20 + 4 + 1);
+       info_prefix = (char *) xmalloc(strlen(package_name) + 20 + 4 + 2);
        sprintf(info_prefix, "/var/lib/dpkg/info/%s.", package_name);
-       deb_extract(deb_file->filename, stdout, (extract_quiet | extract_control_tar_gz | extract_all_to_fs), info_prefix, NULL);
+       deb_extract(deb_file->filename, stdout, (extract_quiet | extract_control_tar_gz | extract_all_to_fs | extract_unconditional), info_prefix, NULL);
+
+       /* Run the preinst prior to extracting */
+       if (run_package_script(package_name, "preinst") != 0) {
+               /* when preinst returns exit code != 0 then quit installation process */
+               error_msg_and_die("subprocess pre-installation script returned error.");
+       }       
 
        /* Extract data.tar.gz to the root directory */
-       deb_extract(deb_file->filename, stdout, (extract_quiet | extract_data_tar_gz | extract_all_to_fs), "/", NULL);
+       deb_extract(deb_file->filename, stdout, (extract_quiet | extract_data_tar_gz | extract_all_to_fs | extract_unconditional), "/", NULL);
 
        /* Create the list file */
        strcat(info_prefix, "list");
        out_stream = xfopen(info_prefix, "w");                  
-       deb_extract(deb_file->filename, out_stream, (extract_quiet | extract_data_tar_gz | extract_list), NULL, NULL);
+       deb_extract(deb_file->filename, out_stream, (extract_quiet | extract_data_tar_gz | extract_list), "/", NULL);
        fclose(out_stream);
 
        /* change status */
        set_status(status_num, "install", 1);
        set_status(status_num, "unpacked", 3);
+
+       free(info_prefix);
 }
 
 void configure_package(deb_file_t *deb_file)
@@ -1243,13 +1362,11 @@ void configure_package(deb_file_t *deb_file)
        const char *package_name = name_hashtable[package_hashtable[deb_file->package]->name];
        const char *package_version = name_hashtable[package_hashtable[deb_file->package]->version];
        const int status_num = search_status_hashtable(package_name);
-       int return_value;
 
        printf("Setting up %s (%s)\n", package_name, package_version);
 
-       /* Run the preinst prior to extracting */
-       return_value = run_package_script(package_name, "postinst");
-       if (return_value == -1) {
+       /* Run the postinst script */
+       if (run_package_script(package_name, "postinst") != 0) {
                /* TODO: handle failure gracefully */
                error_msg_and_die("postrm failure.. set status to what?");
        }
@@ -1258,11 +1375,11 @@ void configure_package(deb_file_t *deb_file)
        set_status(status_num, "installed", 3);
 }
 
-extern int dpkg_main(int argc, char **argv)
+int dpkg_main(int argc, char **argv)
 {
        deb_file_t **deb_file = NULL;
        status_node_t *status_node;
-       char opt = 0;
+       int opt;
        int package_num;
        int dpkg_opt = 0;
        int deb_count = 0;
@@ -1286,6 +1403,7 @@ extern int dpkg_main(int argc, char **argv)
                                break;
                        case 'l':
                                dpkg_opt |= dpkg_opt_list_installed;
+                               break;
                        case 'P':
                                dpkg_opt |= dpkg_opt_purge;
                                dpkg_opt |= dpkg_opt_package_name;
@@ -1302,17 +1420,24 @@ extern int dpkg_main(int argc, char **argv)
                                show_usage();
                }
        }
-
-       if ((argc == optind) || (dpkg_opt == 0)) {
+       /* check for non-otion argument if expected  */
+       if ((dpkg_opt == 0) || ((argc == optind) && !(dpkg_opt && dpkg_opt_list_installed))) {
                show_usage();
-       } 
+       }
 
-       puts("(Reading database ... xxxxx files and directories installed.)");
+/*     puts("(Reading database ... xxxxx files and directories installed.)"); */
        index_status_file("/var/lib/dpkg/status");
 
+       /* if the list action was given print the installed packages and exit */
+       if (dpkg_opt & dpkg_opt_list_installed) {
+               list_packages();
+               return(EXIT_SUCCESS);
+       }
+       
        /* Read arguments and store relevant info in structs */
-       deb_file = xmalloc(sizeof(deb_file_t));
        while (optind < argc) {
+               /* deb_count = nb_elem - 1 and we need nb_elem + 1 to allocate terminal node [NULL pointer] */
+               deb_file = xrealloc(deb_file, sizeof(deb_file_t *) * (deb_count + 2));
                deb_file[deb_count] = (deb_file_t *) xmalloc(sizeof(deb_file_t));
                if (dpkg_opt & dpkg_opt_filename) {
                        deb_file[deb_count]->filename = xstrdup(argv[optind]);
@@ -1331,12 +1456,18 @@ extern int dpkg_main(int argc, char **argv)
                        if ((dpkg_opt & dpkg_opt_unpack) || (dpkg_opt & dpkg_opt_install)) {
                                status_node = (status_node_t *) xmalloc(sizeof(status_node_t));
                                status_node->package = deb_file[deb_count]->package;
-                               /* use reinstreq isnt changed to "ok" until the package control info
-                                * is written to the status file*/
-                               status_node->status = search_name_hashtable("install reinstreq not-installed");
-
+                               /* Try and find a currently installed version of this package */
                                status_num = search_status_hashtable(name_hashtable[package_hashtable[deb_file[deb_count]->package]->name]);
-                               status_hashtable[status_num] = status_node;
+                               /* If no previous entry was found initialise a new entry */
+                               if ((status_hashtable[status_num] == NULL) ||
+                                       (status_hashtable[status_num]->status == 0)) {
+                                       /* reinstreq isnt changed to "ok" until the package control info
+                                        * is written to the status file*/
+                                       status_node->status = search_name_hashtable("want-install reinstreq not-installed");
+                                       status_hashtable[status_num] = status_node;
+                               } else {
+                                       status_hashtable[status_num]->status = search_name_hashtable("want-install reinstreq not-installed");
+                               }
                        }
                }
                else if (dpkg_opt & dpkg_opt_package_name) {
@@ -1399,6 +1530,14 @@ extern int dpkg_main(int argc, char **argv)
 
        write_status_file(deb_file);
 
+       for (i = 0; i < deb_count; i++) {
+               free(deb_file[i]->control_file);
+               free(deb_file[i]->filename);
+               free(deb_file[i]);
+       }
+
+       free(deb_file);
+
        for (i = 0; i < NAME_HASH_PRIME; i++) {
                if (name_hashtable[i] != NULL) {
                        free(name_hashtable[i]);
@@ -1406,7 +1545,9 @@ extern int dpkg_main(int argc, char **argv)
        }
 
        for (i = 0; i < PACKAGE_HASH_PRIME; i++) {
-               free_package(package_hashtable[i]);
+               if (package_hashtable[i] != NULL) {
+                       free_package(package_hashtable[i]);
+               }
        }
 
        for (i = 0; i < STATUS_HASH_PRIME; i++) {
@@ -1415,6 +1556,6 @@ extern int dpkg_main(int argc, char **argv)
                }
        }
 
-       return(EXIT_FAILURE);
+       return(EXIT_SUCCESS);
 }