Follow on from CVE-2014-3571. This fixes the code that was the original source

[oweals/openssl.git] / apps / dsaparam.c

diff --git a/apps/dsaparam.c b/apps/dsaparam.c
index 03e33f9f7eb0fed47f177a4ee52acb6af7368c78..a922335c3107331741f747fa5410238e7ebfbdc3 100644 (file)
--- a/apps/dsaparam.c
+++ b/apps/dsaparam.c
@@ -57,11 +57,6 @@
  */
 
 #include <openssl/opensslconf.h>       /* for OPENSSL_NO_DSA */
-/* Until the key-gen callbacks are modified to use newer prototypes, we allow
- * deprecated functions for openssl-internal code */
-#ifdef OPENSSL_NO_DEPRECATED
-#undef OPENSSL_NO_DEPRECATED
-#endif
 
 #ifndef OPENSSL_NO_DSA
 #include <assert.h>
@@ -80,7 +75,8 @@
 #undef PROG
 #define PROG   dsaparam_main
 
-/* -inform arg - input format - default PEM (DER or PEM)
+/*-
+ * -inform arg - input format - default PEM (DER or PEM)
  * -outform arg - output format - default PEM
  * -in arg     - input file - default stdin
  * -out arg    - output file - default stdout
@@ -119,6 +115,7 @@ int MAIN(int argc, char **argv)
        int numbits= -1,num,genkey=0;
        int need_rand=0;
        int non_fips_allow = 0;
+       BN_GENCB *cb = NULL;
 #ifndef OPENSSL_NO_ENGINE
        char *engine=NULL;
 #endif
@@ -291,8 +288,13 @@ bad:
 
        if (numbits > 0)
                {
-               BN_GENCB cb;
-               BN_GENCB_set(&cb, dsa_cb, bio_err);
+               cb = BN_GENCB_new();
+               if(!cb)
+                       {
+                       BIO_printf(bio_err,"Error allocating BN_GENCB object\n");
+                       goto end;
+                       }
+               BN_GENCB_set(cb, dsa_cb, bio_err);
                assert(need_rand);
                dsa = DSA_new();
                if(!dsa)
@@ -320,7 +322,7 @@ bad:
                alarm(timebomb);
        }
 #endif
-               if(!DSA_generate_parameters_ex(dsa,num,NULL,0,NULL,NULL, &cb))
+               if(!DSA_generate_parameters_ex(dsa,num,NULL,0,NULL,NULL, cb))
                        {
 #ifdef GENCB_TEST
                        if(stop_keygen_flag)
@@ -458,6 +460,7 @@ bad:
                app_RAND_write_file(NULL, bio_err);
        ret=0;
 end:
+       if (cb != NULL) BN_GENCB_free(cb);
        if (in != NULL) BIO_free(in);
        if (out != NULL) BIO_free_all(out);
        if (dsa != NULL) DSA_free(dsa);
@@ -473,11 +476,8 @@ static int MS_CALLBACK dsa_cb(int p, int n, BN_GENCB *cb)
        if (p == 1) c='+';
        if (p == 2) c='*';
        if (p == 3) c='\n';
-       BIO_write(cb->arg,&c,1);
-       (void)BIO_flush(cb->arg);
-#ifdef LINT
-       p=n;
-#endif
+       BIO_write(BN_GENCB_get_arg(cb),&c,1);
+       (void)BIO_flush(BN_GENCB_get_arg(cb));
 #ifdef GENCB_TEST
        if(stop_keygen_flag)
                return 0;