projects
/
oweals
/
busybox.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
id: fix "id <user>" case. Requires getgrouplist().
[oweals/busybox.git]
/
printutils
/
lpr.c
diff --git
a/printutils/lpr.c
b/printutils/lpr.c
index 153e6ab9606f7cd0f9d7b20679ad3bedd4eeeaf1..25cbcbc5e5df3ccf1ab8348127c4ee8e9dc44db8 100644
(file)
--- a/
printutils/lpr.c
+++ b/
printutils/lpr.c
@@
-42,14
+42,14
@@
static void get_response_or_say_and_die(int fd, const char *errmsg)
}
int lpqr_main(int argc, char *argv[]) MAIN_EXTERNALLY_VISIBLE;
}
int lpqr_main(int argc, char *argv[]) MAIN_EXTERNALLY_VISIBLE;
-int lpqr_main(int argc, char *argv[])
+int lpqr_main(int argc
UNUSED_PARAM
, char *argv[])
{
enum {
OPT_P = 1 << 0, // -P queue[@host[:port]]. If no -P is given use $PRINTER, then "lp@localhost:515"
OPT_U = 1 << 1, // -U username
LPR_V = 1 << 2, // -V: be verbose
{
enum {
OPT_P = 1 << 0, // -P queue[@host[:port]]. If no -P is given use $PRINTER, then "lp@localhost:515"
OPT_U = 1 << 1, // -U username
LPR_V = 1 << 2, // -V: be verbose
- LPR_h = 1 << 3, // -h: want banner printed
+ LPR_h = 1 << 3, // -h: want banner printed
LPR_C = 1 << 4, // -C class: job "class" (? supposedly printed on banner)
LPR_J = 1 << 5, // -J title: the job title for the banner page
LPR_m = 1 << 6, // -m: send mail back to user
LPR_C = 1 << 4, // -C class: job "class" (? supposedly printed on banner)
LPR_J = 1 << 5, // -J title: the job title for the banner page
LPR_m = 1 << 6, // -m: send mail back to user
@@
-149,6
+149,7
@@
int lpqr_main(int argc, char *argv[])
// process files
do {
// process files
do {
+ unsigned cflen;
int dfd;
struct stat st;
char *c;
int dfd;
struct stat st;
char *c;
@@
-194,23
+195,30
@@
int lpqr_main(int argc, char *argv[])
);
// delete possible "\nX\n" patterns
c = controlfile;
);
// delete possible "\nX\n" patterns
c = controlfile;
+ cflen = (unsigned)strlen(controlfile);
while ((c = strchr(c, '\n')) != NULL) {
while ((c = strchr(c, '\n')) != NULL) {
- c++;
- while (c[0] && c[1] == '\n')
- memmove(c, c+2, strlen(c+1)); /* strlen(c+1) == strlen(c+2) + 1 */
+ if (c[1] && c[2] == '\n') {
+ /* can't use strcpy, results are undefined */
+ memmove(c, c+2, cflen - (c-controlfile) - 1);
+ cflen -= 2;
+ } else {
+ c++;
+ }
}
// send control file
if (opts & LPR_V)
bb_error_msg("sending control file");
}
// send control file
if (opts & LPR_V)
bb_error_msg("sending control file");
+ /* "Acknowledgement processing must occur as usual
+ * after the command is sent." */
+ fdprintf(fd, "\x2" "%u c%s\n", cflen, remote_filename);
+ get_response_or_say_and_die(fd, "sending control file");
/* "Once all of the contents have
* been delivered, an octet of zero bits is sent as
* an indication that the file being sent is complete.
* A second level of acknowledgement processing
* must occur at this point." */
/* "Once all of the contents have
* been delivered, an octet of zero bits is sent as
* an indication that the file being sent is complete.
* A second level of acknowledgement processing
* must occur at this point." */
- fdprintf(fd, "\x2" "%u c%s\n" "%s" "%c",
- (unsigned)strlen(controlfile),
- remote_filename, controlfile, '\0');
+ full_write(fd, controlfile, cflen + 1); /* writes NUL byte too */
get_response_or_say_and_die(fd, "sending control file");
// send data file, with name "dfaXXX"
get_response_or_say_and_die(fd, "sending control file");
// send data file, with name "dfaXXX"
@@
-219,6
+227,7
@@
int lpqr_main(int argc, char *argv[])
st.st_size = 0; /* paranoia: fstat may theoretically fail */
fstat(dfd, &st);
fdprintf(fd, "\x3" "%"OFF_FMT"u d%s\n", st.st_size, remote_filename);
st.st_size = 0; /* paranoia: fstat may theoretically fail */
fstat(dfd, &st);
fdprintf(fd, "\x3" "%"OFF_FMT"u d%s\n", st.st_size, remote_filename);
+ get_response_or_say_and_die(fd, "sending data file");
if (bb_copyfd_size(dfd, fd, st.st_size) != st.st_size) {
// We're screwed. We sent less bytes than we advertised.
bb_error_msg_and_die("local file changed size?!");
if (bb_copyfd_size(dfd, fd, st.st_size) != st.st_size) {
// We're screwed. We sent less bytes than we advertised.
bb_error_msg_and_die("local file changed size?!");