- case 'c':
- mode = S_IFCHR; break;
- case 'b':
- mode = S_IFBLK; break;
- case 'f':
- mode = S_IFIFO; break;
- default:
- usage(makedevs_usage);
- return 2;
- }
- mode |= 0660;
-
- while ( S <= E ) {
-
- if (type[0] != 'f')
- dev = (major << 8) | Sminor;
- strcpy(devname, basedev);
-
- if (sbase == 0) {
- sprintf(buf, "%d", S);
- strcat(devname, buf);
- } else {
- sbase = 0;
- }
-
- if (mknod (devname, mode, dev))
- printf("Failed to create: %s\n", devname);
-
- S++; Sminor++;
+ case 'c':
+ mode |= S_IFCHR;
+ break;
+ case 'b':
+ mode |= S_IFBLK;
+ break;
+ case 'f':
+ mode |= S_IFIFO;
+ break;
+ default:
+ bb_show_usage();
+ }
+
+ while (S <= E) {
+ int sz;
+
+ sz = snprintf(buf, sizeof(buf), "%s%d", basedev, S);
+ if(sz<0 || sz>=sizeof(buf)) /* libc different */
+ bb_error_msg_and_die("%s too large", basedev);
+
+ /* if mode != S_IFCHR and != S_IFBLK third param in mknod() ignored */
+
+ if (mknod(nodname, mode, major | Sminor))
+ bb_error_msg("Failed to create: %s", nodname);
+
+ if (nodname == basedev) /* ex. /dev/hda - to /dev/hda1 ... */
+ nodname = buf;
+ S++;
+ Sminor++;