eff7983e782cd39bfa019b7df5f7fcf950d74a42
[oweals/openwrt.git] /
1 From 57c6930510fd76201fddc352d6b96f5b8d1a8911 Mon Sep 17 00:00:00 2001
2 From: 6by9 <6by9@users.noreply.github.com>
3 Date: Tue, 11 Dec 2018 15:18:02 +0000
4 Subject: [PATCH 290/773] staging: bcm2835-camera: Check the error for
5  REPEAT_SEQ_HEADER (#2782)
6
7 When handling for V4L2_CID_MPEG_VIDEO_REPEAT_SEQ_HEADER was added
8 the firmware would reject the setting if H264 hadn't already been
9 selected. This was fixed in the firmware at that point, but to
10 enable backwards compatibility the returned error was ignored.
11
12 That was Dec 2013, so the chances of having a firmware that still
13 has that issue is so close to zero that the workaround can be
14 removed.
15
16 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
17 ---
18  drivers/staging/vc04_services/bcm2835-camera/controls.c | 2 +-
19  1 file changed, 1 insertion(+), 1 deletion(-)
20
21 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
22 +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
23 @@ -1100,7 +1100,7 @@ static const struct bm2835_mmal_v4l2_ctr
24                 0, 1, NULL,
25                 MMAL_PARAMETER_VIDEO_ENCODE_INLINE_HEADER,
26                 &ctrl_set_video_encode_param_output,
27 -               true    /* Errors ignored as requires latest firmware to work */
28 +               false
29         },
30         {
31                 V4L2_CID_MPEG_VIDEO_H264_PROFILE,