b9410dd7d0a006a1f81f5c3bc82b561522bf7f21
[oweals/openwrt.git] /
1 From c900072bd6faff089aa4fb7b19136a2a0fe3baf0 Mon Sep 17 00:00:00 2001
2 From: Ian Molton <ian@mnementh.co.uk>
3 Date: Fri, 8 Dec 2017 13:10:32 +0100
4 Subject: [PATCH] brcmfmac: remove unnecessary call to
5  brcmf_sdiod_set_backplane_window()
6
7 All functions that might require the window address changing call
8 brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
9 the window is not required.
10
11 Signed-off-by: Ian Molton <ian@mnementh.co.uk>
12 [arend: corrected the driver prefix in the subject]
13 Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
14 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
15 ---
16  drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 5 -----
17  1 file changed, 5 deletions(-)
18
19 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
20 +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
21 @@ -723,11 +723,6 @@ brcmf_sdiod_ramrw(struct brcmf_sdio_dev
22  
23         dev_kfree_skb(pkt);
24  
25 -       /* Return the window to backplane enumeration space for core access */
26 -       if (brcmf_sdiod_set_backplane_window(sdiodev, sdiodev->sbwad))
27 -               brcmf_err("FAILED to set window back to 0x%x\n",
28 -                         sdiodev->sbwad);
29 -
30         sdio_release_host(sdiodev->func[1]);
31  
32         return err;