a1fcebd512b993702f95a0c67078cf49fa8ba2c4
[oweals/openwrt.git] /
1 From 979c9a17fc78f3b8393fd92ca250fe4239872eee Mon Sep 17 00:00:00 2001
2 From: Arend van Spriel <arend.vanspriel@broadcom.com>
3 Date: Thu, 11 Jul 2019 11:05:12 +0200
4 Subject: [PATCH 7/7] brcmfmac: remove unnecessary strlcpy() upon obtaining
5  "ver" iovar
6
7 Recently a strcpy() was replaced by strlcpy(). However, the strcpy()
8 was not needed in the first place. So removing that line of code.
9
10 Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
11 Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
12 Reviewed-by: Franky Lin <franky.lin@broadcom.com>
13 Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
14 ---
15  drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 1 -
16  1 file changed, 1 deletion(-)
17
18 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
19 +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
20 @@ -269,7 +269,6 @@ int brcmf_c_preinit_dcmds(struct brcmf_i
21  
22         /* query for 'ver' to get version info from firmware */
23         memset(buf, 0, sizeof(buf));
24 -       strlcpy(buf, "ver", sizeof(buf));
25         err = brcmf_fil_iovar_data_get(ifp, "ver", buf, sizeof(buf));
26         if (err < 0) {
27                 bphy_err(drvr, "Retrieving version information failed, %d\n",