git.librecmc.org Git - oweals/openwrt.git/blob

   1 From 37ede4f6a1771b09dea6e8b2fc4d2c5f085a33f3 Mon Sep 17 00:00:00 2001
   2 From: Dave Stevenson <dave.stevenson@raspberrypi.org>
   3 Date: Fri, 28 Sep 2018 10:22:26 +0100
   4 Subject: [PATCH] staging: bcm2835-camera: Remove/amend some obsolete
   5  comments
   6
   7 Remove a todo which has been done.
   8 Remove a template line that was redundant.
   9 Make a comment clearer as to the non-obvious meaning of a field.
  10
  11 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
  12 ---
  13  .../staging/vc04_services/bcm2835-camera/controls.c   | 11 +----------
  14  1 file changed, 1 insertion(+), 10 deletions(-)
  15
  16 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
  17 +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
  18 @@ -965,10 +965,6 @@ static const struct bm2835_mmal_v4l2_ctr
  19                 &ctrl_set_value,
  20                 false
  21         },
  22 -/*     {
  23 - *             0, MMAL_CONTROL_TYPE_CLUSTER, 3, 1, 0, NULL, 0, NULL
  24 - *     },
  25 - */
  26         {
  27                 V4L2_CID_EXPOSURE_AUTO, MMAL_CONTROL_TYPE_STD_MENU,
  28                 ~0x03, V4L2_EXPOSURE_APERTURE_PRIORITY, V4L2_EXPOSURE_AUTO, 0,
  29 @@ -976,11 +972,6 @@ static const struct bm2835_mmal_v4l2_ctr
  30                 &ctrl_set_exposure,
  31                 false
  32         },
  33 -/* todo this needs mixing in with set exposure
  34 - *     {
  35 - *             V4L2_CID_SCENE_MODE, MMAL_CONTROL_TYPE_STD_MENU,
  36 - *     },
  37 - */
  38         {
  39                 V4L2_CID_EXPOSURE_ABSOLUTE, MMAL_CONTROL_TYPE_STD,
  40                 /* Units of 100usecs */
  41 @@ -1146,7 +1137,7 @@ static const struct bm2835_mmal_v4l2_ctr
  42         },
  43         {
  44                 V4L2_CID_SCENE_MODE, MMAL_CONTROL_TYPE_STD_MENU,
  45 -               -1,     /* Min is computed at runtime */
  46 +               -1,     /* Min (mask) is computed at runtime */
  47                 V4L2_SCENE_MODE_TEXT,
  48                 V4L2_SCENE_MODE_NONE, 1, NULL,
  49                 MMAL_PARAMETER_PROFILE,