1 From 1bfdc259652abe22a587fd6d856c1b71168cccb2 Mon Sep 17 00:00:00 2001
2 From: Hauke Mehrtens <hauke@hauke-m.de>
3 Date: Thu, 3 Oct 2013 20:49:10 +0200
4 Subject: [PATCH 3/5] b44: abort when no PHY is available at all
6 When the phy address is 31, this means that there is no PHY connected
7 to this MAC at all, no internal and no external PHY. Reading these PHY
8 registers causes a system reset on some routers.
10 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
12 drivers/net/ethernet/broadcom/b44.c | 6 ++++++
13 drivers/net/ethernet/broadcom/b44.h | 1 +
14 2 files changed, 7 insertions(+)
16 --- a/drivers/net/ethernet/broadcom/b44.c
17 +++ b/drivers/net/ethernet/broadcom/b44.c
18 @@ -2207,6 +2207,12 @@ static int b44_init_one(struct ssb_devic
19 goto err_out_powerdown;
22 + if (bp->phy_addr == B44_PHY_ADDR_NO_PHY) {
23 + dev_err(sdev->dev, "No PHY present on this MAC, aborting\n");
25 + goto err_out_powerdown;
29 bp->mii_if.mdio_read = b44_mii_read;
30 bp->mii_if.mdio_write = b44_mii_write;
31 --- a/drivers/net/ethernet/broadcom/b44.h
32 +++ b/drivers/net/ethernet/broadcom/b44.h
33 @@ -282,6 +282,7 @@ struct ring_info {
35 #define B44_MCAST_TABLE_SIZE 32
36 #define B44_PHY_ADDR_NO_LOACL_PHY 30 /* no local phy regs */
37 +#define B44_PHY_ADDR_NO_PHY 31 /* no phy present at all */
38 #define B44_MDC_RATIO 5000000
40 #define B44_STAT_REG_DECLARE \